From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#44294: No widen by xref-find-definitions Date: Fri, 30 Oct 2020 18:54:34 +0200 Message-ID: References: <87mu06p1aw.fsf_-_@mail.linkov.net> <5cfcbbf0-beef-3c0a-9641-a010925dbda4@yandex.ru> <87r1pgivdz.fsf@mail.linkov.net> <871rhgcgen.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12323"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 Cc: 44294@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 30 17:55:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kYXgF-00035Z-IM for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 30 Oct 2020 17:55:11 +0100 Original-Received: from localhost ([::1]:42360 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kYXgE-00047P-Jb for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 30 Oct 2020 12:55:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59330) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kYXg6-00046O-Gh for bug-gnu-emacs@gnu.org; Fri, 30 Oct 2020 12:55:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48000) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kYXg6-0004bB-7V for bug-gnu-emacs@gnu.org; Fri, 30 Oct 2020 12:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kYXg6-0001Jc-4y for bug-gnu-emacs@gnu.org; Fri, 30 Oct 2020 12:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 30 Oct 2020 16:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44294 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch Original-Received: via spool by 44294-submit@debbugs.gnu.org id=B44294.16040768855028 (code B ref 44294); Fri, 30 Oct 2020 16:55:02 +0000 Original-Received: (at 44294) by debbugs.gnu.org; 30 Oct 2020 16:54:45 +0000 Original-Received: from localhost ([127.0.0.1]:59546 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYXfo-0001J2-V6 for submit@debbugs.gnu.org; Fri, 30 Oct 2020 12:54:45 -0400 Original-Received: from mail-ed1-f50.google.com ([209.85.208.50]:45883) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYXfn-0001Ip-OE for 44294@debbugs.gnu.org; Fri, 30 Oct 2020 12:54:44 -0400 Original-Received: by mail-ed1-f50.google.com with SMTP id dg9so7316251edb.12 for <44294@debbugs.gnu.org>; Fri, 30 Oct 2020 09:54:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=xlCom+zImu5uAyZC2vmDbJFpF5PRlBGLKEZxMV2r/H4=; b=foB+Qqe4KeKFO0q21VO+Q0JInrIn8DFzQJVX1gjWLCT0tf3xRMfF4caCZ7mspF+Gqn veg0xQ5SvOZZ+KDbrfOYrDVPCzJ8FOiNBrIDFWl1cd5EoDP/PAaqBHs250qMVhnDqmh5 l0E22LF/yMa52cmB6V3xanZ+mNqe4vlcrATqx6FVvCTqCIwIpXqm9MjtxTWF1c9iUL7a T8OXzEKzh9t98uOauPrzny8T+uTThLNRavzG2Qch67Y4p/0OeLGiYksF/dQ4G0txdNVz vIKvbo0BWkyggpRmXtJNxuiC095ysK4pdd2y7DTPMQSebWG14/Xsbwxe83AAItCvnsn3 IdBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=xlCom+zImu5uAyZC2vmDbJFpF5PRlBGLKEZxMV2r/H4=; b=IB7T8diBg/SDqKmJ/5j6FedkkO+EDGqJaoFu+Fzzb0d9NEqabuMuxw4ZdXd6sLzJP5 P3B7qZYKCP+tKlPGYYfx/1gVyBAkYvKA2wr0ohDoI9ACrkjO5R5gojB5rlkSfDRJJnsO If5uEJ1bCv2d7cVXerhUpB6vQX+bR2jhEvpML4ZLiz8GPDi6OvEQOteNgr0R0RO3UF6w QcOMf6M/JieRnGWhXG5EyFTCIL9lYme8vc1/+mPRsLfFB3jd+VXkhDSJZNoHX0I5Jaan Gmot2fvDgrL8eOHkwtN/IkwO/XqgcAPywIUL9Ew76z9X85sYL4JzJE4KH3Mbac9LmKZJ UKaA== X-Gm-Message-State: AOAM530wwvCfgyD1Il4LwN0hpoFORd/qb4QV3P9umeH+DNcutOpEaRRD JZjNoBIw6Cl4pMYJR0G+zZAgvgrqdXyjNA== X-Google-Smtp-Source: ABdhPJzPUN3YM58GtECi5wLws4s7iAagYDgECTtLpRErtorVpg5GpFWyLsBF38pJk3E2wsd3hg08nA== X-Received: by 2002:aa7:d888:: with SMTP id u8mr2453081edq.210.1604076877162; Fri, 30 Oct 2020 09:54:37 -0700 (PDT) Original-Received: from [192.168.0.4] ([66.205.71.3]) by smtp.googlemail.com with ESMTPSA id d14sm3286273edx.53.2020.10.30.09.54.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Oct 2020 09:54:36 -0700 (PDT) In-Reply-To: <871rhgcgen.fsf@mail.linkov.net> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:192162 Archived-At: On 30.10.2020 09:38, Juri Linkov wrote: > I see now what you mean. Then maybe better to revert the change in > etags-goto-tag-location to restore its original behavior, and > fix only its usage by xref, i.e. exactly the same change > for xref-location-marker ((l xref-etags-location)) as was made > for xref-location-marker ((l xref-elisp-location)): Sounds good. 'find-tag-in-order' calls 'widen' already, so 'find-tag' is probably fine. I would personally combine the revert and the new change in one commit, but either option will work, obviously.