unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Paul Eggert <eggert@cs.ucla.edu>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 25128@debbugs.gnu.org
Subject: bug#25128: Reorder lisp.h to declare types before using them
Date: Sun, 25 Dec 2016 10:15:27 -0800	[thread overview]
Message-ID: <aee69558-cc3c-9141-ce52-e1dae5986fd7@cs.ucla.edu> (raw)
In-Reply-To: <83a8bjyjn9.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 146 bytes --]

Eli Zaretskii wrote:
> However, it breaks the MS-Windows 32-bit build --with-wide-int:

Sorry about that. Should be fixed now, with the attached:

[-- Attachment #2: 0001-Fix-typo-in-lisp.h-reordering-patch.patch --]
[-- Type: text/x-diff, Size: 830 bytes --]

From 8c0f6ba65d4a277b0e99c3ce15c82f308d964f04 Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Sun, 25 Dec 2016 10:12:39 -0800
Subject: [PATCH] Fix typo in lisp.h reordering patch

* src/lisp.h (XUNTAG) [!USE_LSB_TAG]: Remove duplicate defn.
Reported by Eli Zaretskii (Bug#25128#19).
---
 src/lisp.h | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/src/lisp.h b/src/lisp.h
index 23d3ae4..dc2c7a6 100644
--- a/src/lisp.h
+++ b/src/lisp.h
@@ -996,14 +996,6 @@ XFASTINT (Lisp_Object a)
   return n;
 }
 
-/* Extract A's pointer value, assuming A's type is TYPE.  */
-INLINE void *
-XUNTAG (Lisp_Object a, int type)
-{
-  intptr_t i = USE_LSB_TAG ? XLI (a) - type : XLI (a) & VALMASK;
-  return (void *) i;
-}
-
 #endif /* ! USE_LSB_TAG */
 
 /* Extract A's value as an unsigned integer.  */
-- 
2.7.4


  reply	other threads:[~2016-12-25 18:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-07  7:19 bug#25128: Reorder lisp.h to declare types before using them Paul Eggert
2016-12-07 16:09 ` Eli Zaretskii
2016-12-07 16:30   ` Paul Eggert
2016-12-25 17:38     ` Paul Eggert
2016-12-25 17:59       ` Eli Zaretskii
2016-12-25 18:15         ` Paul Eggert [this message]
2016-12-25 18:19           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aee69558-cc3c-9141-ce52-e1dae5986fd7@cs.ucla.edu \
    --to=eggert@cs.ucla.edu \
    --cc=25128@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).