From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#51622: 29.0.50; [PATCH v3] Abbreviate remote home directories in `abbreviate-file-name' Date: Mon, 15 Nov 2021 17:14:33 -0800 Message-ID: References: <5ac0b5f3-302c-2f96-771c-8d38088aa573@gmail.com> <87mtmhmh60.fsf@gmx.de> <87a6ihchbo.fsf@gmx.de> <87sfw7u7zw.fsf@gmx.de> <9c2f6b1b-9091-3996-e414-0de4b1618f7f@gmail.com> <874k8eg5mf.fsf@gmx.de> <6deae031-0bbd-9dec-d9d1-3e74e45acaeb@gmail.com> <87o86l9wya.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="391"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 51622@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 16 02:15:14 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mmn45-000AXU-UV for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 16 Nov 2021 02:15:13 +0100 Original-Received: from localhost ([::1]:35826 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mmn44-0007GT-SJ for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 15 Nov 2021 20:15:12 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:53884) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mmn3u-0007G5-WC for bug-gnu-emacs@gnu.org; Mon, 15 Nov 2021 20:15:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45056) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mmn3u-0004MQ-OA for bug-gnu-emacs@gnu.org; Mon, 15 Nov 2021 20:15:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mmn3u-0008UN-Bs for bug-gnu-emacs@gnu.org; Mon, 15 Nov 2021 20:15:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 16 Nov 2021 01:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51622 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51622-submit@debbugs.gnu.org id=B51622.163702528232583 (code B ref 51622); Tue, 16 Nov 2021 01:15:02 +0000 Original-Received: (at 51622) by debbugs.gnu.org; 16 Nov 2021 01:14:42 +0000 Original-Received: from localhost ([127.0.0.1]:56602 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mmn3Z-0008TS-V5 for submit@debbugs.gnu.org; Mon, 15 Nov 2021 20:14:42 -0500 Original-Received: from mail-pj1-f44.google.com ([209.85.216.44]:51173) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mmn3Y-0008TE-3i for 51622@debbugs.gnu.org; Mon, 15 Nov 2021 20:14:40 -0500 Original-Received: by mail-pj1-f44.google.com with SMTP id x7so14297877pjn.0 for <51622@debbugs.gnu.org>; Mon, 15 Nov 2021 17:14:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=9EyqBB11khZ0yV7MM7u8OXzoHR5fdyRFRmvFyRmJDcc=; b=cLG6+e4VuUfJJ9+V3SnTSj4BDJErwPNA+GEVk/7ovIMuM8wtG6Ar9UieEA6WVUOOeT SSU4TvyKUpuoq1Jp9q8ZkPApfY45zWSpljhVESR36y5ApJY21gfsjvzf6Pt7O+qyPQq2 oH+s6j8aurEFma8FoOuq4n5WhyZnI90Ec9PhqFqTfxFks1bjTqPEz+mxCdTaEnyOXJqN txpoqXPy7vDDuDX30nPts9cv3O49rTOi6wt/Pe3O2YZRLj0uILqedx5dXdn7T3Mr8oBB miJ871VXXfkSDlTiuvt+pLtUtbeuF2aAL2Oj9ampmVyg9U07/AbKsuX+RCdAzToZIJv8 BEIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=9EyqBB11khZ0yV7MM7u8OXzoHR5fdyRFRmvFyRmJDcc=; b=diKcQ6HZyQ/kRIOPHHrnjdREHBuckClZYldHDhT70vDdt0lW7VMCk/Im+017wY6/bn WoQn0Fp3pYmOEo1yqr5rRynWLJFlmY/dZHPyDH8TGgzr6/oeR9QH/pMjsX546eEXaB84 Rp07dygfbjlQ7Abd6Ur70vu0JsGEaSeGcvfEvGMczp0ywW0T4HkRJql5TAjkmZZcj3lb l//eli861RzE1RQ4Psl0B7pKxivW+W7a+CiNDSM63R6O6xjjdUiqy15YDkEqxyjFlyG4 02Lvz6igWxowSCO/9CBypaVfofb6BIItUBlO/nFbXZjoSsAdXhudLDRfr6X1QGTBR4fn yEPA== X-Gm-Message-State: AOAM533U/Y9cFbxUz0zrhfsZrq/3rzlcoKCyfCX9su2BVqIrIZfFYMYm jeqxsa/r6w8zeaAcQy0M212leKWbYNA= X-Google-Smtp-Source: ABdhPJx2CKey+vnJJbLm91YchsuGHY+5+bP+G+JSRdkJs2MyYIKg3NAmc/IH1YIrsDWrrMhsoC0qCA== X-Received: by 2002:a17:902:9b95:b0:143:b899:5b12 with SMTP id y21-20020a1709029b9500b00143b8995b12mr25369445plp.13.1637025273995; Mon, 15 Nov 2021 17:14:33 -0800 (PST) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id p1sm18162271pfo.143.2021.11.15.17.14.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Nov 2021 17:14:33 -0800 (PST) In-Reply-To: <87o86l9wya.fsf@gmx.de> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:220090 Archived-At: On 11/15/2021 8:59 AM, Michael Albinus wrote: >> Fixing your comments below *did* regress performance for abbreviating >> Tramp file names compared to current master (it takes 1.47x as long >> now in the worst case), but it's still considerably faster than Emacs >> 28. I've attached updated benchmark results to show the difference. > > Yes, that's the price we have to pay for clean code. I've explained why > it is needed. Agreed. It's better to be "slow and right" than "fast and wrong". :) > I've committed everything to master. Then I ran the regression tests, > and there were indeed some few surprises. All of them shall be fixed now > with my commit after yours. Thanks for merging everything. I'll be sure to keep the changes in your followup commit in mind (especially the `tramp-compat-funcall' parts) if I make any future Tramp patches. > I tend to close this bug report now, since everything reported has been > implemented. The open points don't need this bug anymore for progress. > > WDYT? Sounds good to me, we can close this.