From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#29599: 26.0; `dframe.el' binds keys unconditionally when loaded Date: Wed, 6 Dec 2017 22:10:52 -0800 (PST) Message-ID: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1512627135 5707 195.159.176.226 (7 Dec 2017 06:12:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 7 Dec 2017 06:12:15 +0000 (UTC) To: 29599@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Dec 07 07:12:08 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eMpPj-0001DR-NT for geb-bug-gnu-emacs@m.gmane.org; Thu, 07 Dec 2017 07:12:08 +0100 Original-Received: from localhost ([::1]:59167 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eMpPn-0005xf-SF for geb-bug-gnu-emacs@m.gmane.org; Thu, 07 Dec 2017 01:12:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57936) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eMpPh-0005vo-P9 for bug-gnu-emacs@gnu.org; Thu, 07 Dec 2017 01:12:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eMpPe-0000Yc-I3 for bug-gnu-emacs@gnu.org; Thu, 07 Dec 2017 01:12:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41084) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eMpPe-0000YL-Dj for bug-gnu-emacs@gnu.org; Thu, 07 Dec 2017 01:12:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eMpPe-0002rE-5n for bug-gnu-emacs@gnu.org; Thu, 07 Dec 2017 01:12:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 07 Dec 2017 06:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 29599 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.151262706910919 (code B ref -1); Thu, 07 Dec 2017 06:12:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 7 Dec 2017 06:11:09 +0000 Original-Received: from localhost ([127.0.0.1]:49765 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eMpOm-0002q3-Sb for submit@debbugs.gnu.org; Thu, 07 Dec 2017 01:11:09 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:38605) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eMpOl-0002pg-4j for submit@debbugs.gnu.org; Thu, 07 Dec 2017 01:11:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eMpOe-0007ml-Uy for submit@debbugs.gnu.org; Thu, 07 Dec 2017 01:11:01 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:47475) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eMpOe-0007ma-R0 for submit@debbugs.gnu.org; Thu, 07 Dec 2017 01:11:00 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57801) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eMpOd-0005ti-Nq for bug-gnu-emacs@gnu.org; Thu, 07 Dec 2017 01:11:00 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eMpOa-0007ib-GT for bug-gnu-emacs@gnu.org; Thu, 07 Dec 2017 01:10:59 -0500 Original-Received: from aserp2130.oracle.com ([141.146.126.79]:39078) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eMpOa-0007gw-6s for bug-gnu-emacs@gnu.org; Thu, 07 Dec 2017 01:10:56 -0500 Original-Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.21/8.16.0.21) with SMTP id vB767U8f099033 for ; Thu, 7 Dec 2017 06:10:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : subject : content-type : content-transfer-encoding; s=corp-2017-10-26; bh=GDecq8MklC18xkNbNH7fvq5+4H7is3t6YWZc4t3g66g=; b=lE9EkPmCRpSXa/63WufmKDxH3346b0iAtEKz2+LUMz9//KEcyaSxjQflwU35Oudf0fNS MvoPI0nMqlvsnaKylFWMywHXYH2f5dgWj4R8RfSkAPD0qK+m/F1v1isB91CUmgv/pthg LRtPgzSBJvSrdEnvvtJE1JKg18smE0h/gW20Lc1BNI5rS+GVTmgRoT6hdmEAhCgA0vfQ Mf9/sf6DV0doAQkK1Zx4kY5FTGRhv83OXDcZ7f1TvcuXJu1spUz8z9IaAqyycBWrrGeE w4OovfiJRxah5ksRXUCMOXiPPd2y3KJcC4efI36Bl/HJ7bLx4SMONEKecGfUgz805inO RA== Original-Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by aserp2130.oracle.com with ESMTP id 2epct9dr9g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 07 Dec 2017 06:10:54 +0000 Original-Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id vB76Asmh027075 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 7 Dec 2017 06:10:54 GMT Original-Received: from abhmp0001.oracle.com (abhmp0001.oracle.com [141.146.116.7]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id vB76Ar8t012469 for ; Thu, 7 Dec 2017 06:10:54 GMT X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4615.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8737 signatures=668643 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=1 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1712070095 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:140776 Archived-At: Well, not completely unconditionally. But I see this: (if (boundp 'special-event-map) (progn (define-key special-event-map [make-frame-visible] =09'dframe-handle-make-frame-visible) (define-key special-event-map [iconify-frame] =09'dframe-handle-iconify-frame) (define-key special-event-map [delete-frame] =09'dframe-handle-delete-frame)) ) That condition that the map exists isn't, I think, sufficient to give it license to bind keys in the map. I must have done something after my init file was loaded that required `dframe.elc' to be loaded, and that load overwrote bindings I made in my init file. I don't know what I did that caused dframe to be loaded, but that shouldn't matter. I don't think it should overwrite key bindings just by being loaded. In my init file I do this (after loading library `thumb-frm.el', which defines `thumfr-thumbify-frame-upon-event'): (when (and (eq system-type 'windows-nt) (fboundp 'thumfr-thumbify-frame-upon-event)) (define-key special-event-map [iconify-frame] 'thumfr-thumbify-frame-upon-event)) But dframe.el overwrites that binding when it gets loaded. Shouldn't dframe.el bind its own commands to `special-event-map' keys only if those keys are not already bound? I don't know what it's doing or why, but this doesn't seem very polite of it. Why should it think that just by being loaded it should (re-)bind keys? In GNU Emacs 26.0.90 (build 3, x86_64-w64-mingw32) of 2017-10-13 Repository revision: 906224eba147bdfc0514090064e8e8f53160f1d4 Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --without-dbus --host=3Dx86_64-w64-mingw32 --without-compress-install 'CFLAGS=3D-O2 -static -g3''