From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#27397: [PATCH] New commands for bulk tracing of elisp functions Date: Sun, 18 Jun 2017 01:59:57 +0300 Message-ID: References: <1348823a-7623-8146-8cc0-8c0eff13e458@orcon.net.nz> <94d27dbb-46d3-1d6f-4849-251a0929d413@orcon.net.nz> <70000e90-328c-c084-3e3c-bbde96b16110@orcon.net.nz> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1497740475 32008 195.159.176.226 (17 Jun 2017 23:01:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 17 Jun 2017 23:01:15 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:54.0) Gecko/20100101 Thunderbird/54.0 To: Phil Sainty , 27397@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jun 18 01:01:10 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dMMiM-0007yu-3O for geb-bug-gnu-emacs@m.gmane.org; Sun, 18 Jun 2017 01:01:10 +0200 Original-Received: from localhost ([::1]:36474 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dMMiR-0005KI-8u for geb-bug-gnu-emacs@m.gmane.org; Sat, 17 Jun 2017 19:01:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52309) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dMMiH-0005JK-Mc for bug-gnu-emacs@gnu.org; Sat, 17 Jun 2017 19:01:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dMMiE-0004uj-Ky for bug-gnu-emacs@gnu.org; Sat, 17 Jun 2017 19:01:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51122) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dMMiE-0004uf-GR for bug-gnu-emacs@gnu.org; Sat, 17 Jun 2017 19:01:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dMMiE-0005BM-9n for bug-gnu-emacs@gnu.org; Sat, 17 Jun 2017 19:01:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Jun 2017 23:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27397 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 27397-submit@debbugs.gnu.org id=B27397.149774040819849 (code B ref 27397); Sat, 17 Jun 2017 23:01:02 +0000 Original-Received: (at 27397) by debbugs.gnu.org; 17 Jun 2017 23:00:08 +0000 Original-Received: from localhost ([127.0.0.1]:53799 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dMMhM-0005A5-Bz for submit@debbugs.gnu.org; Sat, 17 Jun 2017 19:00:08 -0400 Original-Received: from mail-wm0-f50.google.com ([74.125.82.50]:36773) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dMMhK-00057t-R9 for 27397@debbugs.gnu.org; Sat, 17 Jun 2017 19:00:07 -0400 Original-Received: by mail-wm0-f50.google.com with SMTP id m125so51621086wmm.1 for <27397@debbugs.gnu.org>; Sat, 17 Jun 2017 16:00:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=CL3YP4AiD2Q4CVF3b3CbmOOn7NkwMcGpqV2pT0yRspI=; b=OFL1XMug7DXEGoTyvDR3MOsKXYyBbjqJsTfwn6CgbvDiwTZQr0KtCvG/f7oNH7D4+m 8aDcCcJJWS3V++SiXguq5d6K9Xf0A57XBSF4ctveIf8cxFuf1lNufZG/IJCc0mWw/gFN 7JDV4bVpwkC0yEShQ9pkX9SXMUT4kl3+4T5JBlgqMNaYdKKwzRnUeSqqF+cpmVmWyPMn UJx8D8ayf2N3sEAcfjMcYTybTDFQvCCErYEe+KXz0QHvkp/Rv0izJWfGXSm50t6KGYkE A2J5tDYHv4oWDEMDuV0ZZhn0brKHdS+Aywz3Q9bxXdaMKYXOaAlPF6RUUxfCCzHIap3s iSCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=CL3YP4AiD2Q4CVF3b3CbmOOn7NkwMcGpqV2pT0yRspI=; b=DScI5C0Kxk33DHRLUYaWKRLc7v/UCE0CPir0ktn4chiwHBbJR3wMSjXucz9vS96I37 s4ERiIBqnHZJaoSJXeZb9zlEdC0NM4EoyLx4yt5eKeknsRm6V0+RGpBKT/ROxxJZvRls WZv8fcnR/519g5IJCZPA7NQNkoYqM2gwyIkfCKCqt9sD/ZijcRs6wnguvJfDkKwsds+v 2eqEnFYN/2lku1qX0GI0Onq72ObX2IxrCLgtFEdAV9+baQxYKoO6hHIt4BpEPPPhgQA3 Uxiy6CMBfgZ12geAsXHYxZTcF3SXZzuRC9WSoFpF1vH/HB0kz9Om6UXBkJU2DdJfCuoj yxhw== X-Gm-Message-State: AKS2vOzd0pgDz2fijTuTxvGKpUSKtJx/8G4VopZ7YAhmjY1DgeSCkgwR h9u7lu3k0Pk08zI2Woo= X-Received: by 10.28.145.12 with SMTP id t12mr2482306wmd.7.1497740400649; Sat, 17 Jun 2017 16:00:00 -0700 (PDT) Original-Received: from [192.168.1.3] ([185.105.174.193]) by smtp.googlemail.com with ESMTPSA id j10sm4979295wre.67.2017.06.17.15.59.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 17 Jun 2017 15:59:59 -0700 (PDT) In-Reply-To: <70000e90-328c-c084-3e3c-bbde96b16110@orcon.net.nz> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:133714 Archived-At: On 6/17/17 3:31 PM, Phil Sainty wrote: > In the process I noticed that the existing behaviour of trace--read-args > was quite unfriendly if you wanted to set a trace buffer but had no need > of a context expression -- typing RET at the context expression prompt > triggered an "End of file during parsing" error, as that input string > is processed by `read-from-string'. > > I've changed that code to treat an empty input as "nil" (which is read > to `nil'), and to ignore `nil' context expressions entirely (as opposed > to printing their evaluated value as "[nil]" in the trace buffer). Sounds good. Why the rename, though? Those are not arguments for the function we're going to trace. trace--read-args sounds as appropriate, if not more.