From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#24725: 25.1.50; vc-region-history may exceed max line number of file in repository Date: Thu, 20 Oct 2016 02:22:32 +0300 Message-ID: References: <87y41llol4.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1476919413 19472 195.159.176.226 (19 Oct 2016 23:23:33 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 19 Oct 2016 23:23:33 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:50.0) Gecko/20100101 Thunderbird/50.0 To: Tino Calancha , 24725@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 20 01:23:29 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bx0CT-0001id-Ju for geb-bug-gnu-emacs@m.gmane.org; Thu, 20 Oct 2016 01:23:09 +0200 Original-Received: from localhost ([::1]:51560 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bx0CV-0000ny-Ph for geb-bug-gnu-emacs@m.gmane.org; Wed, 19 Oct 2016 19:23:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41433) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bx0CP-0000nh-KC for bug-gnu-emacs@gnu.org; Wed, 19 Oct 2016 19:23:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bx0CM-0003qE-Gh for bug-gnu-emacs@gnu.org; Wed, 19 Oct 2016 19:23:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:33939) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1bx0CM-0003q9-Bz for bug-gnu-emacs@gnu.org; Wed, 19 Oct 2016 19:23:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bx0CM-00069o-7V for bug-gnu-emacs@gnu.org; Wed, 19 Oct 2016 19:23:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Oct 2016 23:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24725 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 24725-submit@debbugs.gnu.org id=B24725.147691936223587 (code B ref 24725); Wed, 19 Oct 2016 23:23:02 +0000 Original-Received: (at 24725) by debbugs.gnu.org; 19 Oct 2016 23:22:42 +0000 Original-Received: from localhost ([127.0.0.1]:40129 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bx0C1-00068N-Pc for submit@debbugs.gnu.org; Wed, 19 Oct 2016 19:22:41 -0400 Original-Received: from mail-lf0-f48.google.com ([209.85.215.48]:32902) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bx0C0-000687-OY for 24725@debbugs.gnu.org; Wed, 19 Oct 2016 19:22:41 -0400 Original-Received: by mail-lf0-f48.google.com with SMTP id x79so52360514lff.0 for <24725@debbugs.gnu.org>; Wed, 19 Oct 2016 16:22:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=5htqAs6zAejpQ+GcJFNJkMlNeUl48whMDnjX31NEL8Y=; b=TR+Yy+GtjxRQZ0XbKdAcz7l5ztz/e7C/k9csTXJV3jxOR2WYRuzKiLD+jrjZNQqm8Y NvfVppefqnUdQPTy1rt2JT48VaPwaZ+MLasQZHfqnmZfCH5deZE8OwVsEQKl+tucaC0e Cd61th/GZlbB5Jr7pSmNN/VuDXV93ulxM6nFeMtVaShnwjaujGCR77Bw1z8OudA1/5uz M0iqIh6cncHQx58WYBL8GIuUB8seskTI+JMEdyM/Ikz4jc5dBWn591pyQ0KVEJc13xMY HoJ+eucxoKIDG2Kwbt/YybD6JM7K+jp5khtInx9u5EPXYowtewunqfay8mydWaRt6rk5 dE7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=5htqAs6zAejpQ+GcJFNJkMlNeUl48whMDnjX31NEL8Y=; b=WbBKefKYqZtACYv+x/hICUQXAIiCf4ps7U+BxzmD1boKkb2ySYbO0SN5j2ATC25oBC v4aG8gLXhn+i78XYDIpSZ3CDcfHvfW9DCjI1F77L25iUPK0tNmveVCeBKgtidYDkyQxW 5W65Czkk0OHXXwM61wdWm37U1QG3czV9Y4S5VKpEoT6TNzQxi6J1tBnDFF+YjztIWVk/ GvBdE7kslCJLzg6ZAWk80sUuvMb3g6ZJvxjlGppSnt6A+7SOMJ4rGZP4RxIh7coPV9vo uLJ8ZXa8JSnfCSFzNzOtM062QWul4y0wvhcBl/XiIqFd/FPq4/LA/XsAs+enPE/0lA0u QRzg== X-Gm-Message-State: AA6/9RmRe6/OMQ7kRLTZWg9xAPwXkUsQC3PhFDGEYJmoc47tfhu5qRmMtfkcu8jZJGP5hA== X-Received: by 10.194.18.137 with SMTP id w9mr6386455wjd.198.1476919354668; Wed, 19 Oct 2016 16:22:34 -0700 (PDT) Original-Received: from [192.168.1.3] ([185.105.173.41]) by smtp.googlemail.com with ESMTPSA id qa7sm73027203wjc.39.2016.10.19.16.22.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 19 Oct 2016 16:22:34 -0700 (PDT) In-Reply-To: <87y41llol4.fsf@gmail.com> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:124695 Archived-At: Hi! On 18.10.2016 17:27, Tino Calancha wrote: > > emacs -Q lisp/vc/vc.el > C-x h > M-x vc-region-history RET > fatal: file vc.el has only 2921 lines > ;; vc.el has 2922 lines but Git ignores the last empty line. With your patch, what will happen if the file does not end with a newline (which can be some people's or tools' preference)? Currently, in that case the above scenario works fine. Maybe we need a different check, rather than substracting. Or try (line-number-at-pos (1- (point-max))) instead of (1- (line-number-at-pos (point-max))).