From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#46827: Broken initial size of GTK3 frame Date: Mon, 1 Mar 2021 09:31:20 +0100 Message-ID: References: <6caa020a-084c-e3f2-7a34-262f7127b21b@gmx.at> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------56A36B79EF97695157091D41" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25397"; mail-complaints-to="usenet@ciao.gmane.io" To: 46827@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Mar 01 09:32:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lGdyN-0006TO-44 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 01 Mar 2021 09:32:11 +0100 Original-Received: from localhost ([::1]:38094 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lGdyM-0007jc-31 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 01 Mar 2021 03:32:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44458) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lGdyE-0007jT-8i for bug-gnu-emacs@gnu.org; Mon, 01 Mar 2021 03:32:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36444) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lGdyE-0003Be-17 for bug-gnu-emacs@gnu.org; Mon, 01 Mar 2021 03:32:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lGdyD-0002DT-TP for bug-gnu-emacs@gnu.org; Mon, 01 Mar 2021 03:32:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 01 Mar 2021 08:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46827 X-GNU-PR-Package: emacs Original-Received: via spool by 46827-submit@debbugs.gnu.org id=B46827.16145874928483 (code B ref 46827); Mon, 01 Mar 2021 08:32:01 +0000 Original-Received: (at 46827) by debbugs.gnu.org; 1 Mar 2021 08:31:32 +0000 Original-Received: from localhost ([127.0.0.1]:47990 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lGdxk-0002Cl-4l for submit@debbugs.gnu.org; Mon, 01 Mar 2021 03:31:32 -0500 Original-Received: from mout.gmx.net ([212.227.15.18]:46771) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lGdxi-0002CY-8Y for 46827@debbugs.gnu.org; Mon, 01 Mar 2021 03:31:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1614587484; bh=h7zzguAZnO98w1bwh2WfJsmHdXz16f5dfmddenU2mfg=; h=X-UI-Sender-Class:From:Subject:To:References:Date:In-Reply-To; b=gJGVjK84ubMqzJqqU149Of0BWQUfV/nDXToWM9Du1DLluAWrq8G/1z8rN7ysDPg6k z2rVP4mftxbHSl/H3kxSJ+fcnekS2oUOpgfmiAcPLYv3puKaXPGYaHPHZkn0rO9obp ySHzkt/qYFUcZur289BBVi80vfHg9Et3dJ1yhmi8= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from [192.168.1.101] ([213.162.73.118]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MbRk3-1lnmz42DI9-00bvOZ for <46827@debbugs.gnu.org>; Mon, 01 Mar 2021 09:31:24 +0100 In-Reply-To: <6caa020a-084c-e3f2-7a34-262f7127b21b@gmx.at> Content-Language: en-US X-Provags-ID: V03:K1:0mbvfQy2eEjZugrr7kzDnOV07E37PZrYON7BiSyR22xQp9TOxwg Th4gX+s873aj4mRVM51+asJSpYCdEWgZXY1cRbofkeYaOHmGfKeVBbKiHfuyuTo1iStrGWG 8oA2NXjec8TY4goBUwtZB1vdQbo/80Or2Iwi6T1Lrt15TahGp0I6S1Biv5DJApoYKxUmWHs R2rGSs/j3IR9Xn1MYzNFw== X-UI-Out-Filterresults: notjunk:1;V03:K0:Hm95Awu0Qi8=:tEn2cTmE8W+5+jXBF5CgAO PTMKVr8oO/XHV6gGbCgMLAs3DOX+VjMgzP4EapF1h8DB/JLfwuwyPybWqWHR571QctLRQr9UJ F8S/tqIaWMfhBX7tigeb82PQtUSlPxb/QVDy912hvR6sj0uqzxCgq8dVggMnrawR23hW6AL60 DwuXEyXFzuypPQ5gAXFkl1wjJZ5h4pmwilxXwSri3GyI7mNoFglXNa8LsJuqjMn0h4/zuvYpR Bd5aCBmzrEYAk5sypkXKzEvvcZh+3x2I/bZ8mZ6MUOhFkdT/TVz5KP9x3MXe6xRGKSHXiAJgE kilsKsYhGHcxIvlIX6394k21FJOwIF9k7a0TMY14z/ksxW0QkD20VF5VuFZ2scHzpZhXjF5sD v1OfRt75hVilRIj5hK9UFANGCq1YofsXtvumWkJqAh2n+2HuLMufLOgO1O7qB4hOZT9NmudPt xcBX/QfHfGw4QGknWGxYGepIWiPXKW8uy2XRXYU8Db+fBbj7lDOuTM86fYq6KXYhKqzvIHL1m P9L7rEjFRsBuycjHJzHjAM06oaTERSvqGfZNz3GOe/jt8vyb9K7V5IAfeFLp5ldTiMIGBGerJ YpN+B/7OTOdFTnm0VWcWblNrdLtPXXUFUaSdQMCJ1onOPwQHHwG/rz9dU43CB08kpnM31bl9j 9hCeDoIiOEO2mLCmhbt9KcGpT3dkrpsON0Ij3lMkPVOjMmtkuNaLWYOlVhhDf6xRGFzG8TDat +SzxP3CSLZwJFfP4ClyUgB2SOeacRNMSz9iLyZ+xhHIMTEj9n0K5DNxdXL2ltesMI37AjQOx X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201063 Archived-At: This is a multi-part message in MIME format. --------------56A36B79EF97695157091D41 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Re-sending this since it apparently got lost by the bug tracker: > Reverting 58430f29968a5661caff630d20dbbe7c864fe08d with current master > does _not_ fix the bug, so something else must be at play here too. It turns out that the "something else" is just that /* Querying further backends can be very slow, so we only do it if the user has explicitly requested it (Bug#43177). */ if (query_all_font_backends == false) break; The attached patch reverting 58430f29968a5661caff630d20dbbe7c864fe08d and removing the entity above fixes the bug on master. martin --------------56A36B79EF97695157091D41 Content-Type: text/x-patch; name="font.c.diff" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="font.c.diff" diff --git a/src/font.c b/src/font.c index a59ebe216b..1bb1eb29a5 100644 =2D-- a/src/font.c +++ b/src/font.c @@ -2797,34 +2797,24 @@ font_list_entities (struct frame *f, Lisp_Object s= pec) val =3D XCDR (val); else { - Lisp_Object copy; - val =3D (driver_list->driver->list) (f, scratch_font_spec); - /* We put zero_vector in the font-cache to indicate that - no fonts matching SPEC were found on the system. - Failure to have this indication in the font cache can - cause severe performance degradation in some rare - cases, see bug#21028. */ - if (NILP (val)) - val =3D zero_vector; - else - val =3D Fvconcat (1, &val); - copy =3D copy_font_spec (scratch_font_spec); - ASET (copy, FONT_TYPE_INDEX, driver_list->driver->type); - XSETCDR (cache, Fcons (Fcons (copy, val), XCDR (cache))); + if (!NILP (val)) + { + Lisp_Object copy =3D copy_font_spec (scratch_font_spec); + + val =3D Fvconcat (1, &val); + ASET (copy, FONT_TYPE_INDEX, driver_list->driver->type); + XSETCDR (cache, Fcons (Fcons (copy, val), XCDR (cache))); + } } - if (ASIZE (val) > 0 + + if (VECTORP (val) && ASIZE (val) > 0 && (need_filtering || ! NILP (Vface_ignored_fonts))) val =3D font_delete_unmatched (val, need_filtering ? spec : Qnil, size= ); - if (ASIZE (val) > 0) - { - list =3D Fcons (val, list); - /* Querying further backends can be very slow, so we only do - it if the user has explicitly requested it (Bug#43177). *= / - if (query_all_font_backends =3D=3D false) - break; - } + + if (VECTORP (val) && ASIZE (val) > 0) + list =3D Fcons (val, list); } list =3D Fnreverse (list); --------------56A36B79EF97695157091D41--