From: martin rudalics via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Juri Linkov <juri@linkov.net>
Cc: 59862@debbugs.gnu.org
Subject: bug#59862: quit-restore per window buffer
Date: Sat, 15 Jun 2024 10:41:54 +0200 [thread overview]
Message-ID: <ad0bfe5d-817b-4d11-b82f-90c5a76b4c81@gmx.at> (raw)
In-Reply-To: <86msnne7ut.fsf@mail.linkov.net>
+ (< (seq-count (lambda (w) (window-parameter w 'quit-restore))
The entire clause in 'quit-restore-window' governed by
(eq (nth 1 quit-restore) 'tab)
needs a comment on what it is supposed to restore. Basically, you check
here whether WINDOW is the only window with a 'quit-restore' parameter.
Is it that what you really want? If a window has a 'quit-restore'
parameter whose second element is 'tab' does that mean that all other
windows on the same frame must also have such a parameter? What happens
if there are other windows without a 'quit-restore' parameter?
As designed, the 'quit-restore' parameter can cause the deletion of its
window only if there are other windows on the same frame. It can cause
the deletion of its frame only if there is no other window on its frame.
Are these principles preserved by your patch?
> + (window-list-1 nil 'nomini))
I suppose that nil is not correct here when WINDOW is not on the
selected frame. I'd rather use that window instead here.
> + 2))
> (tab-bar-close-tab)
> ;; If the previously selected window is still alive, select it.
> (window--quit-restore-select-window quit-restore-2))
martin
next prev parent reply other threads:[~2024-06-15 8:41 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-06 17:32 bug#59862: quit-restore per window buffer Juri Linkov
2024-06-02 6:45 ` Juri Linkov
2024-06-03 9:34 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-03 9:53 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-03 16:09 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-04 6:53 ` Juri Linkov
2024-06-05 16:56 ` Juri Linkov
2024-06-11 6:52 ` Juri Linkov
2024-06-12 8:57 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-13 6:47 ` Juri Linkov
2024-06-13 8:21 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-14 17:35 ` Juri Linkov
2024-06-15 8:41 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2024-06-16 16:50 ` Juri Linkov
2024-06-17 14:48 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-08 16:49 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-09 6:58 ` Juri Linkov
2024-07-09 8:52 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-10 6:50 ` Juri Linkov
2024-07-10 9:16 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-11 6:47 ` Juri Linkov
2024-07-11 8:36 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-12 6:54 ` Juri Linkov
2024-07-12 8:20 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-14 7:49 ` Juri Linkov
2024-07-15 7:32 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-16 6:09 ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-16 6:09 ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
[not found] ` <87frs9kgve.fsf@>
2024-07-16 8:22 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-16 22:14 ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-16 22:14 ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
[not found] ` <871q3tc7da.fsf@>
2024-07-17 9:23 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-30 8:20 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-31 17:30 ` Juri Linkov
2024-08-01 6:37 ` Juri Linkov
2024-08-01 7:50 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-08-01 7:49 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-08-01 16:01 ` Juri Linkov
2024-10-08 17:53 ` Juri Linkov
2024-10-09 8:46 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-09 16:17 ` Juri Linkov
2024-10-10 14:54 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-10 18:28 ` Juri Linkov
2024-10-11 7:50 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-13 6:18 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad0bfe5d-817b-4d11-b82f-90c5a76b4c81@gmx.at \
--to=bug-gnu-emacs@gnu.org \
--cc=59862@debbugs.gnu.org \
--cc=juri@linkov.net \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).