From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= Newsgroups: gmane.emacs.bugs Subject: bug#61104: 29.0.60; typescript-ts-mode does not provide compilation-mode support Date: Sat, 28 Jan 2023 15:28:04 +0100 Message-ID: References: <316aee65-50c6-9dad-5b8d-08d90675c5a5@secure.kjonigsen.net> <83o7qjbu0l.fsf@gnu.org> <83lelnazs1.fsf@gnu.org> Reply-To: jostein@kjonigsen.net Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------7CEHBLLEaGIwiM07dWpz0ndT" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18137"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Cc: casouri@gmail.com, 61104@debbugs.gnu.org, theo@thornhill.no To: Eli Zaretskii , jostein@kjonigsen.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 28 15:29:36 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pLmCz-0004UH-Ld for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 28 Jan 2023 15:29:35 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pLmCX-0007Ws-BP; Sat, 28 Jan 2023 09:29:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pLmCV-0007WM-R0 for bug-gnu-emacs@gnu.org; Sat, 28 Jan 2023 09:29:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pLmCV-0003nG-EB for bug-gnu-emacs@gnu.org; Sat, 28 Jan 2023 09:29:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pLmCU-0000N6-IO for bug-gnu-emacs@gnu.org; Sat, 28 Jan 2023 09:29:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 Jan 2023 14:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61104 X-GNU-PR-Package: emacs Original-Received: via spool by 61104-submit@debbugs.gnu.org id=B61104.16749160951371 (code B ref 61104); Sat, 28 Jan 2023 14:29:02 +0000 Original-Received: (at 61104) by debbugs.gnu.org; 28 Jan 2023 14:28:15 +0000 Original-Received: from localhost ([127.0.0.1]:39950 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLmBi-0000M3-GY for submit@debbugs.gnu.org; Sat, 28 Jan 2023 09:28:14 -0500 Original-Received: from out5-smtp.messagingengine.com ([66.111.4.29]:35603) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLmBg-0000Lr-Mf for 61104@debbugs.gnu.org; Sat, 28 Jan 2023 09:28:13 -0500 Original-Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id A2C405C00EB; Sat, 28 Jan 2023 09:28:07 -0500 (EST) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Sat, 28 Jan 2023 09:28:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:reply-to:sender:subject:subject:to:to; s=fm2; t= 1674916087; x=1675002487; bh=PTaNJmWTplLzDhnSQNe8ZOAgqzgNw9RRLCl v55DjC48=; b=Wzjt6cN8cpp2C+R0P0j749JrKRbDI8sjR7f+N1+OijFA9jyZPuQ +L7huMgVF3P9SHDIFd2OqniokzKTz/0BegErNRliBs8WozKjeyx+b9uxDk38/JpZ CXHAtyO9ERY557WdGQjcyW57MflP2uM1DXrbB/L7WJ3p4s/asRUZsA+ReHnsj6FJ vo3Cj3lMzPm5f3NxbzDZl0wMw9d8ypI4ojk0NjOPGVpsua3cWQekdzTHasNy7/cO kEVEoRKCG7Sa7DYlqVU8FcUKATwkSzyTzGxuuTtbRaR7PAQh0FU1nW6zrN+PFL58 iNLrk20eEwMQ2DGPlUm5hgBep6Ibj4mrpIg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1674916087; x=1675002487; bh=PTaNJmWTplLzD hnSQNe8ZOAgqzgNw9RRLClv55DjC48=; b=Q6n78PFaGim+ry8eR56FoXuqoDCGK fQ/Fa/b+TU5hgVw7PGDTruIJl6vwo/+5jYp1Bk2dMu9FJX0Cn1FVJxIdn9VKO9vd ojizitAJrAOtlRtUvuFdBQXvcznONkCAeyeQlH/4mi+mJU3oa9z9O2Q9/XYrHDVN L8WlkgqwFKg7CFxvVDuDRW7qotOoorTt41cOHB6Zql+1AR7iwdq9eStNumMZ0IVk k9fNDXNBrXrxO5b3BAfZqzQSc1x7Gl+URhvovEgJPs3IYkz4iRdyiQaAG/tv0eic +y8JqA0CrC/q8p+/Nuezaat+qHteruF63lz1WhcA/tXdOp01sWfKeW9Vg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedruddvkedgieefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurheptgfkffggfghruffvvehfhfgjsehmtderredtfeejnecuhfhrohhmpeflohhs thgvihhnucfmjhppnhhighhsvghnuceojhhoshhtvghinhesshgvtghurhgvrdhkjhhonh highhsvghnrdhnvghtqeenucggtffrrghtthgvrhhnpedvfeeffeefieegueegkefgkeev tdevfeevffeghfdukeeffeevhefgheevhfehteenucffohhmrghinhepvghlrdhishenuc evlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehjohhsthgv ihhnsehsvggtuhhrvgdrkhhjohhnihhgshgvnhdrnhgvth X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 28 Jan 2023 09:28:06 -0500 (EST) Content-Language: en-GB, nb-NO In-Reply-To: <83lelnazs1.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254300 Archived-At: This is a multi-part message in MIME format. --------------7CEHBLLEaGIwiM07dWpz0ndT Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/28/23 08:23, Eli Zaretskii wrote: > > I don't think doing this in the major-mode file will improve locality, > because we have compilation-minor-mode, which should be able to do its > thing even if the relevant major mode is not yet loaded. Fair enough! > >> - adding it in compile.el, to improve ability to oversee all >> expressions, and be able to optimize those? >> >> I see csharp-mode.el has the expressions added directly there. Should I >> go about preparing patches doing >> the same for typescript-ts-mode too? > I don't see why not. Ok. Attached is a patch which adds Typescript tsc-support to compile.el. Is this OK to install in emacs-29? I also see in retrospect that my comment about csharp-mode above may been somewhat ambiguous and easy to misunderstand (and seemingly you did). To be clear: csharp-mode includes the compilation-mode regexps in the major-mode, not in compile.el. Is this also something we should aim to fix for emacs-29, or should we leave that for master? -- Jostein --------------7CEHBLLEaGIwiM07dWpz0ndT Content-Type: text/x-patch; charset=UTF-8; name="0001-Add-support-for-Typescript-compilation-to-compilatio.patch" Content-Disposition: attachment; filename*0="0001-Add-support-for-Typescript-compilation-to-compilatio.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSBiNjBjMDY4NmZjOTI1MjkwZmYyMDFlZDc5Mzk5ZTQ4ZWJjNDdkNmQwIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/Sm9zdGVpbj0yMEtqPUMzPUI4bmln c2VuPz0gPGpvc3RlaW5Aa2pvbmlnc2VuLm5ldD4KRGF0ZTogU2F0LCAyOCBKYW4gMjAyMyAx NToyMzoxMSArMDEwMApTdWJqZWN0OiBbUEFUQ0hdIEFkZCBzdXBwb3J0IGZvciBUeXBlc2Ny aXB0IGNvbXBpbGF0aW9uIHRvIGNvbXBpbGF0aW9uLW1vZGUKCi0tLQogbGlzcC9wcm9nbW9k ZXMvY29tcGlsZS5lbCB8IDE4ICsrKysrKysrKysrKysrKysrKwogMSBmaWxlIGNoYW5nZWQs IDE4IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9saXNwL3Byb2dtb2Rlcy9jb21waWxl LmVsIGIvbGlzcC9wcm9nbW9kZXMvY29tcGlsZS5lbAppbmRleCA1NzU4ZWFkZjk5Ni4uMWU1 N2QwYjdiYjIgMTAwNjQ0Ci0tLSBhL2xpc3AvcHJvZ21vZGVzL2NvbXBpbGUuZWwKKysrIGIv bGlzcC9wcm9nbW9kZXMvY29tcGlsZS5lbApAQCAtNjQ5LDYgKzY0OSwyNCBAQCBjb21waWxh dGlvbi1lcnJvci1yZWdleHAtYWxpc3QtYWxpc3QKICAgICA7OyB3ZSBkbyBub3Qga25vdyB3 aGF0IGxpbmVzIHdpbGwgZm9sbG93LgogICAgIChndWlsZS1maWxlICJeSW4gXFwoLitcXC4u K1xcKTpcbiIgMSBuaWwgbmlsIDApCiAgICAgKGd1aWxlLWxpbmUgIl4gKlxcKFswLTldK1xc KTogKlxcKFswLTldK1xcKSIgbmlsIDEgMikKKworICAgIDs7IFR5cGVzY3JpcHQgY29tcGls YXRpb24gcHJpb3IgdG8gdHNjIHZlcnNpb24gMi43LCAicGxhaW4iIGZvcm1hdDoKKyAgICA7 OyBncmVldGVyLnRzKDMwLDEyKTogZXJyb3IgVFMyMzM5OiBQcm9wZXJ0eSAnZm9vJyBkb2Vz IG5vdCBleGlzdC4KKyAgICAodHlwZXNjcmlwdC10c2MtcGxhaW4KKyAgICAgLChjb25jYXQK KyAgICAgICJeW1s6Ymxhbms6XV0qIgorICAgICAgIlxcKFteKFxyXG4pXStcXCkoXFwoWzAt OV0rXFwpLFxcKFswLTldK1xcKSk6W1s6Ymxhbms6XV0rIgorICAgICAgImVycm9yIFtbOmFs bnVtOl1dKzogW15cclxuXSskIikKKyAgICAgMSAyIDMgMikKKworICAgIDs7IFR5cGVzY3Jp cHQgY29tcGlsYXRpb24gYWZ0ZXIgdHNjIHZlcnNpb24gMi43LCAicHJldHR5IiBmb3JtYXQ6 CisgICAgOzsgc3JjL3Jlc291cmNlcy9kb2N1bWVudC50czoxNDA6MjIgLSBlcnJvciBUUzIz NjI6IHNvbWV0aGluZy4KKyAgICAodHlwZXNjcmlwdC10c2MtcHJldHR5CisgICAgICwoY29u Y2F0CisgICAgICAgIl5bWzpibGFuazpdXSoiCisgICAgICAgIlxcKFteKFxyXG4pXStcXCk6 XFwoWzAtOV0rXFwpOlxcKFswLTldK1xcKSAtIFtbOmJsYW5rOl1dKiIKKyAgICAgICAiZXJy b3IgW1s6YWxudW06XV0rOiBbXlxyXG5dKyQiKQorICAgICAxIDIgMyAyKQogICAgICkpCiAg ICJBbGlzdCBvZiB2YWx1ZXMgZm9yIGBjb21waWxhdGlvbi1lcnJvci1yZWdleHAtYWxpc3Qn LiIpCiAKLS0gCjIuMzkuMQoK --------------7CEHBLLEaGIwiM07dWpz0ndT--