From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#34763: 27.0.50; url-retrieve-synchronously misbehaves inside eldoc-documentation-function Date: Thu, 4 Apr 2019 02:37:49 +0300 Message-ID: References: <83a7i15vrk.fsf@gnu.org> <787f765a-42f4-40d0-3b78-e751f546fe6c@yandex.ru> <831s3c3ta8.fsf@gnu.org> <8f7ae869-2e94-5535-f16f-476348036dc2@yandex.ru> <83r2bc2csd.fsf@gnu.org> <83h8c63ek1.fsf@gnu.org> <7240d82b-5919-cee8-e3bc-81be8d996400@yandex.ru> <83pnqsyw68.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="129112"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:67.0) Gecko/20100101 Thunderbird/67.0 Cc: 34763@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Apr 04 01:49:28 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hBpdH-000XO2-Ud for geb-bug-gnu-emacs@m.gmane.org; Thu, 04 Apr 2019 01:49:28 +0200 Original-Received: from localhost ([127.0.0.1]:38722 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hBpdB-0002Tx-EO for geb-bug-gnu-emacs@m.gmane.org; Wed, 03 Apr 2019 19:49:21 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:43355) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hBpcx-0002PV-0F for bug-gnu-emacs@gnu.org; Wed, 03 Apr 2019 19:49:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hBpTD-0005OQ-Rm for bug-gnu-emacs@gnu.org; Wed, 03 Apr 2019 19:39:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58125) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hBpTC-0005M3-FQ for bug-gnu-emacs@gnu.org; Wed, 03 Apr 2019 19:39:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hBpTC-0000iV-C3 for bug-gnu-emacs@gnu.org; Wed, 03 Apr 2019 19:39:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 03 Apr 2019 23:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34763 X-GNU-PR-Package: emacs Original-Received: via spool by 34763-submit@debbugs.gnu.org id=B34763.15543346872662 (code B ref 34763); Wed, 03 Apr 2019 23:39:02 +0000 Original-Received: (at 34763) by debbugs.gnu.org; 3 Apr 2019 23:38:07 +0000 Original-Received: from localhost ([127.0.0.1]:43436 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hBpSJ-0000gs-1N for submit@debbugs.gnu.org; Wed, 03 Apr 2019 19:38:07 -0400 Original-Received: from mail-lj1-f182.google.com ([209.85.208.182]:37613) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hBpSE-0000gF-1o for 34763@debbugs.gnu.org; Wed, 03 Apr 2019 19:38:03 -0400 Original-Received: by mail-lj1-f182.google.com with SMTP id v13so398998ljk.4 for <34763@debbugs.gnu.org>; Wed, 03 Apr 2019 16:38:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=6oBnhgvuagx/S1TDhVWxgmsZdf7IR/pmdgHqfGR5T78=; b=IIVb70qoXm99CHT/4JzWssPQ5zFHO5tDTxjvqtbdYza8JVXLx4Iu4xdMn0AA3He8YF DVPaU4Yk8oaDGl3fqUhcZ3WjjGzw03+Bvm/cf3KKCoKUBj4DW3ni3p6vYyDjJ+YlyjBc 0xcUuXjRdJaL9iNG5sYbKNdVycMTNzYnj3Me6jQWsKC0IcNWKKDNvpgEiAUaFp1xE0aN 33wDl20u9yZtltK0RXBrKJ96zl4ke0sZ2/+LPp5sJTS2gmOQVxcvN6QqX4PgoY38C+b1 coe/1LpfFhkZf84gJM7YrQcEd6NXCzJWXRVvp/60uxwOppqHU690o7eBU6yT5NfWbP6q rNtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=6oBnhgvuagx/S1TDhVWxgmsZdf7IR/pmdgHqfGR5T78=; b=cUIkbOOaGkThd33tQEfhOI1FuJ1VnnnZpWr7BbawG1JwH0dLqrhvYZ4D/4ZajU8xLR 9DIjw9awxRIaDLmJFALU1CJ1lbN/tAgGmppwbou5bSJx2M0rdeBBKVb6056EDO7/1yxs IIvJ/gtVQtctkT3gEsfsXPUT9J1OgIxMl77ZQT2LSAIil8iDGoWyXgJZbmQ0Yjf0zZdE MadyKUA/i1BwiVfkaM0gJy9MloDgyr1RJZLhCC1hJLOm8zAoJWl6VJJoKBuLvhoC9Lzh NuGIy3Q6jGXtPdTieseKSTXMA+50VxejJhburfhelxipVF9xjL4a6Z66ijFKS0cHLEOn qHdg== X-Gm-Message-State: APjAAAUTltfWKddrLbtK1Sl3AlG/5WCfIBVcClJ6DEVSyjnCdlyZrIht hGp82WcfyDBEnx51Ql6h9P4YPKSk X-Google-Smtp-Source: APXvYqyQw7MKWI49q+mJ1aLsD3g4ZvF1uxxjpZ7x5+MD6TxNo9K3Jh7Nl2n+pmYWgROhRVKO5TSRSg== X-Received: by 2002:a2e:4a09:: with SMTP id x9mr1378874lja.19.1554334674606; Wed, 03 Apr 2019 16:37:54 -0700 (PDT) Original-Received: from [192.168.1.3] ([185.105.174.23]) by smtp.googlemail.com with ESMTPSA id q29sm3539550ljc.8.2019.04.03.16.37.51 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Wed, 03 Apr 2019 16:37:52 -0700 (PDT) In-Reply-To: <83pnqsyw68.fsf@gnu.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157149 Archived-At: On 15.03.2019 17:49, Eli Zaretskii wrote: > The code in the functions that react to quit-flag being non-nil should > be audited. They don't look clean to me, FWIW, and we don't generally > do such things from Lisp, we normally quit on the C level. Maybe this > whole sub-feature, whereby we show a message for interrupted > transfers, should be rethought. Apparently the idea is to handle quits, including contexts where inhibit-quit is t (947612be2c71d2478179694e8dfa538b9e8e07c1). So url-retrieve-synchronously uses with-local-quit around accept-process-output, and I guess the idea was to handle quits inside debugging output calls. So url-http-debug also does the job of clearing the sentinel and the filter of the connection's process. But maybe that's not enough: it doesn't kill the process and/or remove it from url-http-open-connections. (I'm guessing url-http-mark-connection-as-free would normally be called later if the sentinel wasn't removed). I'm not quite clear on how error handling should work here anyway. Asynchronous code is tricky that way.