From: Dmitry Gutov <dgutov@yandex.ru>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 47488@debbugs.gnu.org, Reuben Thomas <rrt@sc3d.org>
Subject: bug#47488: Treatment of # in js.el
Date: Tue, 11 May 2021 15:45:13 +0300 [thread overview]
Message-ID: <abc15155-3892-2c4c-7b62-d51d3decb41c@yandex.ru> (raw)
In-Reply-To: <87lf8lpijq.fsf@gnus.org>
On 11.05.2021 15:21, Lars Ingebrigtsen wrote:
> Dmitry Gutov <dgutov@yandex.ru> writes:
>
>> We could add a custom var that disables this behavior, of
>> course. js2-mode has one, but it only affects the parser, not the
>> indentation behavior.
>
> If we could avoid having a user option, that's be nice...
Probably not without seeing an occasional false positive, e.g. ...
>> Maybe check against a specific list of preprocessor instructions, such
>> as #define, #ifdef, etc.
>
> I think that sounds like a good solution. Grepping around a bit,
> perhaps `cpp-font-lock-keywords-source-directives' in font-lock.el would
> be a good source to use here?
... looking at the regexp it also matches #file, #line or #warning.
Each of these could also be a name of a private attribute, I think.
Still, if those are indeed standard preprocessor directives, this var
looks like a good choice.
next prev parent reply other threads:[~2021-05-11 12:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-29 21:28 bug#47488: Treatment of # in js.el Reuben Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-30 0:50 ` Dmitry Gutov
2021-05-08 12:43 ` Lars Ingebrigtsen
2021-05-09 11:18 ` Dmitry Gutov
2021-05-09 11:31 ` Dmitry Gutov
2021-05-10 8:29 ` Lars Ingebrigtsen
2021-05-10 12:12 ` Dmitry Gutov
2021-05-10 8:34 ` Reuben Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-05-10 12:14 ` Dmitry Gutov
2021-05-11 12:21 ` Lars Ingebrigtsen
2021-05-11 12:45 ` Dmitry Gutov [this message]
2021-05-12 13:32 ` Lars Ingebrigtsen
2021-05-12 13:53 ` Eli Zaretskii
2021-05-12 13:56 ` Lars Ingebrigtsen
2021-05-12 14:39 ` Andreas Schwab
2021-05-12 14:49 ` Eli Zaretskii
2021-05-12 14:56 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abc15155-3892-2c4c-7b62-d51d3decb41c@yandex.ru \
--to=dgutov@yandex.ru \
--cc=47488@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=rrt@sc3d.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).