From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#37950: 27.0.50; File error regression Date: Thu, 31 Oct 2019 23:39:07 -0700 Organization: UCLA Computer Science Department Message-ID: References: <87k18pztu5.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------6440C4DEC798E46F6AB51740" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="169527"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 Cc: 37950-done@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 01 07:40:16 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iQQbV-000hx2-SB for geb-bug-gnu-emacs@m.gmane.org; Fri, 01 Nov 2019 07:40:14 +0100 Original-Received: from localhost ([::1]:56764 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iQQbU-0004Rm-2h for geb-bug-gnu-emacs@m.gmane.org; Fri, 01 Nov 2019 02:40:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36388) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iQQbL-0004Mm-LG for bug-gnu-emacs@gnu.org; Fri, 01 Nov 2019 02:40:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iQQbK-0001pl-CG for bug-gnu-emacs@gnu.org; Fri, 01 Nov 2019 02:40:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46126) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iQQbK-0001pC-70 for bug-gnu-emacs@gnu.org; Fri, 01 Nov 2019 02:40:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iQQbK-0002la-0D for bug-gnu-emacs@gnu.org; Fri, 01 Nov 2019 02:40:02 -0400 In-Reply-To: <87k18pztu5.fsf@mail.linkov.net> Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Fri, 01 Nov 2019 06:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 37950 X-GNU-PR-Package: emacs Mail-Followup-To: 37950@debbugs.gnu.org, eggert@cs.ucla.edu, juri@linkov.net Original-Received: via spool by 37950-done@debbugs.gnu.org id=D37950.157259036110576 (code D ref 37950); Fri, 01 Nov 2019 06:40:01 +0000 Original-Received: (at 37950-done) by debbugs.gnu.org; 1 Nov 2019 06:39:21 +0000 Original-Received: from localhost ([127.0.0.1]:54947 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iQQaf-0002kV-6m for submit@debbugs.gnu.org; Fri, 01 Nov 2019 02:39:21 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:51934) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iQQad-0002kB-0T for 37950-done@debbugs.gnu.org; Fri, 01 Nov 2019 02:39:19 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id C04A0160101; Thu, 31 Oct 2019 23:39:12 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id ZyJKPAQzoGQa; Thu, 31 Oct 2019 23:39:12 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id E8A4F1604FF; Thu, 31 Oct 2019 23:39:11 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id kxUe_8hJyfJB; Thu, 31 Oct 2019 23:39:11 -0700 (PDT) Original-Received: from [192.168.1.9] (cpe-23-242-74-103.socal.res.rr.com [23.242.74.103]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id B586F160101; Thu, 31 Oct 2019 23:39:11 -0700 (PDT) Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:170577 Archived-At: This is a multi-part message in MIME format. --------------6440C4DEC798E46F6AB51740 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Thanks for the bug report. That one's my fault, as it was due to this patch: https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=ba0605779e0e207161441c08afdfac57ed603f69 which fixed a problem elsewhere but introduced a bug. I installed the attached patch to fix things. --------------6440C4DEC798E46F6AB51740 Content-Type: text/x-patch; name="0001-Fix-insert-file-contents-file-error-regression.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="0001-Fix-insert-file-contents-file-error-regression.patch" >From 3a1e7624ed234bb434cdafed59515cadd037cafa Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Thu, 31 Oct 2019 23:31:17 -0700 Subject: [PATCH] Fix insert-file-contents file error regression Problem reported for dired-view-file (Bug#37950). * src/fileio.c (Finsert_file_contents): When visiting, signal an error if the file could not be opened for any reason, rather than signaling an error only for nonexistent files, fixing a bug introduced in 2019-09-16T03:17:43!eggert@cs.ucla.edu. --- src/fileio.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/fileio.c b/src/fileio.c index a3121a26da..01f8a04e5d 100644 --- a/src/fileio.c +++ b/src/fileio.c @@ -4806,10 +4806,9 @@ by calling `format-decode', which see. */) unbind_to (count1, Qnil); } - if (!NILP (visit) - && current_buffer->modtime.tv_nsec == NONEXISTENT_MODTIME_NSECS) + if (!NILP (visit) && current_buffer->modtime.tv_nsec < 0) { - /* If visiting nonexistent file, return nil. */ + /* Signal an error if visiting a file that could not be opened. */ report_file_errno ("Opening input file", orig_filename, save_errno); } -- 2.17.1 --------------6440C4DEC798E46F6AB51740--