unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: 23597@debbugs.gnu.org
Subject: bug#23597: 24.5; `cl-values-list' should not be an alias for `identity'
Date: Sat, 21 May 2016 17:25:47 -0700 (PDT)	[thread overview]
Message-ID: <ab836a2e-5474-4070-8040-f03c17244f43@default> (raw)

Emacs Lisp does not support multiple values for its Common Lisp
emulation.  OK, fine.

But that is not a reason for this kind of definition.

`cl-values-list' should at least raise an error if its arg is not a
list.  That too is part of the Common Lisp definition of `values-list':
"Should signal type-error if its argument is not a proper list."

(cl-values-list 5) should not return 5.  It should raise a wrong-type
arg error.

A comment in cl-lib.el says this:

;; cl-multiple-value-bind and friends simply expect the target form to
;; return the values as a list.

It is not enough that `cl-multiple-value-bind' and friends expect that.
They are not the only context in which `cl-value-list' can be used.
`cl-values-list' is a general function on a list, and it needs to check
its argument to ensure that it is a list.

In GNU Emacs 24.5.1 (i686-pc-mingw32)
 of 2015-04-11 on LEG570
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --prefix=/c/usr --host=i686-pc-mingw32'





             reply	other threads:[~2016-05-22  0:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-22  0:25 Drew Adams [this message]
2019-07-28 12:15 ` bug#23597: 24.5; `cl-values-list' should not be an alias for `identity' Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ab836a2e-5474-4070-8040-f03c17244f43@default \
    --to=drew.adams@oracle.com \
    --cc=23597@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).