From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#20896: patch to add chained indentation Date: Thu, 12 Jan 2017 04:57:49 +0300 Message-ID: References: <87a8vnlrxs.fsf@gmx.us> <87tw97zav3.fsf@tromey.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1484186311 9264 195.159.176.226 (12 Jan 2017 01:58:31 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 12 Jan 2017 01:58:31 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:50.0) Gecko/20100101 Thunderbird/50.0 Cc: Daniel Colascione To: Tom Tromey , 20896@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jan 12 02:58:26 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cRUeW-0000LK-4t for geb-bug-gnu-emacs@m.gmane.org; Thu, 12 Jan 2017 02:58:08 +0100 Original-Received: from localhost ([::1]:58647 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cRUea-00011k-Cb for geb-bug-gnu-emacs@m.gmane.org; Wed, 11 Jan 2017 20:58:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45032) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cRUeT-00011U-Dc for bug-gnu-emacs@gnu.org; Wed, 11 Jan 2017 20:58:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cRUeQ-0003zZ-8n for bug-gnu-emacs@gnu.org; Wed, 11 Jan 2017 20:58:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35177) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cRUeQ-0003zP-49 for bug-gnu-emacs@gnu.org; Wed, 11 Jan 2017 20:58:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cRUeP-0001KL-KN for bug-gnu-emacs@gnu.org; Wed, 11 Jan 2017 20:58:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 12 Jan 2017 01:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20896 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20896-submit@debbugs.gnu.org id=B20896.14841862795093 (code B ref 20896); Thu, 12 Jan 2017 01:58:01 +0000 Original-Received: (at 20896) by debbugs.gnu.org; 12 Jan 2017 01:57:59 +0000 Original-Received: from localhost ([127.0.0.1]:50576 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cRUeN-0001K5-JH for submit@debbugs.gnu.org; Wed, 11 Jan 2017 20:57:59 -0500 Original-Received: from mail-lf0-f66.google.com ([209.85.215.66]:34380) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cRUeM-0001Js-7O for 20896@debbugs.gnu.org; Wed, 11 Jan 2017 20:57:58 -0500 Original-Received: by mail-lf0-f66.google.com with SMTP id q89so450870lfi.1 for <20896@debbugs.gnu.org>; Wed, 11 Jan 2017 17:57:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=bYDPNbcu/0jJQ5/io7IFtGo2sD6n5MOkvknlhIwMnkk=; b=EhuEQ9G4ESPev5OrIdvUtS5Hx0963GBbNjUqPbedROxVrrktit/wHH7PS2uGhEZYMq 9ML6m5/DDhQAFJ3rBBpSZSrED2Wez5HXFIJi/xGIzYS/D8gyEdPQBIU+4/QbrIj067m6 lPItr0s1SEUlkg02/ahh4Lg0y7OjHyg8R89DEGtqrn/ELsIZkE75fNzkMEenXgYkmzE2 Vs66fsb80eHn8Zr1yqHp9K1VODNVzHRmRVF6BeeOrvJ6CsweJ64Envycwjgmd/LI7DLz ywbVx6RIEt1ffAyeI0SwqYYG0vsrdV9mB4HWeV+cLwlPpVRNoAp+r5CNSKhKOLmyGH4I nkYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=bYDPNbcu/0jJQ5/io7IFtGo2sD6n5MOkvknlhIwMnkk=; b=TWxCx3O79K0ZmrO2pWWHzCXqHSZIF0/+G6UsTaw++DQWUSc55oNOcUD+MRc+roDNxl 4zbxXFdS31kbVa6UfExersXK6vBPAbN0Xt8xjgP0yA7eYsZAEgE5In1FU2kEvqyyGJZI EQTCmD2+QBIUSQPAuJrVUVw1k8GhLcS/ndyxyFxrMzMugGDtxUzBwUp8T8RevdRBFBs2 MHkyyszNXiOwLaZjQbW8APmfdTCHyOFKGHfgvJENGOgjFPY/pnUp2cdXe3Yc/y08ajcP e1cpzBqMwXMa8VbggqrkgGJhymKbAho5p3Ak0QBZYaLwXbYOp37H9mAVyobML0jmXlA/ k+vw== X-Gm-Message-State: AIkVDXLwvWpPKCXONuFQwE8xl5+MI7LXe2XGKAd9Yyn9wOAPauUSlYOZZzDzK2ovba45hw== X-Received: by 10.25.219.131 with SMTP id t3mr4533825lfi.163.1484186271807; Wed, 11 Jan 2017 17:57:51 -0800 (PST) Original-Received: from [192.168.1.174] ([178.252.127.239]) by smtp.googlemail.com with ESMTPSA id d79sm1830121lfd.46.2017.01.11.17.57.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Jan 2017 17:57:51 -0800 (PST) In-Reply-To: <87tw97zav3.fsf@tromey.com> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:128026 Archived-At: On 10.01.2017 09:29, Tom Tromey wrote: > This patch adds chained indentation, as requested in the bug. Thanks. > It comes > with some tests I'd just like to point out that it's much better to write indentation tests in the format used by test/manual/indent/js*. > (added to a file that first appears in patch in another > bug Not sure which patch you mean. This file seems new. As for review: js--skip-term-backward seems to be doing something similar to the loop in js--multi-line-declaration-indentation. Maybe a extraction and unification is in order.