From: "Jörg Bornemann" <foss@jbornemann.de>
To: Dmitry Gutov <dmitry@gutov.dev>, Juri Linkov <juri@linkov.net>
Cc: 68570@debbugs.gnu.org
Subject: bug#68570: 29.1; recompile might not re-use project-compile's buffer
Date: Tue, 23 Jan 2024 14:15:36 +0100 [thread overview]
Message-ID: <ab32c28a-71b1-49c2-b9e1-a35931817551@jbornemann.de> (raw)
In-Reply-To: <0598898e-8e25-43b1-92c0-4596ad242ec8@gutov.dev>
On 1/23/24 13:21, Dmitry Gutov wrote:
>> The patch that I proposed above is intended only for
>> recompiling from a compilation buffer. It sets
>> `compilation-buffer-name-function' in the compilation buffer.
>
> I think it behaves correctly inside the compilation buffer already? At
> least it did when I tested.
Yes. I can confirm that pressing g in a compilation buffer that's named
by project-compilation-name-buffer-function is already working correctly.
After reading Pengji's security concern (thanks Dmitry for pointing me
to it) I also think that it would be more favorable to let recompile
re-use a compilation buffer. That would indeed make project-recompile
superfluous.
next prev parent reply other threads:[~2024-01-23 13:15 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 16:17 bug#68570: 29.1; recompile might not re-use project-compile's buffer Jörg Bornemann
2024-01-19 20:19 ` Pengji Zhang
2024-01-20 14:27 ` Dmitry Gutov
2024-01-21 5:09 ` Dmitry Gutov
2024-01-21 18:18 ` Juri Linkov
2024-01-21 18:33 ` Dmitry Gutov
2024-01-22 7:31 ` Juri Linkov
2024-01-22 8:42 ` Jörg Bornemann
2024-01-22 18:20 ` Dmitry Gutov
2024-01-23 7:09 ` Juri Linkov
2024-01-23 12:21 ` Dmitry Gutov
2024-01-23 13:15 ` Jörg Bornemann [this message]
2024-01-23 17:31 ` Dmitry Gutov
2024-01-24 7:46 ` Juri Linkov
2024-01-24 12:06 ` Dmitry Gutov
2024-01-24 17:11 ` Juri Linkov
2024-01-26 0:44 ` Dmitry Gutov
2024-01-27 17:53 ` Juri Linkov
2024-01-28 13:42 ` Dmitry Gutov
2024-02-06 17:39 ` Juri Linkov
2024-02-07 18:43 ` Dmitry Gutov
2024-05-02 6:16 ` Juri Linkov
2024-05-02 7:11 ` Eli Zaretskii
2024-01-22 8:39 ` Jörg Bornemann
2024-01-22 18:20 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab32c28a-71b1-49c2-b9e1-a35931817551@jbornemann.de \
--to=foss@jbornemann.de \
--cc=68570@debbugs.gnu.org \
--cc=dmitry@gutov.dev \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).