From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#63648: 29.0.90; project.el: with switch-use-entire-map, switch-project errors on non-project commands Date: Fri, 1 Sep 2023 04:11:40 +0300 Message-ID: References: <86wn10e1wl.fsf@mail.linkov.net> <482a1ebc-165c-a0a4-98c0-5c404d1b1d0d@gutov.dev> <86jzwyxnxb.fsf@mail.linkov.net> <86o7m91z22.fsf@mail.linkov.net> <86pm6py6k4.fsf@mail.linkov.net> <86bki9y68h.fsf@mail.linkov.net> <86cz2f7bvo.fsf@mail.linkov.net> <86353axu48.fsf@mail.linkov.net> <87o7jfi00b.fsf@catern.com> <86msyhwrrg.fsf@mail.linkov.net> <86y1hs4kkg.fsf@mail.linkov.net> <86h6of66o3.fsf@mail.linkov.net> <86wmxb2qvh.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6049"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: Spencer Baugh , 63648@debbugs.gnu.org, sbaugh@catern.com To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 01 03:12:03 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qbshe-0001Ne-CH for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 01 Sep 2023 03:12:02 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qbshW-0001lz-Pe; Thu, 31 Aug 2023 21:11:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbshV-0001lr-Rp for bug-gnu-emacs@gnu.org; Thu, 31 Aug 2023 21:11:53 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qbshV-0003wa-Ju for bug-gnu-emacs@gnu.org; Thu, 31 Aug 2023 21:11:53 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qbshe-0001Gh-6k for bug-gnu-emacs@gnu.org; Thu, 31 Aug 2023 21:12:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 01 Sep 2023 01:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63648 X-GNU-PR-Package: emacs Original-Received: via spool by 63648-submit@debbugs.gnu.org id=B63648.16935307214869 (code B ref 63648); Fri, 01 Sep 2023 01:12:02 +0000 Original-Received: (at 63648) by debbugs.gnu.org; 1 Sep 2023 01:12:01 +0000 Original-Received: from localhost ([127.0.0.1]:59498 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbshc-0001GS-TO for submit@debbugs.gnu.org; Thu, 31 Aug 2023 21:12:01 -0400 Original-Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:51301) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbshb-0001GF-Fd for 63648@debbugs.gnu.org; Thu, 31 Aug 2023 21:12:00 -0400 Original-Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 2B3F3320039A; Thu, 31 Aug 2023 21:11:44 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Thu, 31 Aug 2023 21:11:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1693530703; x=1693617103; bh=cwwxBVHoswxO4PKTx+dqSNoIXMnRklsY11j 246wypsU=; b=I8pdLgOVgRBKYLprZ6WVsnrFxhUJKrFnpcGvRsYoi5kUxGYLKPC gJWJbT8Noh3/I6dwMGqVLn5cZdWzwjTAwA0+iDFZ1ViL75hsDo89uIToz/mb/Bh6 56L7u/sMBLMTLZjDZXKvUC+5h9EElIDEqzfQfmGiK6s2vHgPgk/V9zZgBAUk/BI8 ujkpgOzjWu2Kbm0QaFrYKBstiJUvtZACl0CzgojitmTM0bN4zibGFxLSxnuDvkPj j35j8oid5aETtXOgcuMlNATVmhhY49M+O/JcfnfbBetbdQSlkb/S9/vCeD7lGBTt okbE4b6r726g6JIOUtTA9rJDbPmksvW+/oQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1693530703; x=1693617103; bh=cwwxBVHoswxO4PKTx+dqSNoIXMnRklsY11j 246wypsU=; b=SKsXKHDftay17UYst3q/p2VhkYq3VelLxoG56kIY4u5K9z5zlr7 C9CXf6beWgbJLsMd1g4FX9O5RAKLv3ZzrkT7sb+RNrOcurD6wZ6BxhNCWyIjeST9 q+hDtjbbkLZ2y2ry/4iPd2FiBHxbmUFr4UFb2dNYQPjFd9oc2+2QaJPHaioKVdgz JgXWAzhB1HTrh5PPa2Dp74HN7yGXoS/j+OBAyBx5yys7LWs31adIojENvTqe1Ao8 icmNz8HkmW1epNAtFbc4foXk9g3NC2eJulJZGVj0EPOYnFdrZm5EiqCmqPlu/OZb Dn6t4KGGvjdAxrqUaEBI/OE39XBQBsCu07A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrudeguddggedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhephfeutdekveeggeetteekfeejffegudduudfhueevleeftdffffeggeeivddv jeelnecuffhomhgrihhnpehgnhhurdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepughmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 31 Aug 2023 21:11:41 -0400 (EDT) Content-Language: en-US In-Reply-To: <86wmxb2qvh.fsf@mail.linkov.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268857 Archived-At: On 31/08/2023 19:36, Juri Linkov wrote: >>>> - Unfortunately, using default-directory instead of the specialized >>>> variable which we added lately (project-current-directory-override) >>>> brings back the bug it was added for: https://debbugs.gnu.org/58784. The >>>> switch to a different design didn't fix the problem of the temporary >>>> binding for d-d in the buffer which is current when the command is >>>> executed. So adding the next-default-directory variable might not be the >>>> best idea after all. But the advice thingy can set a binding for any >>>> variable, including the *-override one. >>> I didn't test yet the cases from bug#58784. So this might require more >>> changes. >> >> We tried to make the default-directory binding work with a couple of >> different changes - it didn't work out. > > The problem is that let-binding overrides the buffer-local value: Yep. > ``` > (let ((default-directory "/tmp/")) > (list default-directory > (buffer-local-value 'default-directory (current-buffer)))) > => ("/tmp/" "/tmp/") > ``` > > Here is the shortest test case: 'C-x p p C-b' shows buffers > from two projects when using let-binding for default-directory, > because 'project-buffers' relies on > > (buffer-local-value 'default-directory buf) > > This could be fixed by adding special-handling of the default-directory > for the current buffer in 'project-buffers'. What kind of special handling? The "real" buffer-local value is hidden until the "let" exists, the global value is nil, and if the buffer is not a file-visiting one, there is no other file name to test against. Finally, whatever special handling we invent, would have to be mirrored by all subsequent new commands (built-in and third-party) which look up the value of default-directory. Especially project-related ones. How to popularize that knowledge, would be the next question for whatever solution we invent. >> A general question regarding this approach, for me, is: is a "prefix >> command" a real command? > > It's a real command that prepares some transient values for the next command. > Most existing prefix commands have no problems because they modify global > values. But 'default-directory' is the first buffer-local variable > used for the next command, therefore it requires special-handling. > Too bad that 'default-directory' is not a function. I suppose the new code could check against some property or dynamic var to distinguish prefix commands from "terminal" ones. >> And would they "swallow" these prepared variable bindings too early? > > The scope of the modified variable depends on concrete needs. > For example, set-transient-map restores its old value in pre-command-hook, > but display-buffer-override-next-command does this in post-command-hook. That can also work - though the odds of getting into an unrecoverable state (such as one I described) would be higher.