unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Juri Linkov <juri@jurta.org>
Cc: Bastien <bzg@altern.org>, 16542@debbugs.gnu.org
Subject: bug#16542: 24.3.50; When finding a file via a bookmark, that file is not part of file-name-history
Date: Tue, 28 Jan 2014 08:20:26 -0800 (PST)	[thread overview]
Message-ID: <aabf8e60-d906-4279-bbab-4f2f90733e13@default> (raw)
In-Reply-To: <87bnywpohw.fsf@mail.jurta.org>

> > 1. A user option such as what you describe, but with nil meaning
> >    "go for it generally: let the command decide", a non-nil list
> >    as you mention meaning "do not let these commands decide", and
> >    any other non-nil value meaning "do not let any command decide".
> 
> I think a cleaner solution would be to have two separate history
> lists:
>
> 1. history of minibuffer input
> 2. history of visited files
>
> and a new option to select which history to access via M-p
> in the minibuffer that reads a file name.

I see nothing "cleaner" about that.  But it is a reasonable proposal.

Here are some arguments against it:

a. That makes the lists exclusive - the file names are not merged
into one list.  So they are not accessible by simple cycling.

Unless you meant that #2 would subsume #1 as a proper subset.
(But a file name can be entered without the file being visited,
so your description of #2 would need to be changed slightly, if
we assume that #2 includes everything in #1.)

b. It means that the choice of which of those exclusive histories
to use would be decided ahead of time, when the user option is set.

c. It would not give the command any control over what is
appropriate for it.  I prefer that (i) the user have ultimate
control, and (ii) when allowed by the user, the command can decide.

> Actually we already have a history of recently visited files
> in recentf, so we could add `bookmark-jump' to `recentf-used-hooks'.
> Or maybe this is not needed because it already contains `find-file-
> hook'.

I agree that recentf should include files visited by jumping to
bookmarks.  I think that is already the case, but if not, yes,
let's fix that first, for sure.

The purpose of recentf is to record recently visited files.  The
purpose of `file-name-history' is to record file names entered in
the minibuffer.  Different purposes, for different uses.

Yet another approach would be to let users cycle through recentf
files during file-name input, using a different key from `M-p'
etc.  But that has the same drawback as your proposal: separate
list do not reflect a single chronological history.

Bastien's original suggestion, and the user option I presented,
include (some) visited files in `file-name-history', not just
in the recentf history.  I think this is clean and simple, and
the option I suggested (or similar) gives users and commands
adequate control over the behavior.

(But as we generalize from bookmarks, this discussion really
belongs in emacs-devel, not just this bug thread.)





  parent reply	other threads:[~2014-01-28 16:20 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-24 21:45 bug#16542: 24.3.50; When finding a file via a bookmark, that file is not part of file-name-history Bastien Guerry
2014-01-25  8:19 ` Dani Moncayo
2014-01-25  8:42   ` Drew Adams
2014-01-27 11:29     ` Bastien
2014-01-27 15:11       ` Drew Adams
2014-01-27 15:26         ` Bastien
2014-01-27 17:31           ` Drew Adams
2014-01-28  7:28             ` Juri Linkov
2014-01-28 13:28               ` Stefan Monnier
2014-01-29  9:10                 ` Juri Linkov
2014-01-29 10:43                 ` Bastien
2014-01-29 13:58                   ` Stefan Monnier
2014-01-28 16:20               ` Drew Adams [this message]
2020-08-25 10:57 ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aabf8e60-d906-4279-bbab-4f2f90733e13@default \
    --to=drew.adams@oracle.com \
    --cc=16542@debbugs.gnu.org \
    --cc=bzg@altern.org \
    --cc=juri@jurta.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).