From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#18090: 24.4.50; `delete-selection-helper' logic changed for non-mouse region? Date: Thu, 20 Sep 2018 08:04:56 -0700 (PDT) Message-ID: References: <95e066b9-792c-4b38-8f4b-fd225578ed45@default> <9859e098-daf7-4b67-a8a6-c53d01a18f93@default> <83fty4elsx.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1537455863 29997 195.159.176.226 (20 Sep 2018 15:04:23 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 20 Sep 2018 15:04:23 +0000 (UTC) Cc: 18090@debbugs.gnu.org To: Eli Zaretskii , Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Sep 20 17:04:19 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g30V8-0007g4-R2 for geb-bug-gnu-emacs@m.gmane.org; Thu, 20 Sep 2018 17:04:19 +0200 Original-Received: from localhost ([::1]:50902 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g30XF-0003Fn-6X for geb-bug-gnu-emacs@m.gmane.org; Thu, 20 Sep 2018 11:06:29 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40040) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g30X3-0003Fd-22 for bug-gnu-emacs@gnu.org; Thu, 20 Sep 2018 11:06:22 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g30Wq-0004lS-TC for bug-gnu-emacs@gnu.org; Thu, 20 Sep 2018 11:06:10 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:42890) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g30Wo-0004iz-OH for bug-gnu-emacs@gnu.org; Thu, 20 Sep 2018 11:06:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1g30Wo-0008Ta-E0 for bug-gnu-emacs@gnu.org; Thu, 20 Sep 2018 11:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Sep 2018 15:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18090 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18090-submit@debbugs.gnu.org id=B18090.153745590832518 (code B ref 18090); Thu, 20 Sep 2018 15:06:02 +0000 Original-Received: (at 18090) by debbugs.gnu.org; 20 Sep 2018 15:05:08 +0000 Original-Received: from localhost ([127.0.0.1]:47148 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g30Vw-0008SO-0l for submit@debbugs.gnu.org; Thu, 20 Sep 2018 11:05:08 -0400 Original-Received: from userp2130.oracle.com ([156.151.31.86]:36328) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g30Vt-0008Rg-UR for 18090@debbugs.gnu.org; Thu, 20 Sep 2018 11:05:06 -0400 Original-Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w8KF48Xf160274; Thu, 20 Sep 2018 15:04:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=oNa+DqZcVpb6MFOhYoEM2ZeR6tH9/qKYSRI6RTCRnko=; b=kTrpXjhh5t83KcyaJ5Dc9GfWgQ6HRuiMXN0uhVL/0LOqhOBGAfb/PcLll3TLTs+fuB/a VRZlpy0Dm5xfVcamERx+q+52kJ2JFkEGGFUzS5RPi1n+Ynm6No30khFlGbFpxvEqoorn YqRwZWIpPCDRhUzljBW6ZJceGzk91kSGrmD5rrT7LGb3iqrD2XR5lqfDsIEZMvcMqd1i csIY6C0HMT7kMaDAqynHv/Wpp63E54DphZglACwZ5BChbDk8riPLY+190jO8bXgPrFKX OzuHt/wv2koWQqn2EPcgaSl0QCJq76XxSWWLbVz5klq+LcyxzMSiy8YzNUl54oeu1lAS YQ== Original-Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by userp2130.oracle.com with ESMTP id 2mgsgu3eh9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 20 Sep 2018 15:04:59 +0000 Original-Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w8KF4wrR026985 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 20 Sep 2018 15:04:58 GMT Original-Received: from abhmp0008.oracle.com (abhmp0008.oracle.com [141.146.116.14]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w8KF4vRQ021376; Thu, 20 Sep 2018 15:04:57 GMT In-Reply-To: <83fty4elsx.fsf@gnu.org> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4735.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9021 signatures=668707 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1809200149 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:150484 Archived-At: > That change was made due to problems described in this thread: >=20 > https://urldefense.proofpoint.com/v2/url?u=3Dhttp- > 3A__lists.gnu.org_archive_html_emacs-2Ddevel_2007- > 2D06_msg01642.html&d=3DDwIBAg&c=3DRoP1YumCXCgaWHvlZYR8PZh8Bv7qIrMU > B65eapI_JnE&r=3DkI3P6ljGv6CTHIKju0jqInF6AOwMCYRDQUmqX22rJ98&m=3D1Sma > MGY0ePhv2v_dZNfjfbgjYaW_usF7c6AeSBPND4A&s=3DtjJCnI84nM3eLwqFSz2ImzZ > U1RBUgqh9dbJs3SvCK_w&e=3D >=20 > FWIW, I cannot reproduce the original problem reported by Juri in that > thread, in Emacs 22.1, which according to my calculations was released > before the change. So I cannot dig deeper into the issue, but my > first thought was that this code needs to be rethought/augmented due > to changes in Emacs 24 regarding selections, since currently the > default is not to copy to the kill-ring the region selected by > dragging the mouse. >=20 > I also don't think I understand your report, Drew. What exactly is > the problem you are complaining about? Surely, the problem is not the > code, but its effect; however, all you say about the effect is that > "yanking point is rotated only when the mouse was used". I don't > understand what "rotating yanking point" means, let alone why it is > problematic. >=20 > I hope Juri, who made that change, will be able to investigate some > more. I have my own code for `delete-selection-mode' stuff, including my own version of ` delete-selection-helper'. I added the two lines that were added to the vanilla version for reference, but I commented them out. I see no need for them - no problem without them. And I think it doesn't make sense to treat the mouse differently here. (while (and tail (string=3D (buffer-substring-no-properties (point) (mark= )) ;; Vanilla Emacs has this, which seems very wrong. ;; See Emacs bug #18090. ;;; (fboundp 'mouse-region-match) ;;; (mouse-region-match) ) I can't add more than that, I'm afraid. I don't see the bug that Juri reports, even though the code I use does not have those two commented lines.