From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#56459: 29.0.50; Edebug disables Eldoc Date: Wed, 1 Mar 2023 18:06:56 +0200 Message-ID: References: <87zghieol4.fsf@gmail.com> <871qurzzyv.fsf@gnus.org> <83pmibzx0k.fsf@gnu.org> <20220731195223.90596.FMU217810@trabanten-schwein.prv.splode.com> <87sfmg1bpf.fsf@gnus.org> <5dd202b1-3dfb-022a-d458-c0a13c1a2d59@yandex.ru> <83edqagcux.fsf@gnu.org> <0fc4cf3b-86af-027e-32f4-9c85e2650ae7@yandex.ru> <83ilfkfpgw.fsf@gnu.org> <83h6v4fp3z.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14848"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Cc: max.brieiev@gmail.com, larsi@gnus.org, 56459@debbugs.gnu.org, friedman@splode.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Mar 01 17:08:13 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pXP01-0003do-QY for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 01 Mar 2023 17:08:13 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pXOzs-0001tf-8t; Wed, 01 Mar 2023 11:08:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXOzq-0001sV-L2 for bug-gnu-emacs@gnu.org; Wed, 01 Mar 2023 11:08:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pXOzq-0003rz-91 for bug-gnu-emacs@gnu.org; Wed, 01 Mar 2023 11:08:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pXOzp-0000tD-U2 for bug-gnu-emacs@gnu.org; Wed, 01 Mar 2023 11:08:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 01 Mar 2023 16:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56459 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 56459-submit@debbugs.gnu.org id=B56459.16776868283357 (code B ref 56459); Wed, 01 Mar 2023 16:08:01 +0000 Original-Received: (at 56459) by debbugs.gnu.org; 1 Mar 2023 16:07:08 +0000 Original-Received: from localhost ([127.0.0.1]:54732 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXOyx-0000s5-KZ for submit@debbugs.gnu.org; Wed, 01 Mar 2023 11:07:07 -0500 Original-Received: from mail-wm1-f49.google.com ([209.85.128.49]:39763) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXOyv-0000rS-Bw for 56459@debbugs.gnu.org; Wed, 01 Mar 2023 11:07:06 -0500 Original-Received: by mail-wm1-f49.google.com with SMTP id t25-20020a1c7719000000b003eb052cc5ccso11804986wmi.4 for <56459@debbugs.gnu.org>; Wed, 01 Mar 2023 08:07:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1677686819; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=TfPmhkbnR/6cBkicT4pUEE7h1u9FOrbTvG3qNCEz+Jk=; b=nq17dq2d3L91wElcOkpfGg94KEMgDjB1JwJ3sHeiywXx8OLO6Q7W/w7thvUMekIyH2 F+lzsM7trIY9uGSlvhtL0p8ELnamHIQouAQwsUsIvncWlS51cqkPdLJzMvIyG21/qQcd AMamsMfdsMzCvddMMVZJjugxXPHy7nFBs93XXMKzVop4n1kM33Npk2RlTtdErFFETrxv peh7SgVfNRJNyu9gJ5JtyAXi5d0o7PYZnVa4hXvu0DoFxpLBj/AJ8Fb+mY/gVlknWuyo DRkcZ8FayIOqyaJGXiR/jFTWRgFTpchaLRVRPfU2uUwlcv+etWGjxgXaAd/8Y0Su5Kjo SWZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677686819; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=TfPmhkbnR/6cBkicT4pUEE7h1u9FOrbTvG3qNCEz+Jk=; b=h5pT11KzKtDgzo4WBJpSC2Kya/idC/YU3uZ9whaW1w4+vkf0G4kIuRcUhDBbu1uFUZ xxnsa3LuxBoZYxGXFOSQCyvmMYleJz+Qes1vPDED5olD6A1w/hgskbLzce7tX39ZPv9e wG9KHAbBmRyra/Otw2flOuqicLwIKdamhtTgjieGDkszLmbUWvC2GKUoWd51WViQP1fm dwBjk6xfIkbROYgBFxlXNHAbegsK5sdvKvdaHpd0HLtzaj0JOsncA7/IcWRMYL577h+U 0OjzTDQM02tl80mhQJrdr/gpqsseVIkU8FeiyINzC/nQ+1XZx6F75f10Q1WRsFANiCjW wO4w== X-Gm-Message-State: AO0yUKW2iJzQXMBkuTGlFpTYG/7fq+xDWrVdIsuO9f7EIvIlDtOwAbJf EC57zEPiiOGTdWmWJTaMVMg= X-Google-Smtp-Source: AK7set9uYhggNUrYbsYQWPNhw6Bu4fHWOPRU9P94cqMQI+aMOTNIyUa8PvyUD7he8ZQji15irXD/yw== X-Received: by 2002:a05:600c:319a:b0:3e2:a9e:4eaa with SMTP id s26-20020a05600c319a00b003e20a9e4eaamr5175376wmp.35.1677686819162; Wed, 01 Mar 2023 08:06:59 -0800 (PST) Original-Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id k24-20020a05600c0b5800b003e00c453447sm19049401wmr.48.2023.03.01.08.06.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Mar 2023 08:06:58 -0800 (PST) Content-Language: en-US In-Reply-To: <83h6v4fp3z.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:257077 Archived-At: On 01/03/2023 17:49, Eli Zaretskii wrote: >> Cc:max.brieiev@gmail.com,larsi@gnus.org,56459@debbugs.gnu.org, >> friedman@splode.com >> Date: Wed, 01 Mar 2023 17:42:07 +0200 >> From: Eli Zaretskii >> >> So I've now reverted that change, and I'm reopening the bug. It will >> have to be fixed in some other way. > One possibility would be to show the ElDoc info on the mode line when > Edebug is active. But the difficulty with that is to figure out how > to revert the mode line to the original shape when Edebug finishes. > We currently show the info on the mdoe line when the current buffer is > a minibuffer, and remove the info in minibuffer-exit-hook, but how to > do that in the Edebug case? edebug-mode-hook? This seems to work: diff --git a/lisp/emacs-lisp/eldoc.el b/lisp/emacs-lisp/eldoc.el index 3f5cf0ad0dc..01b48b0f45b 100644 --- a/lisp/emacs-lisp/eldoc.el +++ b/lisp/emacs-lisp/eldoc.el @@ -296,9 +296,12 @@ eldoc-minibuffer-message This function displays the message produced by formatting ARGS with FORMAT-STRING on the mode line when the current buffer is a minibuffer. Otherwise, it displays the message like `message' would." - (if (minibufferp) + (defvar edebug-active) + (if (or edebug-active (minibufferp)) (progn - (add-hook 'minibuffer-exit-hook + (add-hook (if (minibufferp) + 'minibuffer-exit-hook + 'edebug-mode-hook) (lambda () (setq eldoc-mode-line-string nil ;; https://debbugs.gnu.org/16920 eldoc-last-message nil))