From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jared Finder via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#69915: 30.0.50; mouse-autoselect-window has no effect in terminal Date: Thu, 04 Apr 2024 09:32:28 -0700 Message-ID: References: <86v856hon0.fsf@gnu.org> <00f0925f3a878950933691973fecd536@finder.org> <86frw6bww3.fsf@gnu.org> <86zfud9uqa.fsf@gnu.org> <4b7f7d0f711e2dc81c3ffffa8efb4714@finder.org> <3f7cc786-af09-4095-8a8f-9a34ebfeaa2a@gmx.at> Reply-To: Jared Finder Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23656"; mail-complaints-to="usenet@ciao.gmane.io" Cc: olaf.rogalsky@gmail.com, 69915@debbugs.gnu.org, Eli Zaretskii To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Apr 04 18:33:48 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rsQ27-0005rd-JE for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 Apr 2024 18:33:47 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rsQ1P-00052Z-Ka; Thu, 04 Apr 2024 12:33:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rsQ1K-000522-5f for bug-gnu-emacs@gnu.org; Thu, 04 Apr 2024 12:33:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rsQ1J-0008Gq-Dj for bug-gnu-emacs@gnu.org; Thu, 04 Apr 2024 12:32:57 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rsQ1O-0001Te-E1 for bug-gnu-emacs@gnu.org; Thu, 04 Apr 2024 12:33:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jared Finder Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Apr 2024 16:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69915 X-GNU-PR-Package: emacs Original-Received: via spool by 69915-submit@debbugs.gnu.org id=B69915.17122483575493 (code B ref 69915); Thu, 04 Apr 2024 16:33:02 +0000 Original-Received: (at 69915) by debbugs.gnu.org; 4 Apr 2024 16:32:37 +0000 Original-Received: from localhost ([127.0.0.1]:34618 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rsQ0y-0001QX-RD for submit@debbugs.gnu.org; Thu, 04 Apr 2024 12:32:37 -0400 Original-Received: from greenhill.hpalace.com ([192.155.80.58]:43344) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rsQ0w-0001QH-8a for 69915@debbugs.gnu.org; Thu, 04 Apr 2024 12:32:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=finder.org; s=2018; t=1712248348; bh=UM+uC7GUYtImfjYMppN5kE4mReuhCZqX2PjImayW+BA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=vP5+XloPHDF9W9UpJiWPOL3O3v+cH4aISCQhx9CcEVwTeZXVR42UVIHB/pNXuPm52 8f0SunwsxFuQxbPIz/kt8KVwNe7SeLKmeK4fT1MZJXp6vDWfAWlDvQIAdqDxsVjKvv 2bPULESWJQZzhBTMIacdONfgiKvb97YfTKvJDoOZWTM+jPzQ9HTn1+Gbb40Rkfw4/n RxP3KTh6R2ljiQzGbE0kUXbFnIYSwPDoHFv8RUT5RZtUUHEIZY1A5y3XNda5Hs/ZDB Mm1acc8OneqVQsq5iSNkJOxLYFUOmPpwzMNIEfBJP+ETQaDkld8HBOmFifM6rykJlJ j1nvMfg3k/VTw== Original-Received: from mail.finder.org (unknown [192.155.80.58]) by greenhill.hpalace.com (Postfix) with ESMTPSA id 540A644E; Thu, 4 Apr 2024 16:32:28 +0000 (UTC) In-Reply-To: <3f7cc786-af09-4095-8a8f-9a34ebfeaa2a@gmx.at> X-Sender: jared@finder.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:282672 Archived-At: On 2024-04-01 04:40, Eli Zaretskii wrote: > On 2024-04-02 00:50, martin rudalics wrote: >> Jared and Olaf, so I think the minibuffer test in the patch should >> stay, but please see Martin's suggestions above. > >> Martin, did you mean we should change Olaf's patch to xt-mouse.el use >> minibuffer-window-active-p or we should change handle-select-window in >> window.el to use minibuffer-window-active-p? >> >> I have a preference to keep xt-mouse.el aligned with xterm.c as well >> as other native code checks, all which use MINI_WINDOW_P >> (window-minibuffer-p in Lisp) currently. > > 'minibuffer-window-active-p' should be more accurate but I do not fully > understand its semantics any more. For anything you and Olaf do, I'd > recommend 'window-minibuffer-p' / MINI_WINDOW_P. Eli, given this feedback I don't think Olaf's patch should be altered as it currently uses window-minibuffer-p. Let me know if you would like any further changes. -- MJF