From: David Caldwell <david@porkrind.org>
To: Alan Third <alan@idiocy.org>
Cc: Philipp Stephani <p.stephani2@gmail.com>, 27059@debbugs.gnu.org
Subject: bug#27059: Can't compile master branch on Mac OS X
Date: Fri, 26 May 2017 12:30:44 -0700 [thread overview]
Message-ID: <a99edd50-3cb2-88eb-fba5-7f4b6685ea31@porkrind.org> (raw)
In-Reply-To: <3bf5df87-a353-89d1-f78d-e15046321759@porkrind.org>
[-- Attachment #1.1: Type: text/plain, Size: 1342 bytes --]
On 5/26/17 10:23 AM, David Caldwell wrote:
> On 5/25/17 12:02 PM, Alan Third wrote:
>> On Thu, May 25, 2017 at 09:25:47AM -0700, David Caldwell wrote:
>>> That didn't work, neither did the current HEAD. The current HEAD is
>>> missing the backslash after the defined (NS_IMPL_GNUSTEP), for one
>>> thing. But testing against MAC_OS_X_VERSION_10_10 doesn't work on older
>>> OSes, it needs to be the hardcoded value '101000' (since the define
>>> didn't exist back then). To sum up, this is the patch that worked for me:
>>
>> Please try the attached patch. It should be a neater solution
>> (checking whether the compiler supports instancetype directly).
>>
>> If MAC_OS_X_VERSION_10_10 doesn’t exist we can define it ourselves, we
>> already do this with the other versions that have specific
>> requirements (top of nsterm.h). I evidently forgot to check whether we
>> need to define it before committing the change.
>>
>> Not that it matters now, this patch should work without it.
>
> I tried the patch out, still has problems (this output is from Mac OS 10.9):
Crap. Ignore that last failure report, I accidentally tested a version
with the patch unapplied. When I actually test correctly, the patch
works. I tested on 10.6 and 10.8 (and I assume that the ones in between
also work :-)). Thanks!
-David
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-05-26 19:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-24 16:22 bug#27059: Can't compile master branch on Mac OS X David Caldwell
2017-05-24 20:20 ` Philipp Stephani
2017-05-25 16:25 ` David Caldwell
2017-05-25 19:02 ` Alan Third
2017-05-26 17:23 ` David Caldwell
2017-05-26 18:47 ` Philipp Stephani
2017-05-26 19:30 ` David Caldwell [this message]
2017-05-26 23:58 ` Alan Third
2017-05-29 6:55 ` David Caldwell
2017-05-29 8:24 ` Alan Third
2017-05-29 8:56 ` David Caldwell
2017-05-29 16:05 ` Alan Third
2017-05-30 18:36 ` David Caldwell
2017-05-30 19:01 ` Alan Third
2017-05-31 23:39 ` David Caldwell
2017-05-25 21:12 ` OKAZAKI Tetsurou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a99edd50-3cb2-88eb-fba5-7f4b6685ea31@porkrind.org \
--to=david@porkrind.org \
--cc=27059@debbugs.gnu.org \
--cc=alan@idiocy.org \
--cc=p.stephani2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).