unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 15292@debbugs.gnu.org
Subject: bug#15292: 24.3.50; Isearch: handle commands properly when called at top level
Date: Fri, 6 Sep 2013 16:19:44 -0700 (PDT)	[thread overview]
Message-ID: <a971255f-f440-43d0-8f30-0ad5c448612e@default> (raw)
In-Reply-To: <jwvli394l60.fsf-monnier+emacs@gnu.org>

> > Some such commands, such as `isearch-help-for-help' should be callable
> > outside of Isearch.
> 
> You mean via something like M-x isearch-help-for-help, right?

Yes.

> (I doubt anyone would bind such a command to a key).

They might.  Or they might read the command name in the minibuffer from
some other command that then invokes it.  Or whatever.

After all, that command does give you a general entry to help of various
kinds on Isearch.  And for the most part it does work OK at top level.
There is just a minor hiccup because it calls `isearch-update'.  It
wouldn't cost much to make it useful pretty much anywhere, just as
`isearch-describe-bindings' already is.

> > Others, such as `isearch-repeat-forward', should not.  For those that
> > should not, an error should be raised, saying that the command is for
> > use only in Isearch.
> 
> Actually, it's not important to signal an error saying "don't use it
> outside Isearch mode", *unless* running that command outside Isearch
> mode results in nasty behavior.

I don't disagree that it's not important in such cases.  Just thought
it might be better.  It's not important to me, in any case.  Nothing
in this bug report is.

Particularly the toggle commands, I think, might be commands that
someone might mistakenly think could be used at top level.  It's not
obvious, when you do something like `apropos-command' etc., whether such
a command like `isearch-toggle-lax-whitespace' is relevant only in some
particular context.  The doc is mute about it; you find out what it does
in the wrong context only by trying it there.





      reply	other threads:[~2013-09-06 23:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-06 18:56 bug#15292: 24.3.50; Isearch: handle commands properly when called at top level Drew Adams
2013-09-06 20:49 ` Juri Linkov
2013-09-06 21:04   ` Drew Adams
2013-09-06 22:55 ` Stefan Monnier
2013-09-06 23:19   ` Drew Adams [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a971255f-f440-43d0-8f30-0ad5c448612e@default \
    --to=drew.adams@oracle.com \
    --cc=15292@debbugs.gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).