unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Paul Eggert <eggert@cs.ucla.edu>
To: Noam Postavsky <npostavs@gmail.com>
Cc: 31996@debbugs.gnu.org
Subject: bug#31996: 27.0.50; [w32] while dumping: assertion failed: specpdl_ptr->kind == SPECPDL_UNWIND_PTR && specpdl_ptr->unwind_ptr.func == xfree
Date: Fri, 29 Jun 2018 11:18:31 -0700	[thread overview]
Message-ID: <a94f9be9-669c-6972-7458-cfdf56222c0b@cs.ucla.edu> (raw)
In-Reply-To: <878t6xojus.fsf@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 219 bytes --]

On 06/29/2018 05:30 AM, Noam Postavsky wrote:
> You removed the bytecode stack in [1: a815e5f195], right?

Yes I did. Thanks for catching that. I fixed the comment by installing 
the attached into the emacs-26 branch.


[-- Attachment #2: 0001-src-lisp.h-Omit-obsolete-comment-re-bytecode-stack.patch --]
[-- Type: text/x-patch, Size: 2119 bytes --]

From e6be48a508c4d25c8f8973dc23708c924b403927 Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Fri, 29 Jun 2018 11:14:36 -0700
Subject: [PATCH] * src/lisp.h: Omit obsolete comment re bytecode stack.

---
 src/lisp.h | 18 ++++++++----------
 1 file changed, 8 insertions(+), 10 deletions(-)

diff --git a/src/lisp.h b/src/lisp.h
index 56ad8b814b..b2449cb87d 100644
--- a/src/lisp.h
+++ b/src/lisp.h
@@ -3044,15 +3044,13 @@ extern void defvar_kboard (struct Lisp_Kboard_Objfwd *, const char *, int);
   } while (false)
 
 \f
-/* Elisp uses several stacks:
-   - the C stack.
-   - the bytecode stack: used internally by the bytecode interpreter.
-     Allocated from the C stack.
-   - The specpdl stack: keeps track of active unwind-protect and
-     dynamic-let-bindings.  Allocated from the `specpdl' array, a manually
-     managed stack.
-   - The handler stack: keeps track of active catch tags and condition-case
-     handlers.  Allocated in a manually managed stack implemented by a
+/* Elisp uses multiple stacks:
+   - The C stack.
+   - The specpdl stack keeps track of backtraces, unwind-protects and
+     dynamic let-bindings.  It is allocated from the 'specpdl' array,
+     a manually managed stack.
+   - The handler stack keeps track of active catch tags and condition-case
+     handlers.  It is allocated in a manually managed stack implemented by a
      doubly-linked list allocated via xmalloc and never freed.  */
 
 /* Structure for recording Lisp call stack for backtrace purposes.  */
@@ -3131,7 +3129,7 @@ SPECPDL_INDEX (void)
    control structures.  A struct handler contains all the information needed to
    restore the state of the interpreter after a non-local jump.
 
-   handler structures are chained together in a doubly linked list; the `next'
+   Handler structures are chained together in a doubly linked list; the `next'
    member points to the next outer catchtag and the `nextfree' member points in
    the other direction to the next inner element (which is typically the next
    free element since we mostly use it on the deepest handler).
-- 
2.17.1


      reply	other threads:[~2018-06-29 18:18 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-28 19:10 bug#31996: 27.0.50; [w32] while dumping: assertion failed: specpdl_ptr->kind == SPECPDL_UNWIND_PTR && specpdl_ptr->unwind_ptr.func == xfree Noam Postavsky
2018-06-28 19:18 ` Eli Zaretskii
2018-06-28 19:20   ` Noam Postavsky
2018-06-28 20:29     ` Andy Moreton
2018-06-28 20:55 ` Paul Eggert
2018-06-28 21:05   ` Noam Postavsky
2018-06-28 22:57     ` Paul Eggert
2018-06-29  6:13       ` Eli Zaretskii
2018-06-29  7:30         ` Paul Eggert
2018-06-29  8:52           ` Eli Zaretskii
2018-06-29 12:30       ` Noam Postavsky
2018-06-29 18:18         ` Paul Eggert [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a94f9be9-669c-6972-7458-cfdf56222c0b@cs.ucla.edu \
    --to=eggert@cs.ucla.edu \
    --cc=31996@debbugs.gnu.org \
    --cc=npostavs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).