From: Dmitry Gutov <dmitry@gutov.dev>
To: Randy Taylor <dev@rjt.dev>, Noah Peart <noah.v.peart@gmail.com>
Cc: 71209@debbugs.gnu.org
Subject: bug#71209: [PATCH] Add font-locking for variables in go-ts-mode range clauses
Date: Sat, 1 Jun 2024 04:56:35 +0300 [thread overview]
Message-ID: <a8c3a42a-16fb-4380-9754-4dbebd97415c@gutov.dev> (raw)
In-Reply-To: <AdChXDjyAulWCxyswxNe-7IMxwPnhNsGnE-QxJ3BN3-HqbU3GhOFti8yQLH_D-euvftZoKEHO6Bvwb1gXojFkT4JhTstpo8Ad-Dqp7nhebE=@rjt.dev>
On 01/06/2024 04:09, Randy Taylor wrote:
> On Thursday, May 30th, 2024 at 09:25, Noah Peart <noah.v.peart@gmail.com> wrote:
>>> it seems we already highlight this when at treesit-font-lock-level 4?
>> They get highlighted with `font-lock-variable-use-face` at level 4, but shouldn't
>> they be getting `font-lock-variable-name-face` in the 'definition feature?
>>
>
> Indeed, thanks. Could someone please install the patch? Thanks in advance.
Now pushed to master. Thanks Noah!
> Seems like c++-ts-mode will need to get updated too, as with:
> for (const auto& i : things) {}
> i gets font-lock-variable-use-face. I wonder if any other ts modes
> have similar issues.
I would probably rather call those "missing features" rather than
issues. I've added such highlightings to some of the constructs for
several treesit modes last year, but more can be missing, so
contributions welcome.
prev parent reply other threads:[~2024-06-01 1:56 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-26 12:41 bug#71209: [PATCH] Add font-locking for variables in go-ts-mode range clauses Noah Peart
2024-05-28 2:46 ` Randy Taylor
2024-05-30 13:25 ` Noah Peart
2024-05-30 23:23 ` Dmitry Gutov
2024-06-01 1:09 ` Randy Taylor
2024-06-01 1:42 ` Noah Peart
2024-06-01 1:50 ` Noah Peart
2024-06-01 14:13 ` Dmitry Gutov
2024-06-01 1:51 ` Dmitry Gutov
2024-06-01 1:56 ` Noah Peart
2024-06-01 1:59 ` Dmitry Gutov
2024-06-01 2:04 ` Noah Peart
2024-06-01 14:13 ` Dmitry Gutov
2024-06-15 7:56 ` Eli Zaretskii
2024-06-27 7:38 ` Eli Zaretskii
2024-06-27 9:29 ` Noah Peart
2024-07-06 7:46 ` Eli Zaretskii
2024-07-20 9:42 ` Eli Zaretskii
2024-08-04 7:52 ` Eli Zaretskii
2024-06-01 1:56 ` Dmitry Gutov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8c3a42a-16fb-4380-9754-4dbebd97415c@gutov.dev \
--to=dmitry@gutov.dev \
--cc=71209@debbugs.gnu.org \
--cc=dev@rjt.dev \
--cc=noah.v.peart@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).