From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: =?UTF-8?Q?Micha=C5=82?= Kondraciuk Newsgroups: gmane.emacs.bugs Subject: bug#30139: 25.3; Passing callback to align-region raises an error when using `justify` rule Date: Fri, 19 Jan 2018 18:04:08 +0100 Message-ID: References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------3ED6F3CFA8DC977F294388C0" X-Trace: blaine.gmane.org 1516382501 1344 195.159.176.226 (19 Jan 2018 17:21:41 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 19 Jan 2018 17:21:41 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 To: 30139@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jan 19 18:21:37 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ecaM1-0007qr-Ds for geb-bug-gnu-emacs@m.gmane.org; Fri, 19 Jan 2018 18:21:25 +0100 Original-Received: from localhost ([::1]:33243 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ecaNz-0006Bj-BN for geb-bug-gnu-emacs@m.gmane.org; Fri, 19 Jan 2018 12:23:27 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57486) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eca6F-0007nT-N5 for bug-gnu-emacs@gnu.org; Fri, 19 Jan 2018 12:05:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eca6A-0000of-NW for bug-gnu-emacs@gnu.org; Fri, 19 Jan 2018 12:05:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:55516) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eca6A-0000oC-Ii for bug-gnu-emacs@gnu.org; Fri, 19 Jan 2018 12:05:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eca6A-000786-0C for bug-gnu-emacs@gnu.org; Fri, 19 Jan 2018 12:05:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Micha=C5=82?= Kondraciuk Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 19 Jan 2018 17:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30139 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30139-submit@debbugs.gnu.org id=B30139.151638146627362 (code B ref 30139); Fri, 19 Jan 2018 17:05:01 +0000 Original-Received: (at 30139) by debbugs.gnu.org; 19 Jan 2018 17:04:26 +0000 Original-Received: from localhost ([127.0.0.1]:35180 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eca5a-00077F-0w for submit@debbugs.gnu.org; Fri, 19 Jan 2018 12:04:26 -0500 Original-Received: from sender-pp-092.zoho.com ([135.84.80.237]:25403) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eca5X-000774-Cb for 30139@debbugs.gnu.org; Fri, 19 Jan 2018 12:04:25 -0500 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=zapps768; d=zoho.com; h=subject:from:to:references:message-id:date:user-agent:mime-version:in-reply-to:content-type; b=LyeCUb8QQYARWatT2ELbCPV2xS06do+y9FmsIORNMNzi0XFAOTNuw/uMcPJZWTkTI8tqsZrCgDad //sxCZPAZfBzF4kT96RMqvKgyZ2D85/cAAKAXsx1fPSGX5oLFd+W Original-Received: from [192.168.43.88] (user-46-112-8-1.play-internet.pl [46.112.8.1]) by mx.zohomail.com with SMTPS id 1516381452330890.5268619031701; Fri, 19 Jan 2018 09:04:12 -0800 (PST) In-Reply-To: Content-Language: en-US X-Zoho-Virus-Status: 1 X-ZohoMailClient: External X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:142297 Archived-At: This is a multi-part message in MIME format. --------------3ED6F3CFA8DC977F294388C0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit I looked at source of `align-areas` in lisp/align.el and it looks like the changes made to `areas` on line 1196 are ignored in funcall on line 1218. Attached patch contains my proposed change. --------------3ED6F3CFA8DC977F294388C0 Content-Type: text/x-patch; name="align.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="align.patch" diff --git a/lisp/align.el b/lisp/align.el index 941fa3a..10f3fcb 100644 --- a/lisp/align.el +++ b/lisp/align.el @@ -1215,10 +1215,16 @@ align-areas (gocol col) cur) (when area (if func - (funcall func - (marker-position (car area)) - (marker-position (cdr area)) - change) + (if (and justify + (consp (cdr area))) + (funcall func + (marker-position (car area)) + (marker-position (cadr area)) + change) + (funcall func + (marker-position (car area)) + (marker-position (cdr area)) + change)) (if (not (and justify (consp (cdr area)))) (goto-char (cdr area)) --------------3ED6F3CFA8DC977F294388C0--