From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#31118: 27.0.50; Can't load/compile websocket in 32bit master Date: Tue, 17 Apr 2018 16:53:32 -0700 Organization: UCLA Computer Science Department Message-ID: References: <6deb652e-7bd1-f003-ac84-0f4c6a18de99@cs.ucla.edu> <80fbbf82-c20f-6a01-b257-45caa4a87fdf@cs.ucla.edu> <100a3631-afa6-ef69-5fa1-6ae95df20c35@cs.ucla.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------92A635E9FBC29890A5BCABD4" X-Trace: blaine.gmane.org 1524009128 15850 195.159.176.226 (17 Apr 2018 23:52:08 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 17 Apr 2018 23:52:08 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 Cc: 31118@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Apr 18 01:52:04 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f8aOJ-000415-MW for geb-bug-gnu-emacs@m.gmane.org; Wed, 18 Apr 2018 01:52:03 +0200 Original-Received: from localhost ([::1]:43248 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f8aQO-0005iX-RQ for geb-bug-gnu-emacs@m.gmane.org; Tue, 17 Apr 2018 19:54:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38705) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f8aQI-0005iH-62 for bug-gnu-emacs@gnu.org; Tue, 17 Apr 2018 19:54:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f8aQF-0003NB-5J for bug-gnu-emacs@gnu.org; Tue, 17 Apr 2018 19:54:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50333) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f8aQE-0003Mr-Tm for bug-gnu-emacs@gnu.org; Tue, 17 Apr 2018 19:54:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1f8aQE-0006ev-HX for bug-gnu-emacs@gnu.org; Tue, 17 Apr 2018 19:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 17 Apr 2018 23:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31118 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31118-submit@debbugs.gnu.org id=B31118.152400922125572 (code B ref 31118); Tue, 17 Apr 2018 23:54:02 +0000 Original-Received: (at 31118) by debbugs.gnu.org; 17 Apr 2018 23:53:41 +0000 Original-Received: from localhost ([127.0.0.1]:58229 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f8aPt-0006eN-Jl for submit@debbugs.gnu.org; Tue, 17 Apr 2018 19:53:41 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:38998) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f8aPs-0006eA-0Q for 31118@debbugs.gnu.org; Tue, 17 Apr 2018 19:53:40 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 9F5EA161611; Tue, 17 Apr 2018 16:53:33 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id s7RNLdsIrqYc; Tue, 17 Apr 2018 16:53:33 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id E767416161F; Tue, 17 Apr 2018 16:53:32 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Q8yUmZ6vhpK9; Tue, 17 Apr 2018 16:53:32 -0700 (PDT) Original-Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id CEB5B161611; Tue, 17 Apr 2018 16:53:32 -0700 (PDT) In-Reply-To: Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:145538 Archived-At: This is a multi-part message in MIME format. --------------92A635E9FBC29890A5BCABD4 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 04/17/2018 05:18 AM, Stefan Monnier wrote: > If we want to signal an error by default, then I think it's important > for this error to give clear steps to set read-integer-overflow-as-float Something like the attached patch, perhaps? --------------92A635E9FBC29890A5BCABD4 Content-Type: text/x-patch; name="0001-Tell-user-about-read-integer-overflow-as-float.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="0001-Tell-user-about-read-integer-overflow-as-float.patch" >From eb2fa1a00c5c85aced40900b59183dc03d822958 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Tue, 17 Apr 2018 16:52:04 -0700 Subject: [PATCH] Tell user about read-integer-overflow-as-float * src/lread.c (string_to_number): Suggest read-integer-overflow-as-float in signal message. Suggested by Stefan Monnier (Bug#31118#58). --- src/lread.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/lread.c b/src/lread.c index 6eda740540..16e34aff0c 100644 --- a/src/lread.c +++ b/src/lread.c @@ -3797,7 +3797,12 @@ string_to_number (char const *string, int base, int flags) value = n; if (! (state & DOT_CHAR) && ! (flags & S2N_OVERFLOW_TO_FLOAT)) - xsignal1 (Qoverflow_error, build_string (string)); + { + AUTO_STRING (fmt, ("%s is out of fixnum range; " + "maybe set `read-integer-overflow-as-float'?")); + xsignal1 (Qoverflow_error, + CALLN (Fformat_message, fmt, build_string (string))); + } } /* Either the number uses float syntax, or it does not fit into a fixnum. -- 2.14.3 --------------92A635E9FBC29890A5BCABD4--