From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#71727: Deleting TAGS buffer will cause `etags-regen--update-file` doesn't work Date: Tue, 9 Jul 2024 05:50:12 +0300 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33408"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: 71727@debbugs.gnu.org To: Siyuan Chen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jul 09 04:51:18 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sR0wn-0008XU-54 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Jul 2024 04:51:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sR0wV-0007NK-B7; Mon, 08 Jul 2024 22:50:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sR0wS-0007EO-VP for bug-gnu-emacs@gnu.org; Mon, 08 Jul 2024 22:50:57 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sR0wS-0004u9-Ml for bug-gnu-emacs@gnu.org; Mon, 08 Jul 2024 22:50:56 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sR0wX-0003CA-Rs for bug-gnu-emacs@gnu.org; Mon, 08 Jul 2024 22:51:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Jul 2024 02:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71727 X-GNU-PR-Package: emacs Original-Received: via spool by 71727-submit@debbugs.gnu.org id=B71727.172049342812234 (code B ref 71727); Tue, 09 Jul 2024 02:51:01 +0000 Original-Received: (at 71727) by debbugs.gnu.org; 9 Jul 2024 02:50:28 +0000 Original-Received: from localhost ([127.0.0.1]:51813 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sR0vz-0003BG-Pk for submit@debbugs.gnu.org; Mon, 08 Jul 2024 22:50:28 -0400 Original-Received: from fhigh6-smtp.messagingengine.com ([103.168.172.157]:41707) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sR0vy-0003B2-BO for 71727@debbugs.gnu.org; Mon, 08 Jul 2024 22:50:27 -0400 Original-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailfhigh.nyi.internal (Postfix) with ESMTP id A2C6D1141BE7; Mon, 8 Jul 2024 22:50:15 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 08 Jul 2024 22:50:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1720493415; x=1720579815; bh=VfwPV/ySP/uBFufgDFi4snwFlr28XkO9rtf4dg6hEWA=; b= pSj/CxxVVzG3uTMsJC5Std1dhgZAWrUeTXnYcQSexEpx9ktsNw47j56nMbFQx+v6 TTRu5b7Muhw7+3JW3k6gMnamFGph/pqoKVSBvWkB3HbCyhD4qF9etI3XrGoDi/9x YjOqoxsg+WCxWvpMnVCqHw+q7y/Mmhx+9Oa8LIsvOQKQTJxe2EfjAPcGDuSZr08K xzoITMwrSiMIdpEXexIA2VfGpcfUanlRjI9tG46cO4MGjqM1SQB9lBUPRluLI/hP /iBElID2hqs9QiQgMnxiv2DFYNtXc6bbuJ7uqY79b21Z/G5jlC6dhJ4of3Cf+XHQ Z27x7YTQ2Ih/x1m+jIh8lQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1720493415; x= 1720579815; bh=VfwPV/ySP/uBFufgDFi4snwFlr28XkO9rtf4dg6hEWA=; b=M 6lXK1U2GsJaE4sEWvG37HOekR/FivozYRns2juYlH/0T3H9jlVDZ7K1zwIR3jgfg bFRJBcsDfrpDse3uYmb2loRqoJ6XoA2wwMb4eiF0xuK8CWz29xcIT8WbsQHRed3w YAAPalGdRrm5/gYeCXrMjIYGk4kkdpR2cFrbJO5aIoWcjIynyz4jGLYKudC2iPt9 2wjolvxVkCQYNIox6LwkSDXXdI5OXVkht4BpLqRxv92WkhTkSWp72NsnI3LQaohH 37y0cv127J87yDwtdVZ/z1TAMXoC+oPLMoFWJUqUgBoFK7AOKlm5TUuVkw1bP42I E6hqApZn+qazFqsQ34ULw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdekgdeivdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepkfffgggfuffvvehfhfgjtgfgsehtje ertddtvdejnecuhfhrohhmpeffmhhithhrhicuifhuthhovhcuoegumhhithhrhiesghhu thhovhdruggvvheqnecuggftrfgrthhtvghrnhepteduleejgeehtefgheegjeekueehvd evieekueeftddvtdevfefhvdevgedujeehnecuvehluhhsthgvrhfuihiivgeptdenucfr rghrrghmpehmrghilhhfrhhomhepughmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 8 Jul 2024 22:50:13 -0400 (EDT) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288613 Archived-At: Hi again! On 29/06/2024 14:49, Siyuan Chen wrote: > > Is there are particular reason you killed the TAGS buffer? > > No. I found this bug is just because I tried to view the TAGS content > while editing a .c file and then closed it (I am using tab-line-mode > with tab-line-close-tab-function set to kill-buffer). Since then, I have > stopped closing the TAGS buffer. Thanks for the clarification. > Another option is to temporarily add documentation advising users not to > close the TAGS buffer, because closing it accidentally can result in the > odd behavior. I think actually a simpler approach can suffice: using kill-buffer-hook in the TAGS buffer. Like this: diff --git a/lisp/progmodes/etags-regen.el b/lisp/progmodes/etags-regen.el index dc778b14061..21ea9bfb8b3 100644 --- a/lisp/progmodes/etags-regen.el +++ b/lisp/progmodes/etags-regen.el @@ -294,7 +294,9 @@ etags-regen--visit-table (add-hook 'before-save-hook #'etags-regen--mark-as-new) (setq etags-regen--tags-file tags-file etags-regen--tags-root root) - (visit-tags-table etags-regen--tags-file)) + (visit-tags-table etags-regen--tags-file) + (with-current-buffer (get-file-buffer tags-file) + (add-hook 'kill-buffer-hook #'etags-regen--tags-cleanup nil t))) (defun etags-regen--ctags-p () (string-search "Ctags" @@ -390,7 +392,8 @@ etags-regen--mark-as-new (defun etags-regen--tags-cleanup () (when etags-regen--tags-file - (let ((buffer (get-file-buffer etags-regen--tags-file))) + (let ((buffer (get-file-buffer etags-regen--tags-file)) + kill-buffer-hook) (and buffer (kill-buffer buffer))) (tags-reset-tags-tables)