From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.bugs Subject: bug#59956: 29.0.60: Failure when completing arguments in Eshell after variable interpolation Date: Mon, 19 Dec 2022 22:22:38 +0000 Message-ID: References: <83iliiv0yv.fsf@gnu.org> <765547c0-b2a5-b054-a29d-b27002b7442c@gmail.com> <07bcf6a532d0428b9f53@heytings.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="SvEMGz1yjF" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6777"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Jim Porter , Eli Zaretskii , arstoffel@gmail.com, 59956@debbugs.gnu.org, John Wiegley To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 19 23:23:16 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p7OXU-0001ae-3A for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 19 Dec 2022 23:23:16 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p7OXI-0006bC-FK; Mon, 19 Dec 2022 17:23:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7OXG-0006Yn-Lb for bug-gnu-emacs@gnu.org; Mon, 19 Dec 2022 17:23:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p7OXG-0006D4-E4 for bug-gnu-emacs@gnu.org; Mon, 19 Dec 2022 17:23:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p7OXG-0008FY-1i for bug-gnu-emacs@gnu.org; Mon, 19 Dec 2022 17:23:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Dec 2022 22:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59956 X-GNU-PR-Package: emacs Original-Received: via spool by 59956-submit@debbugs.gnu.org id=B59956.167148856331690 (code B ref 59956); Mon, 19 Dec 2022 22:23:02 +0000 Original-Received: (at 59956) by debbugs.gnu.org; 19 Dec 2022 22:22:43 +0000 Original-Received: from localhost ([127.0.0.1]:40690 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7OWw-0008F4-Pe for submit@debbugs.gnu.org; Mon, 19 Dec 2022 17:22:43 -0500 Original-Received: from heytings.org ([95.142.160.155]:37446) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7OWu-0008Ey-JL for 59956@debbugs.gnu.org; Mon, 19 Dec 2022 17:22:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1671488559; bh=f2IlWhPZQMJhr/0i1d3MUO171VHbYcM29Hs8b6qOxfA=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=vlxUsT3eVasARpxx7YOmzOBIHYkDnaS5TgzJ1rPOEWiiKpHAZxR2flXE5mQneKQqg 4wO9dvTCFS3pyeVk1GNB8916iwtDJ/CSvHrK6yHwAnmW9D5NpIfUlHs11ZvI0QuFEH evNGwK8mWPvJHEioe73247d2+TjxbRanFgKcFoP9rvvq2qvYjXeMd34JEDB4f4SeYr dLW1pChUg3DbxoGoP2heGc5ZG0qCqkyxnrcDRJ5p1/uiT4FiowpDFwAiNMxdZyliQ6 6w85+76FR7dl6LviLzHSu/5yc6E40cFdybVuS5KglLDNTBIwvip3UvBdeVMf3X3l01 8SRK79VUjHVWQ== In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:251468 Archived-At: --SvEMGz1yjF Content-Type: text/plain; format=flowed; charset=us-ascii > > Sounds good to me, > Thanks. Augusto and Jim, can you please try the attached patch and tell us if it fixes the issue without introducing regressions? --SvEMGz1yjF Content-Type: text/x-diff; name=Handle-non-string-values-in-pcomplete.patch Content-Transfer-Encoding: base64 Content-ID: Content-Disposition: attachment; filename=Handle-non-string-values-in-pcomplete.patch RnJvbSA1YmVlOWQ4YmVjNDJkZGYzOGJiN2U4ZDhmMmExYjM2YWRiOTZhNTA2 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQ0KRnJvbTogR3JlZ29yeSBIZXl0 aW5ncyA8Z3JlZ29yeUBoZXl0aW5ncy5vcmc+DQpEYXRlOiBNb24sIDE5IERl YyAyMDIyIDIyOjE4OjIyICswMDAwDQpTdWJqZWN0OiBbUEFUQ0hdIEhhbmRs ZSBub24tc3RyaW5nIHZhbHVlcyBpbiBwY29tcGxldGUNCg0KKiBsaXNwL3Bj b21wbGV0ZS5lbCAocGNvbXBsZXRlLWFyZyk6IFdoZW4NCnBjb21wbGV0ZS1w YXJzZS1hcmd1bWVudHMtZnVuY3Rpb24gcmV0dXJucyBhIG5vbi1zdHJpbmcg dmFsdWUsDQpyZXR1cm4gdGhlIHN0cmluZyB0aGUgdXNlciB0eXBlZCBpbiwg YW5kIGF0dGFjaCB0aGUgdmFsdWUgYXMgYQ0KdGV4dCBwcm9wZXJ0eSB0byB0 aGF0IHN0cmluZy4gIEZpeGVzIGJ1ZyM1OTk1NiBhbmQgYnVnIzYwMDIxLg0K LS0tDQogbGlzcC9wY29tcGxldGUuZWwgfCAyNyArKysrKysrKysrKysrKysr KysrKy0tLS0tLS0NCiAxIGZpbGUgY2hhbmdlZCwgMjAgaW5zZXJ0aW9ucygr KSwgNyBkZWxldGlvbnMoLSkNCg0KZGlmZiAtLWdpdCBhL2xpc3AvcGNvbXBs ZXRlLmVsIGIvbGlzcC9wY29tcGxldGUuZWwNCmluZGV4IDRlM2E4OGJiZGE4 Li5iMWZiZDg4YTM3NyAxMDA2NDQNCi0tLSBhL2xpc3AvcGNvbXBsZXRlLmVs DQorKysgYi9saXNwL3Bjb21wbGV0ZS5lbA0KQEAgLTY0NSwxMyArNjQ1LDI2 IEBAIHBjb21wbGV0ZS1hcmcNCiANCiBUaGUgT0ZGU0VUIGFyZ3VtZW50IGlz IGFkZGVkIHRvL3Rha2VuIGF3YXkgZnJvbSB0aGUgaW5kZXggdGhhdCB3aWxs IGJlDQogdXNlZC4gIFRoaXMgaXMgcmVhbGx5IG9ubHkgdXNlZnVsIHdpdGgg YGZpcnN0JyBhbmQgYGxhc3QnLCBmb3INCi1hY2Nlc3NpbmcgYWJzb2x1dGUg YXJndW1lbnQgcG9zaXRpb25zLiINCi0gIChudGggKCsgKHBjYXNlIGluZGV4 DQotCSAgICgnZmlyc3QgMCkNCi0JICAgKCdsYXN0ICBwY29tcGxldGUtbGFz dCkNCi0JICAgKF8gICAgICAoLSBwY29tcGxldGUtaW5kZXggKG9yIGluZGV4 IDApKSkpDQotCSAgKG9yIG9mZnNldCAwKSkNCi0gICAgICAgcGNvbXBsZXRl LWFyZ3MpKQ0KK2FjY2Vzc2luZyBhYnNvbHV0ZSBhcmd1bWVudCBwb3NpdGlv bnMuDQorDQorV2hlbiB0aGUgYXJndW1lbnQgaGFzIGJlZW4gdHJhbnNmb3Jt ZWQgaW50byBzb21ldGhpbmcgdGhhdCBpcyBub3QNCithIHN0cmluZyBieSBg cGNvbXBsZXRlLXBhcnNlLWFyZ3VtZW50cy1mdW5jdGlvbicsIHRoZSB0ZXh0 DQorcmVwcmVzZW50YXRpb24gb2YgdGhlIGFyZ3VtZW50LCBuYW1lbHkgd2hh dCB0aGUgdXNlciBhY3R1YWxseQ0KK3R5cGVkIGluLCBpcyByZXR1cm5lZCwg YW5kIHRoZSB2YWx1ZSBvZiB0aGUgYXJndW1lbnQgaXMgc3RvcmVkIGluDQor dGhlIHBjb21wbGV0ZS1hcmctdmFsdWUgdGV4dCBwcm9wZXJ0eSBvZiB0aGF0 IHN0cmluZy4iDQorICAobGV0ICgoYXJnDQorICAgICAgICAgKG50aCAoKyAo cGNhc2UgaW5kZXgNCisJICAgICAgICAgICAoJ2ZpcnN0IDApDQorCSAgICAg ICAgICAgKCdsYXN0ICBwY29tcGxldGUtbGFzdCkNCisJICAgICAgICAgICAo XyAgICAgICgtIHBjb21wbGV0ZS1pbmRleCAob3IgaW5kZXggMCkpKSkNCisJ ICAgICAgICAgKG9yIG9mZnNldCAwKSkNCisgICAgICAgICAgICAgIHBjb21w bGV0ZS1hcmdzKSkpDQorICAgIChpZiAoc3RyaW5ncCBhcmcpDQorICAgICAg ICBhcmcNCisgICAgICAocHJvcGVydGl6ZQ0KKyAgICAgICAoYnVmZmVyLXN1 YnN0cmluZyAocGNvbXBsZXRlLWJlZ2luIGluZGV4IG9mZnNldCkNCisgICAg ICAgICAgICAgICAgICAgICAgICAgKHBjb21wbGV0ZS1iZWdpbiAoMS0gKG9y IGluZGV4IDApKSBvZmZzZXQpKQ0KKyAgICAgICAncGNvbXBsZXRlLWFyZy12 YWx1ZSBhcmcpKSkpDQogDQogKGRlZnVuIHBjb21wbGV0ZS1iZWdpbiAoJm9w dGlvbmFsIGluZGV4IG9mZnNldCkNCiAgICJSZXR1cm4gdGhlIGJlZ2lubmlu ZyBwb3NpdGlvbiBvZiB0aGUgSU5ERVh0aCBhcmd1bWVudC4NCi0tIA0KMi4z NS4xDQoNCg== --SvEMGz1yjF--