From: Dmitry Gutov <dgutov@yandex.ru>
To: Juanma Barranquero <lekktu@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>, 59575@debbugs.gnu.org
Subject: bug#59575: 29.0.50; add-log-current-defun-header-regexp matches Windows drive letter
Date: Sun, 27 Nov 2022 15:04:24 +0200 [thread overview]
Message-ID: <a8388ecd-0fcc-5b14-25c2-c471f286eae5@yandex.ru> (raw)
In-Reply-To: <CAAeL0SQx6MYfbH=F4T91yohXmXx=M7Sz+wxPf1b5O6WkUc9dDQ@mail.gmail.com>
On 27/11/22 13:22, Juanma Barranquero wrote:
> On Sun, Nov 27, 2022 at 12:11 PM Juanma Barranquero <lekktu@gmail.com
> <mailto:lekktu@gmail.com>> wrote:
>
> That should be changed to
>
> (cl-ecase xref-file-name-display
> (abs group)
> (nondirectory
> - (if (string-match-p "\\`~?/" group)
> + (if (string-match-p "\\`\\(~\\|[A-Za-z]:\\)?/" group)
> (file-name-nondirectory group)
> group))
> (project-relative
>
> or something similar.
>
>
> Silly me, that should just use `file-name-absolute-p'.
>
> OK to fix this, regardless of what's decided for the original bug?
Yes, please. The original idea was to avoid costly operations (in case
the list of matches is long), but looks like file-name-absolute-p
doesn't hit the disk.
next prev parent reply other threads:[~2022-11-27 13:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-25 15:53 bug#59575: 29.0.50; add-log-current-defun-header-regexp matches Windows drive letter Juanma Barranquero
2022-11-26 13:03 ` Eli Zaretskii
2022-11-26 13:17 ` Juanma Barranquero
2022-11-27 1:54 ` Dmitry Gutov
2022-11-27 6:49 ` Eli Zaretskii
2022-11-27 12:33 ` Dmitry Gutov
2022-11-27 12:40 ` Juanma Barranquero
2022-11-27 8:29 ` Juanma Barranquero
2022-11-27 11:11 ` Juanma Barranquero
2022-11-27 11:22 ` Juanma Barranquero
2022-11-27 13:04 ` Dmitry Gutov [this message]
2022-11-27 13:22 ` Juanma Barranquero
2022-11-27 13:05 ` Dmitry Gutov
2022-11-27 13:18 ` Juanma Barranquero
2022-11-27 13:41 ` Dmitry Gutov
2022-11-27 14:02 ` Juanma Barranquero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8388ecd-0fcc-5b14-25c2-c471f286eae5@yandex.ru \
--to=dgutov@yandex.ru \
--cc=59575@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=lekktu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).