From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#29360: Add full-buffer choice for `isearch-lazy-highlight' Date: Sun, 28 Oct 2018 15:57:21 -0700 (PDT) Message-ID: References: <87o9bfqfc3.fsf@mail.linkov.net> <72ae3efe-0aa6-430e-ba99-2d8bc47d3a34@default> <874ld5g233.fsf_-_@mail.linkov.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1540767370 9782 195.159.176.226 (28 Oct 2018 22:56:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 28 Oct 2018 22:56:10 +0000 (UTC) Cc: 29360@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Oct 28 23:56:06 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gGtyY-0002T5-8j for geb-bug-gnu-emacs@m.gmane.org; Sun, 28 Oct 2018 23:56:06 +0100 Original-Received: from localhost ([::1]:42474 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gGu0e-0007X4-Iy for geb-bug-gnu-emacs@m.gmane.org; Sun, 28 Oct 2018 18:58:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48331) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gGu0T-0007Wj-BV for bug-gnu-emacs@gnu.org; Sun, 28 Oct 2018 18:58:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gGu0Q-0000p6-5h for bug-gnu-emacs@gnu.org; Sun, 28 Oct 2018 18:58:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45180) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gGu0P-0000p2-Vb for bug-gnu-emacs@gnu.org; Sun, 28 Oct 2018 18:58:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gGu0P-00019C-Nb for bug-gnu-emacs@gnu.org; Sun, 28 Oct 2018 18:58:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 28 Oct 2018 22:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29360 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 29360-submit@debbugs.gnu.org id=B29360.15407674534371 (code B ref 29360); Sun, 28 Oct 2018 22:58:01 +0000 Original-Received: (at 29360) by debbugs.gnu.org; 28 Oct 2018 22:57:33 +0000 Original-Received: from localhost ([127.0.0.1]:49438 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gGtzx-00018R-7W for submit@debbugs.gnu.org; Sun, 28 Oct 2018 18:57:33 -0400 Original-Received: from userp2130.oracle.com ([156.151.31.86]:44606) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gGtzu-000186-OL for 29360@debbugs.gnu.org; Sun, 28 Oct 2018 18:57:31 -0400 Original-Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w9SMsHwX017397; Sun, 28 Oct 2018 22:57:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=uoGf6j1OegyHd/IDf3udPVQtFqwCKdJ4scFgoVLrOao=; b=Sqh+YdrrcnVOPu+OVT5p5kd532aJHYzVJQC89ZI9Cx32vfFIXfuhgu/0Q8KmrngiJG0s KvEIlN5NMRLUp7kijqxQK58obRjBIli70f75KNaljIBxqJHgN62evH8Chqsqa/Qt+DGk SC61CNVMUiQKdivrxjiEN6zNf4z3lYSVeHKGXPHZ9xcnc6APORgYrLRsLNUKJNTTBkUF yTleziKFvVYP/9IGyeazZR8UzLoeqQevFn4V7PFoONBX0lF/Cqy2wVo/uXRvtu2u1K6Z Dk9NtGKI9wBPC2YQ8ug/kOzYcw5dJNETQz2MrUvNg7alKGog8kl1Weq5vKzhkJCCoLFw Tw== Original-Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by userp2130.oracle.com with ESMTP id 2ncfetatpq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 28 Oct 2018 22:57:24 +0000 Original-Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id w9SMvNlY027678 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 28 Oct 2018 22:57:23 GMT Original-Received: from abhmp0009.oracle.com (abhmp0009.oracle.com [141.146.116.15]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id w9SMvMeU009397; Sun, 28 Oct 2018 22:57:22 GMT In-Reply-To: <874ld5g233.fsf_-_@mail.linkov.net> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4756.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9060 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=838 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1810280213 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:151761 Archived-At: > >> I guess that since your patch to the bug thread you just renamed > >> isearch-lazy-highlight-buffer to lazy-highlight-buffer and you > >> renamed isearch-lazy-highlight-buffer-p to > >> isearch-lazy-highlight-buffer. >=20 > I renamed isearch-lazy-highlight-buffer to lazy-highlight-buffer > after realizing that the same feature might be needed also in > query-replace, therefore generalized it by removing the prefix > isearch-. Yes, I figured that. > > Hm. Seems like you also removed `isearch-lazy-highlight-match- > function', > > which was present in your patches. Why is that? I know that you > > you used only `isearch-lazy-highlight-match' as the value, but did > > you have something else in mind for it? Can I expect that you will > > add back that variable? >=20 > I strive to keep my changes as minimal as possible to not introduce > unused variables. However, if you can demonstrate a real need > we could add it when necessary. I'm OK with all that you've done. I may leave the variable in my code, probably only out of laziness to remove it. ;-) Thanks for your work on this.