From: Dmitry Gutov <dmitry@gutov.dev>
To: Yuan Fu <casouri@gmail.com>
Cc: 74386@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>,
Theodor Thornhill <theo@thornhill.no>,
marius.kjeldahl@gmail.com
Subject: bug#74386: Tree-sitter javascript indentation
Date: Mon, 2 Dec 2024 00:33:23 +0200 [thread overview]
Message-ID: <a82074c0-f8e7-4bb2-b2a6-20716b586a8f@gutov.dev> (raw)
In-Reply-To: <35B61F44-C551-44DB-A334-A893991BC799@gmail.com>
On 01/12/2024 21:10, Yuan Fu wrote:
> Ah, I see. That’s a good point, and I definitely prefer the indentation result of parent-bol here. The one produced by standalone-parent is just wrong. What we can do is make standalone-parent ignore “.” when checking for “standaloneness”. And perhaps make it configurable so it’s enabled only for modes that this waiver makes sense (C-like languages excluding C and C++).
Maybe not by hardcoding this in inside the 'standalone-parent' matcher,
but writing this in the indentation rules? Different languages might
have differing ASTs for such construct.
Or if you meant to do a text search, a period might start a method call,
but it could also continue a "range" literal in some other language, or
some struct initializer (I think?) in C/C++. Also, some languages allow
(and style guides suggest) to have the previous at the end of the line,
then followed by newline and then the method name.
next prev parent reply other threads:[~2024-12-01 22:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-16 23:26 bug#74386: Tree-sitter javascript indentation Marius Kjeldahl
2024-11-17 19:18 ` Dmitry Gutov
2024-11-17 19:21 ` Marius Kjeldahl
2024-11-17 22:12 ` Dmitry Gutov
2024-11-17 22:21 ` Marius Kjeldahl
2024-11-17 22:41 ` Dmitry Gutov
2024-11-18 8:35 ` Marius Kjeldahl
2024-11-18 15:29 ` Dmitry Gutov
2024-11-30 10:01 ` Eli Zaretskii
2024-12-01 5:23 ` Yuan Fu
2024-12-01 13:11 ` Dmitry Gutov
2024-12-01 19:10 ` Yuan Fu
2024-12-01 22:33 ` Dmitry Gutov [this message]
2024-12-02 2:31 ` Yuan Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a82074c0-f8e7-4bb2-b2a6-20716b586a8f@gutov.dev \
--to=dmitry@gutov.dev \
--cc=74386@debbugs.gnu.org \
--cc=casouri@gmail.com \
--cc=eliz@gnu.org \
--cc=marius.kjeldahl@gmail.com \
--cc=theo@thornhill.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).