From: Gregory Heytings <gregory@heytings.org>
To: 51883@debbugs.gnu.org
Cc: Michael Heerdegen <michael_heerdegen@web.de>
Subject: bug#51883: 29.0.50; Command to get accidentally deleted frames back
Date: Tue, 16 Nov 2021 17:05:07 +0000 [thread overview]
Message-ID: <a8022ede87645d81f38a@heytings.org> (raw)
In-Reply-To: <a8022ede8787801bbaed@heytings.org>
[-- Attachment #1: Type: text/plain, Size: 34 bytes --]
Slightly improved patch attached.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-diff; name=Undelete-deleted-frames.patch, Size: 7469 bytes --]
From fd68d27dde26788820ebdc3ad816cefb6a5c659b Mon Sep 17 00:00:00 2001
From: Gregory Heytings <gregory@heytings.org>
Date: Tue, 16 Nov 2021 17:01:37 +0000
Subject: [PATCH] Undelete deleted frames.
* lisp/frame.el (undelete-frame): New command.
(undeleted-frame--save-deleted-frame): New auxiliary function.
(undelete-frame--deleted-frames): New auxiliary variable.
(make-frame-command): Add a prefix argument, and call the new
command.
* src/frame.c (Fdelete_frame): Update docstring.
* lisp/menu-bar.el (menu-bar-file-menu): Add an entry for the
new command.
* doc/emacs/frames.tex (Creating Frames, Frame Commands): Document
the new command.
* etc/NEWS: Document the new command.
See bug#51883.
---
doc/emacs/frames.texi | 11 +++++---
etc/NEWS | 10 +++++++
lisp/frame.el | 61 +++++++++++++++++++++++++++++++++++++++----
| 4 +++
src/frame.c | 3 +++
5 files changed, 81 insertions(+), 8 deletions(-)
diff --git a/doc/emacs/frames.texi b/doc/emacs/frames.texi
index c14ada2957..f5ede6af5e 100644
--- a/doc/emacs/frames.texi
+++ b/doc/emacs/frames.texi
@@ -452,8 +452,11 @@ Creating Frames
@item C-x 5 2
@kindex C-x 5 2
@findex make-frame-command
-Create a new frame using the default frame parameters
-(@code{make-frame-command}).
+Create a new frame using the default frame parameters, or, with a prefix
+argument, undelete one of the 16 most recently deleted frames
+(@code{make-frame-command}). A prefix argument undeletes the last deleted
+frame, a numerical prefix argument between 0 and 15 undeletes the
+corresponding deleted frame, where 0 is the most recently deleted frame.
@item C-x 5 c
@kindex C-x 5 c
@@ -510,7 +513,9 @@ Frame Commands
@kindex C-x 5 0
@findex delete-frame
Delete the selected frame (@code{delete-frame}). This signals an
-error if there is only one frame.
+error if there is only one frame. The 16 most recently deleted frames
+can be undeleted with the @kbd{C-x 5 2} command, when it is used with
+a prefix argument.
@item C-z
@kindex C-z @r{(X windows)}
diff --git a/etc/NEWS b/etc/NEWS
index 312fc18f4f..ab47f8cf5b 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -130,6 +130,16 @@ For example, a 'display-buffer-alist' entry of
will make the body of the chosen window 40 columns wide. For the
height use 'window-height' in combination with 'body-lines'.
+---
+** Frames
+
++++
+*** With a prefix argument, the key 'C-x 5 2' undeletes deleted frames.
+The 16 most recently deleted frames can be undeleted. A prefix argument
+undeletes the last deleted frame, a numerical prefix argument between 0
+and 15 undeletes the corresponding deleted frame, where 0 is the most
+recently deleted frame.
+
** Better detection of text suspiciously reordered on display.
The function 'bidi-find-overridden-directionality' has been extended
to detect reordering effects produced by embeddings and isolates
diff --git a/lisp/frame.el b/lisp/frame.el
index 2c73737a54..199e9e8005 100644
--- a/lisp/frame.el
+++ b/lisp/frame.el
@@ -775,16 +775,23 @@ close-display-connection
(mapc #'delete-frame frames)
(x-close-connection display))))
-(defun make-frame-command ()
+(defun make-frame-command (&optional arg)
"Make a new frame, on the same terminal as the selected frame.
If the terminal is a text-only terminal, this also selects the
new frame.
+With a prefix argument ARG, undelete the most recently deleted
+frame.
+With a numerical prefix argument ARG between 0 and 15, undelete
+the ARGth deleted frame, where 0 is most recently deleted frame.
+
When called from Lisp, returns the new frame."
- (interactive)
- (if (display-graphic-p)
- (make-frame)
- (select-frame (make-frame))))
+ (interactive "P")
+ (if arg
+ (undelete-frame arg)
+ (if (display-graphic-p)
+ (make-frame)
+ (select-frame (make-frame)))))
(defun clone-frame (&optional frame no-windows)
"Make a new frame with the same parameters and windows as FRAME.
@@ -2484,6 +2491,50 @@ delete-other-frames
(if iconify (iconify-frame this) (delete-frame this)))
(setq this next))))
+(eval-when-compile (require 'frameset))
+
+(defvar undelete-frame--deleted-frames nil
+ "Internal variable used by `undelete-frame--save-deleted-frame'.")
+
+(defun undeleted-frame--save-deleted-frame (frame)
+ "Save the configuration of frames deleted with `delete-frame'.
+Only the 16 most recently deleted frames are saved."
+ (when (frame-live-p frame)
+ (setq undelete-frame--deleted-frames
+ (cons (cons
+ (display-graphic-p)
+ (frameset-save (list frame)))
+ undelete-frame--deleted-frames))
+ (if (> (length undelete-frame--deleted-frames) 16)
+ (setq undelete-frame--deleted-frames
+ (butlast undelete-frame--deleted-frames)))))
+
+(add-hook 'delete-frame-functions #'undeleted-frame--save-deleted-frame)
+
+(defun undelete-frame (&optional arg)
+ "Undelete a frame deleted with `delete-frame'.
+When ARG is nil or a list, the last deleted frame is undeleted.
+When ARG is a number between 0 and 15, the ARGth deleted frame is
+undeleted.
+When called from Lisp, returns the new frame."
+ (interactive "P")
+ (let* ((frames (frame-list))
+ (n (if (listp arg) 0 arg))
+ (frameset (nth n undelete-frame--deleted-frames)))
+ (if (not frameset)
+ (message "No deleted frame saved at position %d" n)
+ (if (not (eq (display-graphic-p) (car frameset)))
+ (message
+ "Cannot undelete %sgraphic display frame on a %sgraphic display"
+ (if (display-graphic-p) "non-" "")
+ (if (display-graphic-p) "" "non-"))
+ (setq undelete-frame--deleted-frames
+ (delq frameset undelete-frame--deleted-frames))
+ (frameset-restore (cdr frameset))
+ (let ((frame (car (seq-difference (frame-list) frames))))
+ (when frame
+ (select-frame-set-input-focus frame)
+ frame))))))
\f
;;; Window dividers.
(defgroup window-divider nil
--git a/lisp/menu-bar.el b/lisp/menu-bar.el
index 1a81f1a3d0..a1e0195bb5 100644
--- a/lisp/menu-bar.el
+++ b/lisp/menu-bar.el
@@ -109,6 +109,10 @@ menu-bar-file-menu
(bindings--define-key menu [separator-tab]
menu-bar-separator))
+ (bindings--define-key menu [undelete-last-deleted-frame]
+ '(menu-item "Undelete Frame" undelete-frame
+ :help "Undelete last deleted frame"))
+
;; Don't use delete-frame as event name because that is a special
;; event.
(bindings--define-key menu [delete-this-frame]
diff --git a/src/frame.c b/src/frame.c
index 79a7c89e0d..9e11bc93ed 100644
--- a/src/frame.c
+++ b/src/frame.c
@@ -2376,6 +2376,9 @@ DEFUN ("delete-frame", Fdelete_frame, Sdelete_frame, 0, 2, "",
doc: /* Delete FRAME, permanently eliminating it from use.
FRAME must be a live frame and defaults to the selected one.
+The 16 most recently deleted frames can however be undeleted with
+`undelete-frame', which see.
+
A frame may not be deleted if its minibuffer serves as surrogate
minibuffer for another frame. Normally, you may not delete a frame if
all other frames are invisible, but if the second optional argument
--
2.33.0
next prev parent reply other threads:[~2021-11-16 17:05 UTC|newest]
Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-15 23:38 bug#51883: 29.0.50; Command to get accidentally deleted frames back Michael Heerdegen
2021-11-16 7:53 ` Juri Linkov
2021-11-16 8:14 ` Lars Ingebrigtsen
2021-11-16 20:46 ` Juri Linkov
2021-11-16 8:49 ` Visuwesh via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-16 20:20 ` Juri Linkov
2021-11-16 15:17 ` Gregory Heytings
2021-11-16 17:05 ` Gregory Heytings [this message]
2021-11-16 17:40 ` Eli Zaretskii
2021-11-16 21:29 ` Gregory Heytings
2021-11-17 10:02 ` Gregory Heytings
2021-11-17 13:11 ` Eli Zaretskii
2021-11-17 17:06 ` Juri Linkov
2021-11-17 17:14 ` Eli Zaretskii
2021-11-19 9:00 ` Gregory Heytings
2021-11-19 12:17 ` Eli Zaretskii
2021-11-24 0:44 ` Gregory Heytings
2021-11-27 11:36 ` Michael Heerdegen
2021-11-27 11:53 ` Gregory Heytings
2021-11-27 12:05 ` Eli Zaretskii
2021-11-27 12:12 ` Gregory Heytings
2021-11-27 12:30 ` Andreas Schwab
2021-11-27 12:34 ` Eli Zaretskii
2021-11-27 12:23 ` Michael Heerdegen
2021-11-27 12:40 ` Eli Zaretskii
2021-11-27 13:22 ` Michael Heerdegen
2021-11-27 13:26 ` Eli Zaretskii
2021-11-27 13:34 ` Michael Heerdegen
2021-11-27 13:56 ` Eli Zaretskii
2021-11-27 13:59 ` Michael Heerdegen
2021-11-27 14:02 ` Eli Zaretskii
2021-11-27 14:08 ` Michael Heerdegen
2021-11-27 14:47 ` Eli Zaretskii
2021-11-27 14:12 ` Gregory Heytings
2021-11-27 14:24 ` Michael Heerdegen
2021-11-27 14:26 ` Gregory Heytings
2021-11-27 14:33 ` Michael Heerdegen
2021-11-27 14:42 ` Gregory Heytings
2021-11-27 14:54 ` Michael Heerdegen
2021-11-27 17:19 ` Gregory Heytings
2021-11-28 15:47 ` Michael Heerdegen
2021-11-29 13:38 ` Gregory Heytings
2021-11-29 18:18 ` Michael Heerdegen
2021-11-29 19:07 ` Michael Heerdegen
2021-11-29 20:19 ` Juri Linkov
2022-01-13 8:32 ` Juri Linkov
2022-01-14 8:12 ` Juri Linkov
2022-01-16 20:59 ` Juri Linkov
2022-01-17 0:08 ` Michael Heerdegen
2022-01-17 8:24 ` Juri Linkov
2022-01-17 13:00 ` Eli Zaretskii
2022-01-17 18:41 ` Juri Linkov
2022-01-17 18:51 ` Eli Zaretskii
2022-01-18 18:30 ` Juri Linkov
2022-01-19 18:37 ` Juri Linkov
2022-01-19 20:17 ` Eli Zaretskii
2021-12-12 2:44 ` Michael Heerdegen
2022-01-10 8:13 ` Michael Heerdegen
2021-11-27 14:48 ` Eli Zaretskii
2021-11-27 12:13 ` Michael Heerdegen
2022-01-22 18:10 ` Juri Linkov
2022-01-21 17:52 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-22 18:08 ` Juri Linkov
2022-01-22 21:26 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-23 9:11 ` Juri Linkov
2022-01-23 16:01 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-23 18:12 ` Juri Linkov
2022-01-23 21:26 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-24 18:12 ` Juri Linkov
2022-01-24 18:32 ` Eli Zaretskii
2022-01-25 9:28 ` martin rudalics
2022-01-25 12:29 ` Eli Zaretskii
2022-01-25 15:58 ` martin rudalics
2022-01-27 17:21 ` Juri Linkov
2022-01-27 17:27 ` Eli Zaretskii
2022-01-27 17:48 ` Juri Linkov
2022-01-24 23:00 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-27 17:19 ` Juri Linkov
2022-01-30 16:39 ` Juri Linkov
2022-01-30 16:59 ` Eli Zaretskii
2022-01-30 17:17 ` Juri Linkov
2022-01-30 18:17 ` Eli Zaretskii
2022-01-30 20:49 ` Juri Linkov
2021-11-16 20:30 ` Juri Linkov
2021-11-17 4:13 ` Richard Stallman
2021-11-17 10:07 ` Gregory Heytings
2021-11-17 16:39 ` bug#51883: [External] : " Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8022ede87645d81f38a@heytings.org \
--to=gregory@heytings.org \
--cc=51883@debbugs.gnu.org \
--cc=michael_heerdegen@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).