unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dmitry@gutov.dev>
To: Eli Zaretskii <eliz@gnu.org>, Christoph Badura <bad@bsd.de>
Cc: 72341@debbugs.gnu.org
Subject: bug#72341: VC: CVS template lines not stripped when committing
Date: Tue, 30 Jul 2024 16:35:29 +0300	[thread overview]
Message-ID: <a800a1ea-019e-4397-945f-ee099a5d3982@gutov.dev> (raw)
In-Reply-To: <86a5i0z89z.fsf@gnu.org>

On 29/07/2024 15:34, Eli Zaretskii wrote:
> I'm unsure how to proceed with this.  My bother is that this is a
> definite change in behavior wrt what VC did until now.  Users of VC
> might be unaware of this removal, and could start some log lines with
> the prefix, which will mysteriously disappear from the log message.
> 
> Dmitry, WDYT?  Maybe we should add this removal guarded by a user
> option, by default off?  Or maybe we can identify where the template
> starts and ends, and only remove in that region?

If we do this, we'd only remove the lines starting with "CVS:". We could 
also add special syntax highlighting for them. That would probably be 
enough.

Then vc-cvs-checkin would additionally process the commit message string 
returned by log-edit-extract-headers.

Note that it seems we only handle "templates" for CVS and RCS, so there 
is no prior art for implementing this feature.





  parent reply	other threads:[~2024-07-30 13:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-28 12:32 bug#72341: VC: CVS template lines not stripped when committing Christoph Badura
2024-07-28 17:49 ` Eli Zaretskii
2024-07-28 19:48   ` Christoph Badura
     [not found]   ` <20240728192115.GY9440@irregular-apocalypse.k.bsd.de>
2024-07-29  2:26     ` Eli Zaretskii
2024-07-29  9:53       ` Christoph Badura
2024-07-29 12:34         ` Eli Zaretskii
2024-07-29 15:02           ` Christoph Badura
2024-07-30 13:35           ` Dmitry Gutov [this message]
2024-08-02  7:19             ` Eli Zaretskii
2024-08-09 15:11               ` Christoph Badura

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a800a1ea-019e-4397-945f-ee099a5d3982@gutov.dev \
    --to=dmitry@gutov.dev \
    --cc=72341@debbugs.gnu.org \
    --cc=bad@bsd.de \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).