From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#73387: 30.0.90; C-x v v in diff-mode doesn't work after C-c C-n Date: Mon, 30 Sep 2024 03:27:56 +0300 Message-ID: References: <87zfo28fzu.fsf@zephyr.silentflame.com> <8d0b046e-4b29-4551-b421-e98e212a7b40@yandex.ru> <86msjxefkv.fsf@mail.linkov.net> <87cykt2gkl.fsf@zephyr.silentflame.com> <87jzf01bsk.fsf@zephyr.silentflame.com> <87y13dfgzz.fsf@melete.silentflame.com> <5e956e3b-5891-401a-a898-e339f52ea307@yandex.ru> <87h69ydnvd.fsf@melete.silentflame.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13821"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: 73387@debbugs.gnu.org, monnier@iro.umontreal.ca, Juri Linkov To: Sean Whitton Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 30 02:29:51 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sv4IQ-0003Tv-EN for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 30 Sep 2024 02:29:51 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sv4I9-0005kN-CV; Sun, 29 Sep 2024 20:29:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sv4I7-0005ho-8W for bug-gnu-emacs@gnu.org; Sun, 29 Sep 2024 20:29:31 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sv4I6-0007XS-Vp for bug-gnu-emacs@gnu.org; Sun, 29 Sep 2024 20:29:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:From:References:MIME-Version:Date:To:Subject; bh=BLaabkDNCoVM2cheT/WI+nZ6J1E3mTMMGd/3j/puWt8=; b=HnU3s2jUNyynKBOB2izQKhXIxRTUg7EGD7oAoeHR91YwBfWncs36T9E9Y9gfwbOrBsG+Z0I5URz0JaxYEoGnH1EAY2bwyB7+4FS+LU5IEnzE2q4NKjF79aVzsgxT1s3ZSb9H8z6FC7Vv81vYX9nZbUUyMQjJDvD6CYp9aav3+4Y1h9XrcJLgfL9ER7qNcmr9aVMU+pHFc0/gYZ5lfe6QlTNq77XGC0wGkTWGRpSV450F8grE/P7FyUxhjvJW6OrdI0zHX/pfYq/UZevNehmxucSPY+QcgR6h6WolODSmmkUDUUvF+ABdVNFhRTcW+vt/tYpVZg4Vjf1tF6TIgyE04g==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sv4Ib-00040t-UY for bug-gnu-emacs@gnu.org; Sun, 29 Sep 2024 20:30:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 30 Sep 2024 00:30:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73387 X-GNU-PR-Package: emacs Original-Received: via spool by 73387-submit@debbugs.gnu.org id=B73387.172765615415380 (code B ref 73387); Mon, 30 Sep 2024 00:30:01 +0000 Original-Received: (at 73387) by debbugs.gnu.org; 30 Sep 2024 00:29:14 +0000 Original-Received: from localhost ([127.0.0.1]:43154 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sv4Hq-000400-75 for submit@debbugs.gnu.org; Sun, 29 Sep 2024 20:29:14 -0400 Original-Received: from forward501a.mail.yandex.net ([178.154.239.81]:37248) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sv4Hm-0003zs-Oc for 73387@debbugs.gnu.org; Sun, 29 Sep 2024 20:29:12 -0400 Original-Received: from mail-nwsmtp-smtp-production-main-55.vla.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-55.vla.yp-c.yandex.net [IPv6:2a02:6b8:c0f:604:0:640:5e0e:0]) by forward501a.mail.yandex.net (Yandex) with ESMTPS id 4760060E02; Mon, 30 Sep 2024 03:28:06 +0300 (MSK) Original-Received: by mail-nwsmtp-smtp-production-main-55.vla.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id 2SM0EplgueA0-0MpKgsQl; Mon, 30 Sep 2024 03:28:05 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1727656085; bh=BLaabkDNCoVM2cheT/WI+nZ6J1E3mTMMGd/3j/puWt8=; h=In-Reply-To:From:Subject:Message-ID:Cc:References:Date:To; b=aAwusFb6BjhMZBAcfPbUq9bkcjy/BN3b/NzS+Gru+0OGDnGNotPZHdNW2FjI12HdX 976Xy2N6d7nElRd8zHVoLruHlr8yYLYgB853GdlPkKVyjDiTvsTlstNR4rrsRLiN+Q wg273j3/GP2w1SsCoe5FNeLQphAPYAhiv53Csouw= Authentication-Results: mail-nwsmtp-smtp-production-main-55.vla.yp-c.yandex.net; dkim=pass header.i=@yandex.ru Original-Received: from phl-compute-06.internal (phl-compute-06.phl.internal [10.202.2.46]) by mailfauth.phl.internal (Postfix) with ESMTP id 3D3C01200043; Sun, 29 Sep 2024 20:28:02 -0400 (EDT) Original-Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-06.internal (MEProxy); Sun, 29 Sep 2024 20:28:02 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvddugedgfeehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtvdej necuhfhrohhmpeffmhhithhrhicuifhuthhovhcuoegughhuthhovheshigrnhguvgigrd hruheqnecuggftrfgrthhtvghrnhepiefhjeeuveetffffvdefteffffekhfeuudejieeh heeiudelgfehgffffeduffdunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpe hmrghilhhfrhhomhepughguhhtohhvodhmvghsmhhtphgruhhthhhpvghrshhonhgrlhhi thihqddufeeffeelleehhedvqddvleegjeejjeejiedqughguhhtohhvpeephigrnhguvg igrdhruhesfhgrshhtmhgrihhlrdgtohhmpdhnsggprhgtphhtthhopeegpdhmohguvgep shhmthhpohhuthdprhgtphhtthhopehsphifhhhithhtohhnsehsphifhhhithhtohhnrd hnrghmvgdprhgtphhtthhopeejfeefkeejseguvggssghughhsrdhgnhhurdhorhhgpdhr tghpthhtohepmhhonh X-ME-Proxy: Feedback-ID: ib1d9465d:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 29 Sep 2024 20:27:59 -0400 (EDT) Content-Language: en-US In-Reply-To: <87h69ydnvd.fsf@melete.silentflame.com> X-Yandex-Filter: 1 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:292675 Archived-At: On 30/09/2024 02:46, Sean Whitton wrote: > Hello, > > On Fri 27 Sep 2024 at 10:13pm +03, Dmitry Gutov wrote: > >>> What do you think about this: >>> - add a command which does the kill-all-but-this-hunk (or hunks in >>> region if mark active) thing -- it's generally useful. >>> - make C-x v v on a narrowed buffer, by default, issue a message saying >>> "Cannot commit patch when narrowed, consider " >> >> Or it would implement that previous alternative - using the modified buffer >> string that's limited to the current narrowing. >> >> I'm somewhat concerned about supporting both approaches (how different are the >> code paths going to be?), but if that's needed for usability, perhaps it's >> okay. > > Hmm, I thought that we thought the modified buffer string approach was > too messy. Would you mind outlining your proposal as a whole and how it > differs from my most recent one? Actually, how about we start with your suggested steps, sans for the last one, for now. Meaning, just aborting with a message when the buffer is narrowed, without the user option. We would not be removing any existing functionality this way (this scenario didn't work before, after all), and we could add it later. Would that work for your habits/scenarios?