From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#39452: [PATCH] vc-git-state fails for filenames with wildcards Date: Fri, 14 Feb 2020 22:37:42 +0200 Message-ID: References: <83h802g77h.fsf@gnu.org> <8f427281-510c-30c3-995f-364e22d9c1e2@yandex.ru> <85y2texxso.fsf@gmail.com> <52f47a82-b93e-d9c2-ee94-752b289d4b96@yandex.ru> <83d0ahpkzu.fsf@gnu.org> <6f06f4c8-17c0-31a7-a6d8-e40686b1e987@yandex.ru> <83y2t5ntm6.fsf@gnu.org> <360947a9-3828-a97d-1ddf-6990344e8f77@yandex.ru> <83wo8pnpe3.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="1827"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 Cc: npostavs@gmail.com, 39452@debbugs.gnu.org, Wolfgang.Scherer@gmx.de To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Feb 14 21:38:14 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j2hj3-0000LR-KC for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 14 Feb 2020 21:38:13 +0100 Original-Received: from localhost ([::1]:45526 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j2hj2-0000C3-Gs for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 14 Feb 2020 15:38:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55791) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j2hiu-0000BH-Np for bug-gnu-emacs@gnu.org; Fri, 14 Feb 2020 15:38:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j2hit-0006zW-PD for bug-gnu-emacs@gnu.org; Fri, 14 Feb 2020 15:38:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57023) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j2hit-0006ys-Lu for bug-gnu-emacs@gnu.org; Fri, 14 Feb 2020 15:38:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j2his-0003zC-Bb for bug-gnu-emacs@gnu.org; Fri, 14 Feb 2020 15:38:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 Feb 2020 20:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39452 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 39452-submit@debbugs.gnu.org id=B39452.158171267315307 (code B ref 39452); Fri, 14 Feb 2020 20:38:02 +0000 Original-Received: (at 39452) by debbugs.gnu.org; 14 Feb 2020 20:37:53 +0000 Original-Received: from localhost ([127.0.0.1]:34763 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j2hii-0003yo-Rz for submit@debbugs.gnu.org; Fri, 14 Feb 2020 15:37:53 -0500 Original-Received: from mail-wr1-f66.google.com ([209.85.221.66]:42869) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j2hih-0003yc-0b for 39452@debbugs.gnu.org; Fri, 14 Feb 2020 15:37:51 -0500 Original-Received: by mail-wr1-f66.google.com with SMTP id k11so12421106wrd.9 for <39452@debbugs.gnu.org>; Fri, 14 Feb 2020 12:37:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=BjIsyr41W9HE4xa0xh8OEWFHroxG2NKytfftAp5cq7c=; b=vEeTX4XZsjq+bNTkOBKnOU0m3ebswetwYH5V24V5NcZsp2BNS9z6KbJwJn2ew6JGbz uy1aGKfWJ8kqy2mt7280YQmhuAe+cYtW2wjGKIc+vMyICwVXEIH2biyOaPrKHm5uSfLi +hAbd3KGlnmq+3hW1DSmVQ5JltEPT8EvWr7a7UZ40hPjBnnPaXroX/sk9fUjX5Q9Zos/ nIwzKP8lSIbQxkRmo7uh31md0kTiiJ4Hc5Gty3IfpOknvzARSUEjS+qRvh16ofBL0Edf mgZbI1VPhWB2pZf+MudpC6obe2QWWYaa833Z0b+iLGnsZwPpgsTU7JM6rTCKWBeBRUcR Fudg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=BjIsyr41W9HE4xa0xh8OEWFHroxG2NKytfftAp5cq7c=; b=ViaWo199PpcOayCniC9h7WMKdthjg8r6pGbVAUZCgm31dF9Y6rETIWoFBP/VC1fHxS 05iO43U0yZByx/0TKVKYM3Wj1V9PIgC7qPKdJiL3SxH/elHZVqctNMVvmm0+sVAR04Or HQZ7B5Jx7cr1GqQq6YkaRaAto30J3Z4j2A/bj8+Yu2oylf6U2skged/Tl90++d1uLhSY LByv+/7HMZCVljos7s8+UAN4w+090B38MIzLuMe/g8TArpv4mHOvD1r4DPlIy8TzG6bp haFvFMOj50FP0aBur0iZwANMiH3iS1FU5/Y45CBeu3JME1c3ZwR9eUx9b9ZK/x5xnxnA akeA== X-Gm-Message-State: APjAAAWpjn4AIGUfx+9Sy+8IW/9DzhyKlPwTydbWOyiIyLs7f5Iv6qGv syhLzcxzEtYEoAvE+dwkzSQ= X-Google-Smtp-Source: APXvYqzHHwBHjxTVVuGH8rKyEgYu67X0LaBxfZwtDLDFbQyOlh7JU6UnbZf1DtT4QA4dLP816CF3DQ== X-Received: by 2002:adf:dd46:: with SMTP id u6mr5546367wrm.13.1581712664985; Fri, 14 Feb 2020 12:37:44 -0800 (PST) Original-Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id a13sm8520673wrp.93.2020.02.14.12.37.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 14 Feb 2020 12:37:44 -0800 (PST) In-Reply-To: <83wo8pnpe3.fsf@gnu.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:176066 Archived-At: On 14.02.2020 17:45, Eli Zaretskii wrote: > I won't argue. I just wanted to point out that using Git signatures > internally might get in the way, whereas environment variables and > command-line switches are free from that disadvantage. Um, I think they're about the same in the level of convenience for us to be able to disable either: we can add a global var which would affect whether specs are interpreted literally. If anything, approach #1 is slightly easier if we wanted to support opting out of literal-quoting the specs at the level of VC backend actions: certain action implementations can simply avoid calling the proposed functions (like vc-git--literal-pathspec). But then, I'm not sure that we want this capability at exactly that abstraction level.