From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#18951: eshell-pcomplete removes asterisk when attempting completion Date: Fri, 3 Nov 2017 23:25:34 +0200 Message-ID: References: <86tx2ei4b4.fsf@yandex.ru> <871slid45i.fsf@kraus.my> <87efpi9neq.fsf@users.sourceforge.net> <877ev9p3m7.fsf@kraus.my> <87po909arm.fsf@users.sourceforge.net> <8760assr52.fsf@kraus.my> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1509744372 24951 195.159.176.226 (3 Nov 2017 21:26:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 3 Nov 2017 21:26:12 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:56.0) Gecko/20100101 Thunderbird/56.0 Cc: 18951@debbugs.gnu.org To: Daniel Kraus , Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 03 22:26:08 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eAjTa-0005rm-SJ for geb-bug-gnu-emacs@m.gmane.org; Fri, 03 Nov 2017 22:26:07 +0100 Original-Received: from localhost ([::1]:38508 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eAjTf-0000nX-Gd for geb-bug-gnu-emacs@m.gmane.org; Fri, 03 Nov 2017 17:26:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59484) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eAjTZ-0000nS-9Q for bug-gnu-emacs@gnu.org; Fri, 03 Nov 2017 17:26:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eAjTW-0000zJ-5O for bug-gnu-emacs@gnu.org; Fri, 03 Nov 2017 17:26:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41224) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eAjTV-0000ym-VP for bug-gnu-emacs@gnu.org; Fri, 03 Nov 2017 17:26:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eAjTV-0004Lg-PJ for bug-gnu-emacs@gnu.org; Fri, 03 Nov 2017 17:26:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Nov 2017 21:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18951 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18951-submit@debbugs.gnu.org id=B18951.150974434516693 (code B ref 18951); Fri, 03 Nov 2017 21:26:01 +0000 Original-Received: (at 18951) by debbugs.gnu.org; 3 Nov 2017 21:25:45 +0000 Original-Received: from localhost ([127.0.0.1]:49904 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eAjTE-0004LA-VP for submit@debbugs.gnu.org; Fri, 03 Nov 2017 17:25:45 -0400 Original-Received: from mail-wm0-f43.google.com ([74.125.82.43]:44728) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eAjTD-0004Kt-GR for 18951@debbugs.gnu.org; Fri, 03 Nov 2017 17:25:43 -0400 Original-Received: by mail-wm0-f43.google.com with SMTP id n74so4125010wmi.1 for <18951@debbugs.gnu.org>; Fri, 03 Nov 2017 14:25:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=pElr8EXSCi8J9t1/ENtsqb2Wr1lLJ2WKo5ZBlTtitJM=; b=eLHmbhRLDYQu0TV4apVZBTc6CObvpmqNodTLxBSA9lnHbWouhC7gxHqVxAJx3Q3XPU 8RCSRBvJzEOV9kWgYObIIo++jzMtoLYgwL1OzttLO+/bRo7w+PkaIzqNXxbpy04w1sC+ mD9Mn6CYFVZZiebjniYMYtTE4CI4bkOMqMJTVbgzC7pp+bRxsqZbSZ+9l+FQOG2UPraD WQfTjapr+y9/WjypFACJph6eSOG0g8reB2/eEpPAtu1LoYPyXnwrFMNiTFVLscScfg6g yqUx7iUZliLlo8YfZCI4MjJ/zceNX1VYaXI08XHWoE2MsEBiULZeiEA0JeCbK/zAV3EC I5QQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=pElr8EXSCi8J9t1/ENtsqb2Wr1lLJ2WKo5ZBlTtitJM=; b=IewkDM5HxdTGo9o/Z+DN3AT0TCCTTrAY+wAKUMz/cUqEAYTJoRSq+OFm/kYqCG4mgh oypY+BqbX5KbewUPWqcubrkAK7cnjFtAFhKSVuKri8Mg5O/5FO2u5s6NecHppPYOh1TE aOTHAWMaprvg5HFuk3Qc+GFIV4aSFifE4+bmRyySfpWYt6nKeq9OAKL6SQl7L79NJDXi O0lRvGbLUijgsL+YqnF1YHkT8ceLmVRmQBxd+Ct8SCaAAMiuyb4ZMgypPZAT0tB4KqJ2 7uKn1vJc2tDyTUPnQce+HIHTCZn+mQVlLaLCnb80o9w8DEGF2mJmZljC3//DsFRFDVtp uHSA== X-Gm-Message-State: AMCzsaWSSkUe5w8sN4cQ1dlMPQeMgjx3zPO2SxV3Mp2HNTlyp4bhOQcg IJRAWjIbgwTctlznJ0rlw/yvkonu X-Google-Smtp-Source: ABhQp+SjDkrRATx14jNy/M54RALIiUKNO41QMTU9h+XnqhcuD+UL61+p0FiqPNAq51ouSHNSi6TFGA== X-Received: by 10.80.172.74 with SMTP id w10mr10459625edc.257.1509744337637; Fri, 03 Nov 2017 14:25:37 -0700 (PDT) Original-Received: from [192.168.1.3] ([185.105.174.193]) by smtp.googlemail.com with ESMTPSA id o55sm7535099edc.90.2017.11.03.14.25.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 03 Nov 2017 14:25:36 -0700 (PDT) In-Reply-To: <8760assr52.fsf@kraus.my> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:139424 Archived-At: On 11/2/17 4:15 PM, Daniel Kraus wrote: > > Noam Postavsky writes: > >> Hmm, does this do the right thing? >> >> --- i/lisp/pcomplete.el >> +++ w/lisp/pcomplete.el >> @@ -772,7 +772,7 @@ pcomplete-parse-arguments >> (setq c (cdr c))) >> (setq pcomplete-stub (substring common-stub 0 len) >> pcomplete-autolist t) >> - (when (and begin (not pcomplete-show-list)) >> + (when (and begin (> len 0) (not pcomplete-show-list)) >> (delete-region begin (point)) >> (pcomplete-insert-entry "" pcomplete-stub)) >> (throw 'pcomplete-completions completions)) > > I didn't test it too much if something else breaks but it > seems to work. pcomplete doesn't remove the * and company > mode also seems to work without problems now. Looking good in my testing, and fixes the problem. Thanks! pcomplete-completion-at-point is still buggy, of course, but no worse than before.