From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#55620: [PATCH] 29.0.50; Eshell doesn't reset `eshell-in-pipeline-p' in subcommands Date: Tue, 24 May 2022 20:37:01 -0700 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------4081FB3F3431423B9D88C44E" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24047"; mail-complaints-to="usenet@ciao.gmane.io" To: 55620@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 25 05:38:17 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nthqi-0006A2-U8 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 25 May 2022 05:38:17 +0200 Original-Received: from localhost ([::1]:52096 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nthqh-000777-AE for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 24 May 2022 23:38:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35090) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nthqU-00076r-0L for bug-gnu-emacs@gnu.org; Tue, 24 May 2022 23:38:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60139) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nthqT-0002hD-NG for bug-gnu-emacs@gnu.org; Tue, 24 May 2022 23:38:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nthqT-0005XZ-K4 for bug-gnu-emacs@gnu.org; Tue, 24 May 2022 23:38:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 May 2022 03:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55620 X-GNU-PR-Package: emacs Original-Received: via spool by 55620-submit@debbugs.gnu.org id=B55620.165344982921226 (code B ref 55620); Wed, 25 May 2022 03:38:01 +0000 Original-Received: (at 55620) by debbugs.gnu.org; 25 May 2022 03:37:09 +0000 Original-Received: from localhost ([127.0.0.1]:54036 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nthpd-0005WI-EI for submit@debbugs.gnu.org; Tue, 24 May 2022 23:37:09 -0400 Original-Received: from mail-pj1-f49.google.com ([209.85.216.49]:52807) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nthpc-0005W3-AM for 55620@debbugs.gnu.org; Tue, 24 May 2022 23:37:08 -0400 Original-Received: by mail-pj1-f49.google.com with SMTP id gz24so573317pjb.2 for <55620@debbugs.gnu.org>; Tue, 24 May 2022 20:37:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:from:to:references:message-id:date:mime-version:in-reply-to :content-language; bh=fH0VDp+u3NvZuxah+Jsfzp6oXGoNaMT+EclLKVhSZOM=; b=GLThtLgkHQUEeLnZcS8dtqA6OkaDRmkIkh9oti2raQBp8GcaGL+j9cixpfXqtW6b/2 nqL5Wq15vhjSGtejChdV2WhHnSef4/ZQVVo6LXAst0KbXlK2ARpTlciq9rwsMDcXI7Vo wRTO5luC73nYmnSSKmf690S33vomN4PXOZwDN7hJJgQh3p6j40jot7jJMjWDPii75qrO D7R0KK4snurSqQz7Tw/sRxZcNiv5yYzfBns9LlKJ56vosIjzn8/sNEgG55lwe/Kqy6hb M9vBLno/vvQr0dP5C/jyDDgW9STKHwlDAuekxHUiXNCBw9sL8fbrth6LouGVytbeQcfw sXUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:from:to:references:message-id:date :mime-version:in-reply-to:content-language; bh=fH0VDp+u3NvZuxah+Jsfzp6oXGoNaMT+EclLKVhSZOM=; b=B+y6Rx81wbbtlYE72KG9vdgh/H2m33CzRFVZRyEzUKjFewPIhfajfSH10+BH+4RqT6 0ZjtJavdW6POW/e9fQmsiOrgGHDTKuDR61TVVnf5XGJcThW+rt+9KLnSae/nvTPmqpae SEpz3qOjhcWfs9LXBYQibipiacnH17Yuqrwa+sxFzMnKWqRBsWPJBPyTbBPvt6hwjeLG 2qQHHyi5JUvqOH49P0wfT5g1JfKMZ4SML7A8gVQffaxCF0Reim99q8w20neyufopsPQU 1bx99MkvD+uR0qoXpJjU3+7EDpcuK2zASzE8LEpR0Cy4l/ZEoXb03SMZUYVSJrmanFgT wo6w== X-Gm-Message-State: AOAM532wfXL7FkR6RESdzKTeyDplnMPvjQd5NxoUglGtpYNSYc2lR5AX qS+0132PcqWldH5E2xphQuCLvtiu5wY= X-Google-Smtp-Source: ABdhPJyyOOvKZCiNyvHTiPSeMupMj5WbzGUasfQf3hWFKD9yRvG0vKaVhbdbkIJSQqPAo59XV6nJ8A== X-Received: by 2002:a17:902:ea57:b0:15a:6173:87dd with SMTP id r23-20020a170902ea5700b0015a617387ddmr31140370plg.147.1653449822077; Tue, 24 May 2022 20:37:02 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id i124-20020a62c182000000b0050dc762816dsm8394985pfg.71.2022.05.24.20.37.01 for <55620@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 May 2022 20:37:01 -0700 (PDT) In-Reply-To: Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:233042 Archived-At: This is a multi-part message in MIME format. --------------4081FB3F3431423B9D88C44E Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit (Originally mis-sent with the wrong email address.) Attached is a patch with tests to fix this. Note that I reset `eshell-in-pipeline-p' in two places: 1. `eshell-subcommand-bindings': This handles any case where a subcommand is invoked. This can happen with the following syntaxes: {CMD}, ${CMD}, and $. 2. `eshell-command-to-value': This handles cases where a command is run synchronously. This can happen with some of the syntaxes mentioned above: {CMD} and ${CMD}. However, it can also happen for Lisp forms like (LISP) and $(LISP). (Most Lisp forms aren't likely to consult `eshell-in-pipeline-p', but if you were calling an Eshell built-in command using Lisp syntax, you might run into this issue.) --------------4081FB3F3431423B9D88C44E Content-Type: text/plain; charset=UTF-8; name="0001-Reset-eshell-in-pipeline-p-when-interpolating-comman.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-Reset-eshell-in-pipeline-p-when-interpolating-comman.pa"; filename*1="tch" RnJvbSAzYTE4MTk5ZmNjODkxOTIyMDg5MmMyNWM2NDk3MGM3MzQzYzllNjNmIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFR1ZSwgMjQgTWF5IDIwMjIgMTg6NTY6NTAgLTA3MDAKU3ViamVjdDogW1BB VENIXSBSZXNldCAnZXNoZWxsLWluLXBpcGVsaW5lLXAnIHdoZW4gaW50ZXJwb2xhdGluZyBj b21tYW5kcwoKKiBsaXNwL2VzaGVsbC9lc2gtY21kLmVsIChlc2hlbGwtc3ViY29tbWFuZC1i aW5kaW5ncykKKGVzaGVsbC1jb21tYW5kLXRvLXZhbHVlKTogU2V0ICdlc2hlbGwtaW4tcGlw ZWxpbmUtcCcgdG8gbmlsLgoKKiB0ZXN0L2xpc3AvZXNoZWxsL2VzaGVsbC10ZXN0cy5lbAoo ZXNoZWxsLXRlc3Qvc3ViY29tbWFuZC1yZXNldC1pbi1waXBlbGluZSkKKGVzaGVsbC10ZXN0 L2xpc3AtcmVzZXQtaW4tcGlwZWxpbmUpOiBOZXcgdGVzdHMgKGJ1ZyM1NTYyMCkuCi0tLQog bGlzcC9lc2hlbGwvZXNoLWNtZC5lbCAgICAgICAgICAgfCAgNCArKystCiB0ZXN0L2xpc3Av ZXNoZWxsL2VzaGVsbC10ZXN0cy5lbCB8IDI5ICsrKysrKysrKysrKysrKysrKysrKysrKysr KysrCiAyIGZpbGVzIGNoYW5nZWQsIDMyIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkK CmRpZmYgLS1naXQgYS9saXNwL2VzaGVsbC9lc2gtY21kLmVsIGIvbGlzcC9lc2hlbGwvZXNo LWNtZC5lbAppbmRleCA3M2MyNTA2MzJjLi43NzVlNGMxMDU3IDEwMDY0NAotLS0gYS9saXNw L2VzaGVsbC9lc2gtY21kLmVsCisrKyBiL2xpc3AvZXNoZWxsL2VzaC1jbWQuZWwKQEAgLTI1 Niw2ICsyNTYsNyBAQCBlc2hlbGwtZGVmZXJyYWJsZS1jb21tYW5kcwogCiAoZGVmY3VzdG9t IGVzaGVsbC1zdWJjb21tYW5kLWJpbmRpbmdzCiAgICcoKGVzaGVsbC1pbi1zdWJjb21tYW5k LXAgdCkKKyAgICAoZXNoZWxsLWluLXBpcGVsaW5lLXAgbmlsKQogICAgIChkZWZhdWx0LWRp cmVjdG9yeSBkZWZhdWx0LWRpcmVjdG9yeSkKICAgICAocHJvY2Vzcy1lbnZpcm9ubWVudCAo ZXNoZWxsLWNvcHktZW52aXJvbm1lbnQpKSkKICAgIkEgbGlzdCBvZiBgbGV0JyBiaW5kaW5n cyBmb3Igc3ViY29tbWFuZCBlbnZpcm9ubWVudHMuIgpAQCAtOTA3LDcgKzkwOCw4IEBAIGVz aGVsbC1kby1jb21tYW5kLXRvLXZhbHVlCiAoZGVmbWFjcm8gZXNoZWxsLWNvbW1hbmQtdG8t dmFsdWUgKG9iamVjdCkKICAgIlJ1biBPQkpFQ1Qgc3luY2hyb25vdXNseSwgcmV0dXJuaW5n IGl0cyByZXN1bHQgYXMgYSBzdHJpbmcuCiBSZXR1cm5zIGEgc3RyaW5nIGNvbXByaXNpbmcg dGhlIG91dHB1dCBmcm9tIHRoZSBjb21tYW5kLiIKLSAgYChsZXQgKCh2YWx1ZSAobWFrZS1z eW1ib2wgImVzaGVsbC10ZW1wIikpKQorICBgKGxldCAoKHZhbHVlIChtYWtlLXN5bWJvbCAi ZXNoZWxsLXRlbXAiKSkKKyAgICAgICAgIChlc2hlbGwtaW4tcGlwZWxpbmUtcCBuaWwpKQog ICAgICAoZXNoZWxsLWRvLWNvbW1hbmQtdG8tdmFsdWUgLG9iamVjdCkpKQogCiA7OztfKiBJ dGVyYXRpdmUgZXZhbHVhdGlvbgpkaWZmIC0tZ2l0IGEvdGVzdC9saXNwL2VzaGVsbC9lc2hl bGwtdGVzdHMuZWwgYi90ZXN0L2xpc3AvZXNoZWxsL2VzaGVsbC10ZXN0cy5lbAppbmRleCBj MGFmZmVkODBhLi5hYjVkNzNkNDc5IDEwMDY0NAotLS0gYS90ZXN0L2xpc3AvZXNoZWxsL2Vz aGVsbC10ZXN0cy5lbAorKysgYi90ZXN0L2xpc3AvZXNoZWxsL2VzaGVsbC10ZXN0cy5lbApA QCAtMTMwLDYgKzEzMCwzNSBAQCBlc2hlbGwtdGVzdC9waXBlLXN1YmNvbW1hbmQtd2l0aC1w aXBlCiAgICAoZXNoZWxsLWNvbW1hbmQtcmVzdWx0LXAgImVjaG8gJHsqZWNobyBoaSB8ICpj YXR9IHwgKmNhdCIKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiaGkiKSkpCiAKKyhl cnQtZGVmdGVzdCBlc2hlbGwtdGVzdC9zdWJjb21tYW5kLXJlc2V0LWluLXBpcGVsaW5lICgp CisgICJDaGVjayB0aGF0IHN1YmNvbW1hbmRzIHJlc2V0IGBlc2hlbGwtaW4tcGlwZWxpbmUt cCcuIgorICAoc2tpcC11bmxlc3MgKGV4ZWN1dGFibGUtZmluZCAiY2F0IikpCisgIChkb2xp c3QgKHRlbXBsYXRlICcoImVjaG8geyVzfSB8ICpjYXQiCisgICAgICAgICAgICAgICAgICAg ICAgImVjaG8gJHslc30gfCAqY2F0IgorICAgICAgICAgICAgICAgICAgICAgICIqY2F0ICQ8 JXM+IHwgKmNhdCIpKQorICAgIChzaG91bGQgKGVxdWFsIChlc2hlbGwtdGVzdC1jb21tYW5k LXJlc3VsdAorICAgICAgICAgICAgICAgICAgICAoZm9ybWF0IHRlbXBsYXRlICJlY2hvICRl c2hlbGwtaW4tcGlwZWxpbmUtcCIpKQorICAgICAgICAgICAgICAgICAgIG5pbCkpCisgICAg KHNob3VsZCAoZXF1YWwgKGVzaGVsbC10ZXN0LWNvbW1hbmQtcmVzdWx0CisgICAgICAgICAg ICAgICAgICAgIChmb3JtYXQgdGVtcGxhdGUgImVjaG8gfCBlY2hvICRlc2hlbGwtaW4tcGlw ZWxpbmUtcCIpKQorICAgICAgICAgICAgICAgICAgICJsYXN0IikpCisgICAgKHNob3VsZCAo ZXF1YWwgKGVzaGVsbC10ZXN0LWNvbW1hbmQtcmVzdWx0CisgICAgICAgICAgICAgICAgICAg IChmb3JtYXQgdGVtcGxhdGUgImVjaG8gJGVzaGVsbC1pbi1waXBlbGluZS1wIHwgZWNobyIp KQorICAgICAgICAgICAgICAgICAgICJmaXJzdCIpKQorICAgIChzaG91bGQgKGVxdWFsIChl c2hlbGwtdGVzdC1jb21tYW5kLXJlc3VsdAorICAgICAgICAgICAgICAgICAgICAoZm9ybWF0 IHRlbXBsYXRlCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgImVjaG8gfCBlY2hvICRl c2hlbGwtaW4tcGlwZWxpbmUtcCB8IGVjaG8iKSkKKyAgICAgICAgICAgICAgICAgICAidCIp KSkpCisKKyhlcnQtZGVmdGVzdCBlc2hlbGwtdGVzdC9saXNwLXJlc2V0LWluLXBpcGVsaW5l ICgpCisgICJDaGVjayB0aGF0IGludGVycG9sYXRlZCBMaXNwIGZvcm1zIHJlc2V0IGBlc2hl bGwtaW4tcGlwZWxpbmUtcCcuIgorICAoc2tpcC11bmxlc3MgKGV4ZWN1dGFibGUtZmluZCAi Y2F0IikpCisgIChkb2xpc3QgKHRlbXBsYXRlICcoImVjaG8gKCVzKSB8ICpjYXQiCisgICAg ICAgICAgICAgICAgICAgICAgImVjaG8gJCglcykgfCAqY2F0IikpCisgICAgKHNob3VsZCAo ZXF1YWwgKGVzaGVsbC10ZXN0LWNvbW1hbmQtcmVzdWx0CisgICAgICAgICAgICAgICAgICAg IChmb3JtYXQgdGVtcGxhdGUgImZvcm1hdCBcIiVzXCIgZXNoZWxsLWluLXBpcGVsaW5lLXAi KSkKKyAgICAgICAgICAgICAgICAgICAibmlsIikpKSkKKwogKGVydC1kZWZ0ZXN0IGVzaGVs bC10ZXN0L3JlZGlyZWN0LWJ1ZmZlciAoKQogICAiQ2hlY2sgdGhhdCBwaXBpbmcgdG8gYSBi dWZmZXIgd29ya3MiCiAgICh3aXRoLXRlbXAtYnVmZmVyCi0tIAoyLjI1LjEKCg== --------------4081FB3F3431423B9D88C44E--