unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Daniel Mendler <mail@daniel-mendler.de>
To: Gregory Heytings <gregory@heytings.org>, Eli Zaretskii <eliz@gnu.org>
Cc: michael_heerdegen@web.de, Philip Kaludercic <philipk@posteo.net>,
	Augusto Stoffel <arstoffel@gmail.com>,
	monnier@iro.umontreal.ca, 62009@debbugs.gnu.org
Subject: bug#62009: 29.0.60; Emacs crashes on setf symbol-name
Date: Fri, 10 Mar 2023 11:31:22 +0100	[thread overview]
Message-ID: <a6b6eff0-1aa7-d0e7-3cd9-cc87ae76c421@daniel-mendler.de> (raw)
In-Reply-To: <16ecbe9ea8ba9d39d058@heytings.org>

On 3/10/23 10:40, Gregory Heytings wrote:
> Instead of raising a signal, I suggest:
> 
> diff --git a/src/data.c b/src/data.c
> index 0f1d881e00b..76867d6787e 100644
> --- a/src/data.c
> +++ b/src/data.c
> @@ -780,7 +780,7 @@ DEFUN ("symbol-name", Fsymbol_name, Ssymbol_name, 1, 
> 1, 0,
> 
>     CHECK_SYMBOL (symbol);
>     name = SYMBOL_NAME (symbol);
> -  return name;
> +  return build_string (SSDATA (name));
>   }
> 
>   DEFUN ("bare-symbol", Fbare_symbol, Sbare_symbol, 1, 1, 0,

Creating a string is not a good idea since it will lead to an
unacceptably large performance overhead. Raising an exception upon
modification would be the best approach.

Daniel





  reply	other threads:[~2023-03-10 10:31 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-06 19:26 bug#62009: 29.0.60; Emacs crashes on setf symbol-name Daniel Mendler
2023-03-07  4:40 ` Ruijie Yu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-07 15:45 ` Michael Heerdegen
2023-03-07 17:08   ` Daniel Mendler
2023-03-07 17:39     ` Eli Zaretskii
2023-03-09 21:11       ` Philip Kaludercic
2023-03-10  7:11         ` Eli Zaretskii
2023-03-10  8:45           ` Augusto Stoffel
2023-03-10  8:47             ` Augusto Stoffel
2023-03-10 11:50               ` Eli Zaretskii
2023-03-10 12:00                 ` Daniel Mendler
2023-03-10 12:35                   ` Eli Zaretskii
2023-03-10 12:45                     ` Daniel Mendler
2023-03-10 12:57                       ` Eli Zaretskii
2023-03-10 13:08                         ` Daniel Mendler
2023-03-10 15:02                           ` Eli Zaretskii
2023-03-11 15:16                     ` Gregory Heytings
2023-03-11 15:37                       ` Eli Zaretskii
2023-03-18 22:46                         ` Gregory Heytings
2023-03-19  6:03                           ` Eli Zaretskii
2023-03-19 21:20                             ` Gregory Heytings
2023-03-10 11:49             ` Eli Zaretskii
2023-03-10  9:40           ` Gregory Heytings
2023-03-10 10:31             ` Daniel Mendler [this message]
2023-03-10 10:59               ` Gregory Heytings
2023-03-10 11:09                 ` Daniel Mendler
2023-03-10 11:23                   ` Augusto Stoffel
2023-03-10 12:09                     ` Eli Zaretskii
2023-03-10 11:30                   ` Robert Pluim
2023-03-10 11:36                     ` Daniel Mendler
2023-03-10 12:13                       ` Eli Zaretskii
2023-03-10 12:24                         ` Daniel Mendler
2023-03-10 22:01                           ` Dmitry Gutov
2023-03-10 11:57                     ` Gregory Heytings
2023-03-10 12:12                     ` Eli Zaretskii
2023-03-10 13:19                       ` Robert Pluim
2023-03-11  7:07                     ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-13  8:07                       ` Robert Pluim
2023-03-13  8:28                         ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-13 11:47                           ` Eli Zaretskii
2023-03-13 11:50                             ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-13 11:46                         ` Eli Zaretskii
2023-03-10 11:59                 ` Eli Zaretskii
2023-03-10 11:53             ` Eli Zaretskii
2023-03-10 11:59               ` Gregory Heytings
2023-03-11  7:07               ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-11  7:47                 ` Eli Zaretskii
2023-03-10 18:56           ` Philip Kaludercic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a6b6eff0-1aa7-d0e7-3cd9-cc87ae76c421@daniel-mendler.de \
    --to=mail@daniel-mendler.de \
    --cc=62009@debbugs.gnu.org \
    --cc=arstoffel@gmail.com \
    --cc=eliz@gnu.org \
    --cc=gregory@heytings.org \
    --cc=michael_heerdegen@web.de \
    --cc=monnier@iro.umontreal.ca \
    --cc=philipk@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).