From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#27238: 24.5; Rename `face-spec-set-2' and give it a better doc string Date: Mon, 5 Jun 2017 10:56:13 -0700 (PDT) Message-ID: References: <<<<<<06a7cc83-a2a8-45a0-97d4-bd3a478aab92@default>>>>>> <<<<<<83wp8ra9g6.fsf@gnu.org>>>>>> <<<<<26a213b3-908e-43b1-a009-b8a18f0a1c23@default>>>>> <<<<<83tw3v9njh.fsf@gnu.org>>>>> <<<>>> <<<<83lgp6a257.fsf@gnu.org>>>> <<<139eede5-534a-47ad-805a-bad9995526eb@default>>> <<<83d1ai9yy1.fsf@gnu.org>>> <<2ceee035-593d-4831-be30-06443ba3bc92@default>> <<83bmq29x63.fsf@gnu.org>> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1496685432 16511 195.159.176.226 (5 Jun 2017 17:57:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 5 Jun 2017 17:57:12 +0000 (UTC) Cc: 27238@debbugs.gnu.org To: Eli Zaretskii , Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jun 05 19:57:08 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dHwFX-0003zk-UP for geb-bug-gnu-emacs@m.gmane.org; Mon, 05 Jun 2017 19:57:08 +0200 Original-Received: from localhost ([::1]:34565 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dHwFd-0002gE-Dd for geb-bug-gnu-emacs@m.gmane.org; Mon, 05 Jun 2017 13:57:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47018) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dHwFX-0002fw-GG for bug-gnu-emacs@gnu.org; Mon, 05 Jun 2017 13:57:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dHwFS-0007b0-Mn for bug-gnu-emacs@gnu.org; Mon, 05 Jun 2017 13:57:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:55344) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dHwFS-0007av-Iv for bug-gnu-emacs@gnu.org; Mon, 05 Jun 2017 13:57:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dHwFS-0005Op-3T for bug-gnu-emacs@gnu.org; Mon, 05 Jun 2017 13:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 05 Jun 2017 17:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27238 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 27238-submit@debbugs.gnu.org id=B27238.149668538520715 (code B ref 27238); Mon, 05 Jun 2017 17:57:02 +0000 Original-Received: (at 27238) by debbugs.gnu.org; 5 Jun 2017 17:56:25 +0000 Original-Received: from localhost ([127.0.0.1]:58021 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dHwEr-0005O1-Iy for submit@debbugs.gnu.org; Mon, 05 Jun 2017 13:56:25 -0400 Original-Received: from aserp1040.oracle.com ([141.146.126.69]:40529) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dHwEp-0005No-0o for 27238@debbugs.gnu.org; Mon, 05 Jun 2017 13:56:23 -0400 Original-Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id v55HuFx7012896 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 5 Jun 2017 17:56:16 GMT Original-Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id v55HuFvM022409 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 5 Jun 2017 17:56:15 GMT Original-Received: from abhmp0005.oracle.com (abhmp0005.oracle.com [141.146.116.11]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id v55HuEsv022995; Mon, 5 Jun 2017 17:56:15 GMT In-Reply-To: <<83bmq29x63.fsf@gnu.org>> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 12.0.6767.5000 (x86)] X-Source-IP: userv0021.oracle.com [156.151.31.71] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:133310 Archived-At: > > > > "set one face (`fringe' or whatever), in only a given frame, > > > > ^^^^^^^^^^^^^^^^^^^^^ > > > > to the spec of another face (or to a spec that isn't yet used > > > > for any face)" > > > > > > > > I don't see a "higher-level function" that does that. I don't > > > > see any function that does, apart from `face-spec-2'. > > > > > > Doesn't this boil down to setting the attributes of the target face t= o > > > the values of the same attributes of the source face? > > > > Yes, of course, which is why `face-spec-set-2' does that: >=20 > No, it also consults face-x-resources, which is not necessarily what > the caller wants. That's not the point. The point is code to "set the attributes of the target face to the values of the same attributes of the source face". Do you see another function that does that? > > Are suggesting that everyone who needs to "set the attributes > > of the target face to the values of the same attributes of the > > source face" should just write such an explicit loop (repeat > > the body of `face-spec-set-2') instead of just calling > > `face-spec-set-2'? >=20 > Are you suggesting that for every loop someone might possibly need at > some point we should have a documented and public function in Emacs? Do you think I am? Why? > > Or are you hinting that there is some other "higher-level > > function" that already does exactly that? >=20 > Well, there's defface with :inherit, and there's copy-face, to name > just two. You didn't describe enough context of what you want to do, > so I cannot be sure they are not relevant. Should I explicitly have mentioned that I don't want to inherit another face? But I did forget that `copy-face', where the NEW-FACE arg is an existing face, does what I was looking for. Thanks for the reminder about it. That works for my use case. (Why doesn't `face-spec-recalc' use `copy-face' instead of `face-spec-set-2'? I guess it's to check the return value of `face-spec-choose', which it goes to the trouble of calling for each face that it iterates over.) BTW, while looking to see if Emacs 22 would support my code, since it will not use `face-spec-set-2', I (re)discovered that prior to Emacs 24.3 `frame-set-spec' DID let you specify the FRAME. The signature of `frame-spec-set' was changed incompatibly after Emacs 24.3. (I still suggest fixing the doc string of `face-spec-set-2', as it is misleading about its "SPEC" arg.)