From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#71477: 30.0.50; Lock files are not deleted on Windows 98 Date: Wed, 12 Jun 2024 10:57:10 -0700 Organization: UCLA Computer Science Department Message-ID: References: <87r0d4bzut.fsf.ref@yahoo.com> <87r0d4bzut.fsf@yahoo.com> <867cew8zgh.fsf@gnu.org> <87ikygb6hp.fsf@yahoo.com> <86h6e06kn5.fsf@gnu.org> <87bk47c4cd.fsf@yahoo.com> <86bk477vzx.fsf@gnu.org> <871q53c2ur.fsf@yahoo.com> <868qzb7uic.fsf@gnu.org> <87jzivamzp.fsf@yahoo.com> <86h6dy1saf.fsf@gnu.org> <531dbf85-2554-43aa-bca1-db50e0bf2306@cs.ucla.edu> <86sexiytlx.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12152"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: luangruo@yahoo.com, 71477@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 12 19:58:30 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sHSEv-0002x5-KJ for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 12 Jun 2024 19:58:29 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sHSEW-0005ug-SM; Wed, 12 Jun 2024 13:58:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sHSEV-0005uV-QM for bug-gnu-emacs@gnu.org; Wed, 12 Jun 2024 13:58:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sHSEV-0006cu-Fo for bug-gnu-emacs@gnu.org; Wed, 12 Jun 2024 13:58:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sHSEU-00035u-6Y for bug-gnu-emacs@gnu.org; Wed, 12 Jun 2024 13:58:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Jun 2024 17:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71477 X-GNU-PR-Package: emacs Original-Received: via spool by 71477-submit@debbugs.gnu.org id=B71477.171821504011846 (code B ref 71477); Wed, 12 Jun 2024 17:58:02 +0000 Original-Received: (at 71477) by debbugs.gnu.org; 12 Jun 2024 17:57:20 +0000 Original-Received: from localhost ([127.0.0.1]:40091 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sHSDo-000350-Bb for submit@debbugs.gnu.org; Wed, 12 Jun 2024 13:57:20 -0400 Original-Received: from mail.cs.ucla.edu ([131.179.128.66]:56486) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sHSDk-00034m-5L for 71477@debbugs.gnu.org; Wed, 12 Jun 2024 13:57:18 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id 8B1493C011BD4; Wed, 12 Jun 2024 10:57:11 -0700 (PDT) Original-Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10032) with ESMTP id a_o379x1v5sf; Wed, 12 Jun 2024 10:57:11 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id 3E6033C011BD7; Wed, 12 Jun 2024 10:57:11 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.cs.ucla.edu 3E6033C011BD7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu; s=9D0B346E-2AEB-11ED-9476-E14B719DCE6C; t=1718215031; bh=Yjtt1r/zzaNjRLUnphRmwKsxSU3ApoUYgC7ZLAjRIrE=; h=Message-ID:Date:MIME-Version:To:From; b=FSrTuOwAtlshm4EzQnvpThI+51Bajo51wvRaORsvX0Y5DQrZNPQR3nPkIQMKsFP0O /dJ8LJKtxb5g9naeB1VtjTrtrRAwYyCCuwl0Y74sPR9Pg+A/69LAf/XOjZNaXYsQUK Zo5lGTfF+p5/KZbr1TOpiO8gTCwuNzNOyb4lTsnVNuIq4sFTbuB3TfEphY27oDiAv7 fF0ezTUzLwTao6U+691EpBcjIQ19rgAYiLm7/HkztFe6b3/ltfOMAKyObMZmzvtPfg fd/PhI5SgXvgQPPtk0LdS7F5KTr6BkUS0xU/ICQ2vV4a0nujHvfW5lrnK6rQKk0V+p KFpXVsRfhyxuA== X-Virus-Scanned: amavis at mail.cs.ucla.edu Original-Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10026) with ESMTP id QDbyq5PrVUWL; Wed, 12 Jun 2024 10:57:11 -0700 (PDT) Original-Received: from [192.168.254.12] (unknown [47.154.17.165]) by mail.cs.ucla.edu (Postfix) with ESMTPSA id 22A893C011BD4; Wed, 12 Jun 2024 10:57:11 -0700 (PDT) Content-Language: en-US In-Reply-To: <86sexiytlx.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:287168 Archived-At: On 2024-06-12 10:10, Eli Zaretskii wrote: > But on all platforms except Windows 9X we shouldn't see a negative PID > here, so what you say is purely theoretical, no? No, because that value doesn't come from a pid_t that the system gave us as a process ID. It comes from the file system, and so could be invalid as a process ID. That's why the code already checks that pid <= TYPE_MAXIMUM (pid_t). Such a check wouldn't be needed if the pid were a valid process ID. >> Even on MS Windows 98 we should check that TYPE_MINIMUM (pid_t) <= pid. > > Since pid_t is typedefed as 'int', that's always true, no? No, because the code is checking 'pid', which is of type intmax_t not pid_t. (And anyway pid_t need not be 'int'.) > No. And our emulation of 'kill' fails with EPERM when called witgh > both arguments zero. In that case there's no need to worry about pid == 0 here. > Fine with me, please install and I will followup. OK, installed.