From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Ryan C. Thompson" Newsgroups: gmane.emacs.bugs Subject: bug#19412: bug#28513 Date: Sun, 10 Jan 2021 18:07:23 -0500 Message-ID: References: <430c52f7-7962-4e65-874f-f4a572951314@thompsonclan.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22553"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 Cc: 19412@debbugs.gnu.org To: 28513@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 11 00:08:20 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kyjoq-0005lQ-8E for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 11 Jan 2021 00:08:20 +0100 Original-Received: from localhost ([::1]:40654 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kyjoo-0002AN-WF for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 10 Jan 2021 18:08:19 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38130) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kyjoY-0002A9-HJ for bug-gnu-emacs@gnu.org; Sun, 10 Jan 2021 18:08:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43573) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kyjoY-0006cR-9r for bug-gnu-emacs@gnu.org; Sun, 10 Jan 2021 18:08:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kyjoY-0003eV-3m for bug-gnu-emacs@gnu.org; Sun, 10 Jan 2021 18:08:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Ryan C. Thompson" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 Jan 2021 23:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19412 X-GNU-PR-Package: emacs Original-Received: via spool by 19412-submit@debbugs.gnu.org id=B19412.161032005413930 (code B ref 19412); Sun, 10 Jan 2021 23:08:02 +0000 Original-Received: (at 19412) by debbugs.gnu.org; 10 Jan 2021 23:07:34 +0000 Original-Received: from localhost ([127.0.0.1]:55119 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kyjo6-0003cU-Gf for submit@debbugs.gnu.org; Sun, 10 Jan 2021 18:07:34 -0500 Original-Received: from mail-io1-f43.google.com ([209.85.166.43]:43380) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kyjo4-0003bm-Ok for 19412@debbugs.gnu.org; Sun, 10 Jan 2021 18:07:33 -0500 Original-Received: by mail-io1-f43.google.com with SMTP id o6so15919553iob.10 for <19412@debbugs.gnu.org>; Sun, 10 Jan 2021 15:07:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thompsonclan-org.20150623.gappssmtp.com; s=20150623; h=subject:from:to:references:cc:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=J3VhXwAEVwPvpDnS9AFPX0zVzmqhQaIs1WGgQ08PdDY=; b=eUSJ3IHm+i3Vzmu47AJTbDfEtySkmHwM2zjc9qWRgD1nGwOvc4fGlsDMX3j+AYZ2d/ e4YNNsw0KNJZAZigCy28nZSvQjLn4021u5mSyynV4WAULis1S7fmY0FgFzc1w3myzbAt IpRQfaxkoU/UFfM5uGXkVTLTz3mwLjB95PL6QWFzxjf/GuWyvIO7C5vfipZoQ46PrQNV XIXaMeWtILHxD6IqvUgy8bZ+xvFq9nz1kh1gJ02fBT97R1Moa7tkaexIp6sJunbGXqdq Gb/RCaAkpjS9e/aFp0C9DbjlRWYM5ZncboQ2Rf8aWSrTS3AUYeLmO3EpkgUSI+yj7jjk uzOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:references:cc:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=J3VhXwAEVwPvpDnS9AFPX0zVzmqhQaIs1WGgQ08PdDY=; b=D0EMaJ19T9DSZd+mTZPCb4N1Y5JNqYBEjA4vp7Cy8WRZWDLhjV15UqVogILV4IACvT DtNJT4FzFpWsagY5gRgxxiNRc7/BdWJAIRjAqF6Ew9M08ZQAreyDJudG2/GvrVWCXBOJ MI0uJre1LRN6Zk8UGbTyqUDaIQOfDteieOSUX+qsHkBU8Ye4E7aoCOmm2z2IT6PRuVVK ciUwoOUsKDZeuqQmf5SOYAcbsGjVrUmT+lJShzjtElrlIkDmk8tjN5pfO8Bf2EORK3mD 46rjZ92gdlA4VSSMdeMZv6ySaQpezW4lseSOUQ5t6epoVFHNL3a6XaGUszwusNMlB3QY d0Sw== X-Gm-Message-State: AOAM533wvHAq/T70yRXjWdSlSXyq6J8EhAETDKpZDeQH8gdzjFd97VzC s/VhO275yprCmYDtU1hBKu0qZwX+vJcsKslE X-Google-Smtp-Source: ABdhPJzo8evI1zcGQzuciHwjxxng/3smzlhI/4TvoL5Paa1yseSkbbG0B6pPNf82CpvFX3b6d+zpWg== X-Received: by 2002:a05:6638:3006:: with SMTP id r6mr12339746jak.72.1610320046893; Sun, 10 Jan 2021 15:07:26 -0800 (PST) Original-Received: from urania.local (c-76-116-193-120.hsd1.nj.comcast.net. [76.116.193.120]) by smtp.gmail.com with ESMTPSA id r3sm13201184ilt.76.2021.01.10.15.07.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 10 Jan 2021 15:07:26 -0800 (PST) In-Reply-To: <430c52f7-7962-4e65-874f-f4a572951314@thompsonclan.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:197668 Archived-At: Hello again, I finally got around to testing this patch. I've been using it for over a week now and I haven't observed any unexpected behaviors or issues as a result. And of course, it does indeed resolve the bug as reported here. I believe my patch is ready to merge. Again, for more details on how my patch works, see my investigation in #19412. Regards, Ryan Thompson On 1/1/21 4:51 PM, Ryan C. Thompson wrote: > Hello, > > I believe this bug (#28513) is a duplicate of #19412. In the > discussion for #19412 I have investigated the problem and proposed a > fix that doesn't require special-casing anything. However, due to > being quite busy since then I have not had the time to properly test > my fix. Briefly, the fix is to pass all the original args to the > fallback function unchanged and then use "minibuffer-with-setup-hook" > to simulate deleting the initial input and then typing whatever the > user currently had typed into ido before they triggered the fallback. > > I have rebased the patch from that thread onto the current master and > attached it. To reiterate, this patch should be tested before merging. > > Regards, > > Ryan >