From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Konstantin Kharlamov Newsgroups: gmane.emacs.bugs Subject: bug#74382: `compile-first` Make rule is no longer using `load-prefer-newer` Date: Sun, 17 Nov 2024 19:04:42 +0300 Message-ID: References: <6bc3a410f0857c3e3433070ac19deaf7eae88c63.camel@yandex.ru> <31dfd7d1c1c19d3fff5609b86ce85c1533a84af0.camel@yandex.ru> <861pz9x45w.fsf@gnu.org> <86zflxvoux.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39313"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Evolution 3.54.1 Cc: gerd.moellmann@gmail.com, acm@muc.de, 74382@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 17 17:05:32 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tChmF-000A4d-LT for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 17 Nov 2024 17:05:31 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tChlq-0000O7-KF; Sun, 17 Nov 2024 11:05:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tChlm-0000Nv-Mc for bug-gnu-emacs@gnu.org; Sun, 17 Nov 2024 11:05:04 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tChlm-0000iD-79 for bug-gnu-emacs@gnu.org; Sun, 17 Nov 2024 11:05:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:References:In-Reply-To:Date:From:To:Subject; bh=WQvowaJiSB76Co+Uw7ot8k+5G2npdtMuaAxS0tmSh58=; b=uaOk/tPPeeQfnYWc1eyc6Vrb2X0i+k94ykeJykPyA10P3+nk5svcdoWEoc2ZN8fftgV7zn3KpsaSA2DLhLp9V0rgMyHhIUJsCrAlbshMS2EP38tOIaVPdbS+J5SKGCQkk5u+YZ1oGchE9IQ3XRUMxI84w0YFNpCIxnXVvbdpoR9g2mRZ+dL0gFHI3/lNM6rYHRaeaopkJK+jvk5H7Mu0xcPO0m+NzOhP9QGfXcq95Omz0TWUCq4ZaQV1KigalDnHwcs0moO074G+HVXCjlskab2FTvULxg4GJ1w3bg+TQyPcusXFRRPMi7XKwn2oXw7RjkUAPv0K+TUGguJyyd7zKA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tChll-00011Q-N4 for bug-gnu-emacs@gnu.org; Sun, 17 Nov 2024 11:05:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Konstantin Kharlamov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 17 Nov 2024 16:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74382 X-GNU-PR-Package: emacs Original-Received: via spool by 74382-submit@debbugs.gnu.org id=B74382.17318594933907 (code B ref 74382); Sun, 17 Nov 2024 16:05:01 +0000 Original-Received: (at 74382) by debbugs.gnu.org; 17 Nov 2024 16:04:53 +0000 Original-Received: from localhost ([127.0.0.1]:58188 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tChlc-00010x-VC for submit@debbugs.gnu.org; Sun, 17 Nov 2024 11:04:53 -0500 Original-Received: from forward502b.mail.yandex.net ([178.154.239.146]:35306) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tChla-00010c-38 for 74382@debbugs.gnu.org; Sun, 17 Nov 2024 11:04:52 -0500 Original-Received: from mail-nwsmtp-smtp-production-main-60.sas.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-60.sas.yp-c.yandex.net [IPv6:2a02:6b8:c11:1115:0:640:1385:0]) by forward502b.mail.yandex.net (Yandex) with ESMTPS id 582E861038; Sun, 17 Nov 2024 19:04:43 +0300 (MSK) Original-Received: by mail-nwsmtp-smtp-production-main-60.sas.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id g4SmflVOn8c0-k28aLhfk; Sun, 17 Nov 2024 19:04:42 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1731859482; bh=WQvowaJiSB76Co+Uw7ot8k+5G2npdtMuaAxS0tmSh58=; h=References:Date:In-Reply-To:Cc:To:From:Subject:Message-ID; b=p6m3a6y9mEUP+C/aXi1a68qPBen4cdlU5PTeIXRqz9Ve5nuA4tUtvOvmVYO5wusAc vWLmfBuocXzN361pYpejCf8pWHo5g2zWajHUA5IheD1Ss3w6+uwxeOhko5Chi93G+Z 2JK3ze7vpyZkzLQvl12UdYmM4t3jBwNzQymr0Ezs= Authentication-Results: mail-nwsmtp-smtp-production-main-60.sas.yp-c.yandex.net; dkim=pass header.i=@yandex.ru In-Reply-To: <86zflxvoux.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:295537 Archived-At: On Sun, 2024-11-17 at 17:53 +0200, Eli Zaretskii wrote: > > From: Konstantin Kharlamov > > Cc: gerd.moellmann@gmail.com, acm@muc.de, 74382@debbugs.gnu.org > > Date: Sun, 17 Nov 2024 18:43:17 +0300 > >=20 > > On Sun, 2024-11-17 at 17:37 +0200, Eli Zaretskii wrote: > > > > Cc: Alan Mackenzie , 74382@debbugs.gnu.org > > > > From: Konstantin Kharlamov > > > > Date: Sun, 17 Nov 2024 18:21:36 +0300 > > > >=20 > > > > On Sun, 2024-11-17 at 08:25 +0100, Gerd M=C3=B6llmann wrote: > > > > > Konstantin Kharlamov writes: > > > > >=20 > > > > > > Sure, I just reproduced it after removing all `.elc` files > > > > > > in > > > > > > the > > > > > > repo, > > > > > > here how: > > > > > >=20 > > > > > > 1. `git checkout f2f13fa630b` (a commit from April) > > > > > > 2. `make -j$(nproc)` to compile. Note: you don't need to > > > > > > wait > > > > > > for > > > > > > build > > > > > > to finish, I just waited for all files under `lisp/emacs- > > > > > > lisp` > > > > > > directory to finish compilation, and then ^C'ed it. > > > > > > 3. `git checkout 29098a291f5` (a November commit). > > > > > > 4. `make -j$(nproc)` > > > > >=20 > > > > > This would always work if lisp/Makefile would rm the .elc > > > > > files > > > > > from > > > > > COMPILE_FIRST, right? I suspect this isn't done to speed up > > > > > the > > > > > build > > > > > in > > > > > the usual case, and because it's a bit difficult to > > > > > automatically > > > > > determine if it has to done or not. > > > > >=20 > > > > > Does a "make clean" after the checkout in (3) make it work? > > > >=20 > > > > I don't think so, because `make clean` for some reason doesn't > > > > remove > > > > `.elc` artifacts. > > >=20 > > > And it shouldn't, because *.elc files are part of a release > > > tarball. > >=20 > > But if someone decided to build from a release tarball, sure they > > can > > produce .elc files as well, can't they? >=20 > No, Emacs release tarballs come with *.elc files, and users shouldn't > recompile them.=C2=A0 For starters, it makes the build significantly > longer, besides being unnecessary. >=20 > Recompiling *.elc files is only needed if the corresponding *.el > files > are modified, something that doesn't normally happen when you build a > release tarball. Okay. So, how about a compromise here: provide release tarball with modified Makefiles which upon calling `make clean` would not remove `.elc` files =E2=80=94 but let `make clean` inside git-repository remove el= c files? Users expect `make clean` to remove non-config-related bulid artifacts. Which includes `.elc` files. I can't count how many times I was forgetting about this peculiarity of Emacs build system, and after finding out that even `make clean` doesn't help with build errors (due to COMPILE_FIRST files stuff), I had to nuke everything with `git clean -fdx`. Even Gerd in this discussion forgot about this peculiarity =E2=80=94= and Gerd unlike me is a regular Emacs developer.