From: Paul Eggert <eggert@cs.ucla.edu>
To: Eli Zaretskii <eliz@gnu.org>, Spencer Baugh <sbaugh@janestreet.com>
Cc: 70822@debbugs.gnu.org
Subject: bug#70822: flymake mishandles GCC diagnostics in en_US.UTF-8 locale
Date: Wed, 8 May 2024 10:10:00 -0700 [thread overview]
Message-ID: <a4d3d011-1bfc-4ff6-b181-97e52f353309@cs.ucla.edu> (raw)
In-Reply-To: <86cypwa1yl.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 604 bytes --]
> AFAICT, flymake-tests.el injects LC_ALL=C into process-environment (in
> flymake-tests--call-with-fixture called from
> flymake-tests--with-flymake), so why doesn't that affect the locale
> under which the test runs?
I don't know. But shouldn't flymake also work when LC_ALL='en_US.UTF-8'?
That is, instead of trying (but evidently failing) to check only
LC_ALL='C', shouldn't flymake-tests also check the LC_ALL='en_US.UTF-8'
case?
> And could you perhaps show the error message reported by the failing
> test(s) in that case?
The contents of test/lisp/progmodes/flymake-tests.log are attached.
[-- Attachment #2: flymake-tests.log --]
[-- Type: text/x-log, Size: 2054 bytes --]
Running 9 tests (2024-05-08 10:01:37-0700, selector `(not (or (tag :expensive-test) (tag :unstable)))')
passed 1/9 different-diagnostic-types (1.151769 sec)
passed 2/9 dummy-backends (1.002037 sec)
passed 3/9 eob-region-and-trailing-newline (0.000190 sec)
Test included-c-header-files backtrace:
signal(ert-test-failed (((should (eq 'flymake-warning (face-at-point
ert-fail(((should (eq 'flymake-warning (face-at-point))) :form (eq f
#f(compiled-function () #<bytecode 0x1bee812822f86a40>)()
flymake-tests--call-with-fixture(#f(compiled-function () #<bytecode
#f(compiled-function () #<bytecode -0x1170404b2f5c8feb>)()
#f(compiled-function () #<bytecode 0x899bb4b220fad07>)()
handler-bind-1(#f(compiled-function () #<bytecode 0x899bb4b220fad07>
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name included-c-header-files :documentatio
ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co
ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable)))
ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un
eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) (
command-line-1(("-L" ":." "-l" "ert" "--eval" "(setq treesit-extra-l
command-line()
normal-top-level()
Test included-c-header-files condition:
(ert-test-failed
((should (eq 'flymake-warning (face-at-point))) :form
(eq flymake-warning flymake-error) :value nil))
FAILED 4/9 included-c-header-files (1.045034 sec) at lisp/progmodes/flymake-tests.el:168
passed 5/9 perl-backend (1.034836 sec)
passed 6/9 recurrent-backend (1.004512 sec)
passed 7/9 ruby-backend (1.076380 sec)
passed 8/9 warning-predicate-function-gcc (1.088740 sec)
passed 9/9 warning-predicate-rx-gcc (1.071722 sec)
Ran 9 tests, 8 results as expected, 1 unexpected (2024-05-08 10:01:46-0700, 8.595761 sec)
1 unexpected results:
FAILED included-c-header-files
next prev parent reply other threads:[~2024-05-08 17:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 17:06 bug#70822: flymake mishandles GCC diagnostics in en_US.UTF-8 locale Paul Eggert
2024-05-08 13:05 ` Eli Zaretskii
2024-05-08 17:10 ` Paul Eggert [this message]
2024-05-08 18:38 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4d3d011-1bfc-4ff6-b181-97e52f353309@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=70822@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=sbaugh@janestreet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).