bug#56613: 29; minibuffer-complete-history throws an error for minibuffer-history-variable=t

[Daniel Mendler <mail@daniel-mendler.de>]

Thanks! Btw, I noticed that you disable sorting by let binding
completions-sort to nil. This is not the proper way to disable sorting.
The variable is meant for user configuration of the default completion UI.

In order to disable sorting from the side of the completion table, it is
better to use the completion metadata. This way the sort function will
also be picked up by all the alternative completion UIs.

(completion-in-region
 (minibuffer--completion-prompt-end) (point-max)
 (lambda (str pred action)
   (if (eq action 'metadata)
       '(metadata (display-sort-function . identity)
                  (cycle-sort-function . identity))
     (complete-with-action action completions str pred))))

On 7/17/22 20:07, Juri Linkov wrote:
> close 56613 29.0.50
> thanks
> 
>> One can pass HIST=t to completing-read in order to disable the
>> minibuffer history. minibuffer-complete-history fails with an error
>> in that case. Instead it should act as a no-op or print a meaningful
>> error message (No history available).
> 
> Thanks for the bug report, now fixed in 60185819b6.