From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Steven De Herdt Newsgroups: gmane.emacs.bugs Subject: bug#33494: 25.2; vc-bzr-expanded-log-entry does not honor vc-bzr-log-switches Date: Sat, 24 Nov 2018 23:57:57 +0100 Message-ID: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1543103049 16469 195.159.176.226 (24 Nov 2018 23:44:09 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 24 Nov 2018 23:44:09 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 To: 33494@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Nov 25 00:44:05 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gQhal-000497-Ft for geb-bug-gnu-emacs@m.gmane.org; Sun, 25 Nov 2018 00:44:04 +0100 Original-Received: from localhost ([::1]:58109 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gQhcs-0008DA-21 for geb-bug-gnu-emacs@m.gmane.org; Sat, 24 Nov 2018 18:46:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53778) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gQhcj-0008Cp-Bv for bug-gnu-emacs@gnu.org; Sat, 24 Nov 2018 18:46:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gQhcg-0002xb-7j for bug-gnu-emacs@gnu.org; Sat, 24 Nov 2018 18:46:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41692) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gQhcg-0002xT-47 for bug-gnu-emacs@gnu.org; Sat, 24 Nov 2018 18:46:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gQhcf-0007Mv-W2 for bug-gnu-emacs@gnu.org; Sat, 24 Nov 2018 18:46:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Steven De Herdt Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 Nov 2018 23:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 33494 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.154310311228263 (code B ref -1); Sat, 24 Nov 2018 23:46:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 24 Nov 2018 23:45:12 +0000 Original-Received: from localhost ([127.0.0.1]:45950 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gQhbs-0007Ln-4h for submit@debbugs.gnu.org; Sat, 24 Nov 2018 18:45:12 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:55540) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gQgsO-0006AR-Io for submit@debbugs.gnu.org; Sat, 24 Nov 2018 17:58:13 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gQgsI-0003xR-BX for submit@debbugs.gnu.org; Sat, 24 Nov 2018 17:58:07 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:60869) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gQgsI-0003xF-8e for submit@debbugs.gnu.org; Sat, 24 Nov 2018 17:58:06 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36916) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gQgsH-0001aL-FW for bug-gnu-emacs@gnu.org; Sat, 24 Nov 2018 17:58:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gQgsD-0003sR-Fh for bug-gnu-emacs@gnu.org; Sat, 24 Nov 2018 17:58:05 -0500 Original-Received: from mail-ed1-x533.google.com ([2a00:1450:4864:20::533]:46468) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gQgsD-0003rI-9S for bug-gnu-emacs@gnu.org; Sat, 24 Nov 2018 17:58:01 -0500 Original-Received: by mail-ed1-x533.google.com with SMTP id o10so12844869edt.13 for ; Sat, 24 Nov 2018 14:58:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:subject:from:message-id:date:user-agent:mime-version :content-language:content-transfer-encoding; bh=H3SwP5j6T5gqjOciXbsWxIbuYjz/tUy+eU2XNwn7BA8=; b=lMeqPB89/e/RpD4jFS+5YOVN/Kg0TJ2X1mpo6sn6P6Ve4xAxAbmbpJjyjL9CDRKn5y dpcin9Lc2SaWoBkhoESZCrtW/2pMHapQb7TabdaHP+tMZDHVM8blt1ttf//yZ3FpDVnO nkExf7JxhqVUQ0WsivJ4ElCtqtIMAH0iQUiApQ8BPT+BUCfejGDlL7XIti7Y6GalwLxy JyV22qJ1EwscArJ+lAB4iiffEQivRuo+RfkyE59E5FgjlsireGgqE3bbh/StTFFXefdL NKBI5XdYpdq6nbA7sI5h2wPgesGe6ZPd8XSW1v3pJTmlFFnjHt8W3NDGaGhS4Yx96Ru7 im8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:subject:from:message-id:date:user-agent :mime-version:content-language:content-transfer-encoding; bh=H3SwP5j6T5gqjOciXbsWxIbuYjz/tUy+eU2XNwn7BA8=; b=Dvx3eENYeg0N2MWLNhtP3Q0iPhZOFQK9bLZPN+zhHIjTRux4jUw2CRRj4PT4yXKjj7 bROOALywDI3WKRZUhd3uMch0ayYVuwQpGRXlDr35KNR2HvB3ObNOZ1iiwxj3+e4suGHf 1PHL0ufJtWjb/WnpSdM6e+0zZBNtRVkxBjkMjDFrl+OsrnoWA2K+g5qx71gSMYxygR83 RXh/6gulsCOJuJaRL8BxTqLAyCmRt+6/+q/RhgzLPRCwFtHoNOXjTZtYOVOLfnx2H3mE 2oLng2RyyIhPp8F/c498ep4X+9p9WaMTmNj928/GiyeTm7vvkV27GOLvE02IgRxl4BMl YPSg== X-Gm-Message-State: AA+aEWZtS0liT8Y6lGxQmNlza03eFoaqDYJPYKwHOPDZDsyxjyR8bWsN 7yL4YY/bGaMRxJ289f3OcyhXcrf9 X-Google-Smtp-Source: AFSGD/Xi1OMLCGJvNNGgDISguzbhvCum+z6WXO5CJaVjKk28DW+a4KJhGU1Srodh/xxa1kJDDqzTyg== X-Received: by 2002:a50:b006:: with SMTP id i6mr3440029edd.84.1543100279689; Sat, 24 Nov 2018 14:57:59 -0800 (PST) Original-Received: from [192.168.1.15] (ip-83-134-210-48.dsl.scarlet.be. [83.134.210.48]) by smtp.googlemail.com with ESMTPSA id w28sm7291253edd.38.2018.11.24.14.57.58 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 24 Nov 2018 14:57:58 -0800 (PST) Content-Language: nl X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Mailman-Approved-At: Sat, 24 Nov 2018 18:45:10 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:152748 Archived-At: Hello. In Bzr-Log-View, pressing RET brings up more info about a certain revision, but this expanded log entry does not honor customized switches for 'bzr log'. I hacked vc-bzr-expanded-log-entry to consider these switches just like vc-bzr-print-log does: (defun vc-bzr-expanded-log-entry (revision) (with-temp-buffer (apply 'vc-bzr-command "log" t nil nil (append (list "--long" (format "-r%s" revision)) (if (stringp vc-bzr-log-switches) (list vc-bzr-log-switches) vc-bzr-log-switches))) (goto-char (point-min)) (when (looking-at "^-+\n") ;; Indent the expanded log entry. (indent-region (match-end 0) (point-max) 2) (buffer-substring (match-end 0) (point-max))))) I don't know a lot of Emacs Lisp, but it does work with 'emacs -q'... Thanks for you work on Emacs! -Steven