unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Steven De Herdt <steven.deherdt@gmail.com>
To: 33494@debbugs.gnu.org
Subject: bug#33494: 25.2; vc-bzr-expanded-log-entry does not honor vc-bzr-log-switches
Date: Sat, 24 Nov 2018 23:57:57 +0100	[thread overview]
Message-ID: <a4a86fbf-ab96-604c-89b4-137a382873a1@gmail.com> (raw)

Hello.

In Bzr-Log-View, pressing RET brings up more info about a certain
revision, but this expanded log entry does not honor customized switches
for 'bzr log'.  I hacked vc-bzr-expanded-log-entry to consider these
switches just like vc-bzr-print-log does:

(defun vc-bzr-expanded-log-entry (revision)
  (with-temp-buffer
    (apply 'vc-bzr-command "log" t nil nil
     (append
      (list "--long" (format "-r%s" revision))
      (if (stringp vc-bzr-log-switches)
          (list vc-bzr-log-switches)
        vc-bzr-log-switches)))
    (goto-char (point-min))
    (when (looking-at "^-+\n")
      ;; Indent the expanded log entry.
      (indent-region (match-end 0) (point-max) 2)
      (buffer-substring (match-end 0) (point-max)))))

I don't know a lot of Emacs Lisp, but it does work with 'emacs -q'...

Thanks for you work on Emacs!
-Steven






             reply	other threads:[~2018-11-24 22:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-24 22:57 Steven De Herdt [this message]
2018-12-08  9:35 ` bug#33494: 25.2; vc-bzr-expanded-log-entry does not honor vc-bzr-log-switches Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a4a86fbf-ab96-604c-89b4-137a382873a1@gmail.com \
    --to=steven.deherdt@gmail.com \
    --cc=33494@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).