unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: Juri Linkov <juri@linkov.net>
Cc: 28864@debbugs.gnu.org, Noam Postavsky <npostavs@gmail.com>,
	Tino Calancha <tino.calancha@gmail.com>
Subject: bug#28864: 25.3.50; next-error-no-select does select
Date: Thu, 26 Oct 2017 02:58:18 +0300	[thread overview]
Message-ID: <a3d777e2-1717-047e-34ff-46cd0dcec155@yandex.ru> (raw)
In-Reply-To: <7821c28e-3bf5-0bab-46ab-23f3a02566a8@yandex.ru>

On 10/25/17 1:23 AM, Dmitry Gutov wrote:
> On 10/24/17 11:22 PM, Juri Linkov wrote:
> 
>> So do you propose to prefer buffer-local next-error-last-buffer
>> instead of window-local next-error-last-buffer?
> 
> Maybe something like this:
> 
> - Make next-error-last-buffer always buffer-local.
> 
> - Create the "current next-error source buffer" variable (which we'll 
> need anyway), and whenever we need to look up or set 
> next-error-last-buffer, read it or set it in that buffer.

Sorry, this is nonsense, since next-error-last-buffer contains the 
reference to the "current next-error source buffer" anyway.

Let me amend it.

I propose to use next-error-last-buffer's global value, and avoid 
changing it too easily. Mostly at the user's request (via a special 
command), or when the last next-error-last-buffer has run out of errors, 
and the current buffer has some (this will require some discussion, 
though; maybe add a user prompt?).

>> This can cause
>> problems only when the same buffer can be visited from separate
>> next-error navigations, e.g. from two different *grep* buffers,
>> next-error from such buffer will use only the latest navigation
>> that visited this buffer (until it switched manually to another
>> navigation by a new command) Is this situation frequent enough?

Is there a reason you thought of buffer-local next-error-last-buffer values?

The "current error" is not stored in this variable. Instead, it's 
"saved" in the value of point in the corresponding error-capable buffer.





  reply	other threads:[~2017-10-25 23:58 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-16 13:07 bug#28864: 25.3.50; next-error-no-select does select Tino Calancha
2017-10-17 13:37 ` Dmitry Gutov
2017-10-17 14:17   ` Tino Calancha
2017-10-18  7:44     ` Dmitry Gutov
2017-10-20  7:21       ` Tino Calancha
2017-10-20 21:49         ` Dmitry Gutov
2017-10-21  3:52           ` Tino Calancha
2017-10-22 20:32             ` Juri Linkov
2017-10-22 22:29               ` Dmitry Gutov
2017-10-23 20:12                 ` Juri Linkov
2017-10-23 20:23                   ` Dmitry Gutov
2017-10-24 20:22                     ` Juri Linkov
2017-10-24 22:23                       ` Dmitry Gutov
2017-10-25 23:58                         ` Dmitry Gutov [this message]
2017-10-28 21:07                         ` Juri Linkov
2017-10-28 22:46                           ` Dmitry Gutov
2017-10-29 21:42                             ` Juri Linkov
2017-10-30 14:59                               ` Dmitry Gutov
2017-10-30 18:30                                 ` Eli Zaretskii
2017-10-30 21:13                                   ` Dmitry Gutov
2017-10-30 21:15                                   ` Juri Linkov
2017-10-30 21:14                                 ` Juri Linkov
2017-10-31  0:02                                   ` Dmitry Gutov
2017-10-31 21:56                                     ` Juri Linkov
2017-10-31 23:42                                       ` Dmitry Gutov
2017-11-02 22:00                                         ` Juri Linkov
2017-11-05 13:37                                           ` Dmitry Gutov
2017-11-06 21:41                                             ` Juri Linkov
2017-10-28 20:54             ` Juri Linkov
2017-10-28 22:42               ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a3d777e2-1717-047e-34ff-46cd0dcec155@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=28864@debbugs.gnu.org \
    --cc=juri@linkov.net \
    --cc=npostavs@gmail.com \
    --cc=tino.calancha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).