unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 38791-done@debbugs.gnu.org
Subject: bug#38791: 27.0.60; Multiline mini-window fails to resize after clearing message
Date: Mon, 30 Dec 2019 18:54:14 +0100	[thread overview]
Message-ID: <a36e64a6-44e1-57a5-ab09-fc6d9efa8983@gmx.at> (raw)
In-Reply-To: <83blrpn6y0.fsf@gnu.org>

 >> It apparently never entered my mind that WINDOW_BOX_TEXT_HEIGHT might
 >> mean something different from the height of that window's buffer text.
 >> Shameful.
 >
 > Well, the name is ambiguous.

I'd eventually want to keep only one function among
WINDOW_BOX_TEXT_HEIGHT, window_box_height and window_body_height.  But
before that we'd have to sort out which one to keep among
CURRENT_{MODE,HEADER,TAB}_LINE_HEIGHT,
WINDOW_{MODE,HEADER,TAB}_LINE_HEIGHT and the calculations done in
window_box_height.  Together with window_wants_{mode,header,tab}_line
I'm afraid that we have some circular definition here which is also
confirmed by the fact that using CURRENT_{MODE,HEADER,TAB}_LINE_HEIGHT
within other macros is usually frowned upon by gcc complaining about
missing sequence points due to the

((W)->{mode,header,tab}_line_height

assignments.  Parts of that dilemma also show up in miscalculating the
heights of the vertical scroll bar window as sketched in the thread on
Bug#38181.

In either case the bug you fixed here was all mine when I started to
squeeze the earlier shrink/grow call sequence into a single grow call.

 > I installed the fix, and I'm closing the bug report.

Thanks again, martin





      reply	other threads:[~2019-12-30 17:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-29 14:27 bug#38791: 27.0.60; Multiline mini-window fails to resize after clearing message Eli Zaretskii
2019-12-29 18:33 ` martin rudalics
2019-12-30 15:56   ` Eli Zaretskii
2019-12-30 17:54     ` martin rudalics [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a36e64a6-44e1-57a5-ab09-fc6d9efa8983@gmx.at \
    --to=rudalics@gmx.at \
    --cc=38791-done@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).