From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#25904: Formatting bug with js-mode Date: Sat, 5 May 2018 00:37:13 +0300 Message-ID: References: <87shdp63vk.fsf@gmail.com> <7f9fd974-e768-b532-ad86-33adb531d189@yandex.ru> <87y3n0mvzd.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1525469771 4268 195.159.176.226 (4 May 2018 21:36:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 4 May 2018 21:36:11 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 Cc: 25904@debbugs.gnu.org To: Felipe Ochoa Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri May 04 23:36:07 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fEiN4-00011D-9w for geb-bug-gnu-emacs@m.gmane.org; Fri, 04 May 2018 23:36:06 +0200 Original-Received: from localhost ([::1]:36513 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fEiPB-0003Df-7B for geb-bug-gnu-emacs@m.gmane.org; Fri, 04 May 2018 17:38:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59902) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fEiP0-0003BX-8B for bug-gnu-emacs@gnu.org; Fri, 04 May 2018 17:38:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fEiOw-0002sO-AT for bug-gnu-emacs@gnu.org; Fri, 04 May 2018 17:38:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:42115) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fEiOw-0002rp-5W for bug-gnu-emacs@gnu.org; Fri, 04 May 2018 17:38:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fEiOv-0006rG-RT for bug-gnu-emacs@gnu.org; Fri, 04 May 2018 17:38:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 04 May 2018 21:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25904 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 25904-submit@debbugs.gnu.org id=B25904.152546984526303 (code B ref 25904); Fri, 04 May 2018 21:38:01 +0000 Original-Received: (at 25904) by debbugs.gnu.org; 4 May 2018 21:37:25 +0000 Original-Received: from localhost ([127.0.0.1]:50009 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fEiOL-0006qB-KM for submit@debbugs.gnu.org; Fri, 04 May 2018 17:37:25 -0400 Original-Received: from mail-wr0-f176.google.com ([209.85.128.176]:43184) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fEiOJ-0006py-RR for 25904@debbugs.gnu.org; Fri, 04 May 2018 17:37:24 -0400 Original-Received: by mail-wr0-f176.google.com with SMTP id v15-v6so22386861wrm.10 for <25904@debbugs.gnu.org>; Fri, 04 May 2018 14:37:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=qeqLsDZ0DFXNNRxDjuU+WQLFhuEqdWLXbkz5w/lTBKg=; b=GSTl91Zx9lAFfLL2BlytsFdmi9qyT91r+0pBsTClClCE0ES1SVnvOaje5EZKxrDbWp ke1Y4rW163X0XqinkhlXlPkYwkoL+V8kYLkht9vYYzf/GWFhnpZ+0aYggKvX/572eMzP ObnCPVj+2w5PG5pIPUKI/ViTNclqoTbG//95FxRVy7t5e4dg/enXMiW9oJ6DTP/vHk5Z f5w5BfK2/pl/w2fc8YNbRmPJtJXNjUE8BMH6McjGMy2O6771KRPRkx84QyKZBOykucOL ClW+jMN32JSXtVLpexXTIwEvrkxJqPZV6W7jTDEfAzEZFCPxPOkdb7uROGEXJMY1ExgU nlXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=qeqLsDZ0DFXNNRxDjuU+WQLFhuEqdWLXbkz5w/lTBKg=; b=fPjDP7IXseGAZyxlr/IjX/UO22yOTSY451RBFa504nB55q99dYY/EAWFYe3Cika6xL s6Tof04bN+hlksqn/rvD83TNVF7Y8GsEzAzlM1pMjd3bBRZBvmybccAxDnFAuicw/OL7 05FQRByoGvwJkfI5cGJxLnLXiaMzaBv1Ba7Zb0P4dJilsLadGctiyv1MfXAnnIacmw6H H3SUaeoyPPPpYPXWfbSn9nZrj/qRSjxzvEP4wVwtB/Qe9sND8SmFloZQkDpp0AV3z50Q iyL5vNoxcveMeAK0pM9+4WOgVKPzgnctbDmSzvv6TrxTW/VlmHzD9k3WC6TzY5MtPM6B zgpA== X-Gm-Message-State: ALQs6tDrjK2w/EdDPOHecbsNW+8I6+olUbwL6D01UwFHYQ/IGfpBtV29 nM74XmX1W6GV+14upB/+gj4tqroN X-Google-Smtp-Source: AB8JxZpnz97QJgpOw8PW0kIMCQ3qlRLm//C1dQF7JsmCm7dUQIcQiz4N/3LE+L0fVy0ARzWBoJY3Dw== X-Received: by 2002:adf:b2f5:: with SMTP id g108-v6mr24314240wrd.147.1525469837755; Fri, 04 May 2018 14:37:17 -0700 (PDT) Original-Received: from [192.168.1.3] ([185.105.174.23]) by smtp.googlemail.com with ESMTPSA id b18-v6sm27200638wrb.55.2018.05.04.14.37.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 04 May 2018 14:37:16 -0700 (PDT) In-Reply-To: Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:146018 Archived-At: On 3/16/18 3:06 AM, Felipe Ochoa wrote: > This has taken a *little* longer than I'd hoped, but here's a new > patch with all the discussed changes. Hopefully I got the commit > message formatting and content right Not really. First of all, I asked for an attached file ('git am' needs a file), and not its contents inside the message body. Which suffered word-wrap damage during transmission (because that's what email clients do). I would commit it this time anyway, though, if not for the next point. > From 0c7eed3fd9f7f77a071296c191e8569471bac4e5 Mon Sep 17 00:00:00 2001 > From: Felipe Ochoa > Date: Tue, 7 Nov 2017 16:50:42 -0500 > Subject: [PATCH] Fixes js indentation after arrow function without parens > > From: felipe > > * lisp/progmodes/js.el (js--proper-indentation) > (js--looking-at-broken-arrow-function-p) I think there was going to be some description here. And there's no mention of changes to js--continued-expression-p and js--proper-indentation. They would have the meat of the explanation. > * test/manual/indent/js.js: Indent expression following an arrow as > though it were enclosed in parentheses This needs a period, at least. > (Bug#25904) We usually put the bug number inside one of the sentences of the change log entry, not just at the end of it. The patch does work, but if you could make the details right, it would be great. We've missed the emacs-26 train, so there's no real hurry.