From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#28403: 25.2; find-tag works, but xref-find-definitions Date: Mon, 11 Sep 2017 00:43:51 +0300 Message-ID: References: <201709092240.v89MeFUo014854@psr.com> <201709100250.v8A2o6nL015568@psr.com> <837ex6vd83.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1505321484 27223 195.159.176.226 (13 Sep 2017 16:51:24 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 13 Sep 2017 16:51:24 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:56.0) Gecko/20100101 Thunderbird/56.0 Cc: 28403@debbugs.gnu.org To: Eli Zaretskii , Winston Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Sep 10 23:45:13 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1drA2O-0002tT-GY for geb-bug-gnu-emacs@m.gmane.org; Sun, 10 Sep 2017 23:45:08 +0200 Original-Received: from localhost ([::1]:54366 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1drA2V-0007Bb-KX for geb-bug-gnu-emacs@m.gmane.org; Sun, 10 Sep 2017 17:45:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58846) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1drA2M-0007AK-Q1 for bug-gnu-emacs@gnu.org; Sun, 10 Sep 2017 17:45:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1drA2J-0001so-NJ for bug-gnu-emacs@gnu.org; Sun, 10 Sep 2017 17:45:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51168) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1drA2J-0001sd-Jg for bug-gnu-emacs@gnu.org; Sun, 10 Sep 2017 17:45:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1drA2H-0002Jz-UA for bug-gnu-emacs@gnu.org; Sun, 10 Sep 2017 17:45:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 Sep 2017 21:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28403 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28403-submit@debbugs.gnu.org id=B28403.15050798438845 (code B ref 28403); Sun, 10 Sep 2017 21:45:01 +0000 Original-Received: (at 28403) by debbugs.gnu.org; 10 Sep 2017 21:44:03 +0000 Original-Received: from localhost ([127.0.0.1]:59849 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1drA1L-0002Ia-24 for submit@debbugs.gnu.org; Sun, 10 Sep 2017 17:44:03 -0400 Original-Received: from mail-lf0-f49.google.com ([209.85.215.49]:37612) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1drA1I-0002Hz-Rr for 28403@debbugs.gnu.org; Sun, 10 Sep 2017 17:44:01 -0400 Original-Received: by mail-lf0-f49.google.com with SMTP id 80so14424088lfy.4 for <28403@debbugs.gnu.org>; Sun, 10 Sep 2017 14:44:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=xHKR6KBmMsa7SMoNZ2p9mjwR5XXRAvPNQQfY7ASpLUs=; b=hxPYac7H3s+hwOQ/9vGw29m2/u8QeLhM0syjHz1QUgea+atEELwI9Q11OonzPTZCoe fg0U+l0dr4Wb0YlkPBTZig3Sfv199rPQFrbM0nJGSx2K0gcM0Ad619L6MecsiiKQKuEj 7ePhUcHgqOyeJQ9+InxCngXminpum0scoel96wAAiRy5qQXPqpJKMqJDhLzmyzgaCHm6 fEhIT7Bed630eRa1/4dQ3/uilVLytFOw0IHIg6Y9RQ98x1XMYOJzximNpXLCrsS8vp3A QAnwi79nZSzY+VcQ5xMvSpJKqQcEGIOw0EcMDQc5BXKa2Y6E7+jHqGqLHS42Ceeij94K vCRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=xHKR6KBmMsa7SMoNZ2p9mjwR5XXRAvPNQQfY7ASpLUs=; b=igJclUpU+aBJNkVeKpBsjpL8YmPJDrKbkclo74ZmaxJC1oZbfZPqTN8fapghJJxvUD XQRC3KH7aqt5TrK59bfywa4Yv8cS5B/aSEFdeNdpcczU04dJQd81JSG8rZ6j6zPhb5vL m5/kXO5unuZcohwYRo9GcT+AdMUSK9pXyevTYHemTjvxXQdS29UcHpvu2m6fpL9nuXtA 1Njyiil3RFArBLmxm7UuB8IktYgpoCjVrV9VG81kjGOkKnIVFqZRzWtKwzpr2O4TXjKs 7B905R/yvLTIRU1CInLPxOT66M0Pdioq/A6ufWlx02joPA+9En/w7rDS8it2GQjNo1rB XzqA== X-Gm-Message-State: AHPjjUhIscDb54MaJdQz6Vr4Ef4IHvzM2HoYxVZal2rNiHaW2jvxYPj5 4Cv58W4Rn/AazSRueYY= X-Google-Smtp-Source: ADKCNb5RpS/0HBfKBFeo+20dMPRp7Zdmc3DPb4HHKKWb/NCLL/zH23TJJRy5VnVscZ5jXBrdU1pkoQ== X-Received: by 10.46.25.23 with SMTP id p23mr1743784lje.37.1505079834571; Sun, 10 Sep 2017 14:43:54 -0700 (PDT) Original-Received: from [192.168.1.174] ([178.252.127.239]) by smtp.googlemail.com with ESMTPSA id h64sm445507ljf.36.2017.09.10.14.43.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 10 Sep 2017 14:43:53 -0700 (PDT) In-Reply-To: <837ex6vd83.fsf@gnu.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:136893 On 9/10/17 5:29 PM, Eli Zaretskii wrote: >>> Try adding `tag-symbol-match-p' to >>> etags-xref-find-definitions-tag-order. This example should work then, >>> but you'll get more false positives (like treating return types as >>> function names). > > Dmitry, how about providing a more user-friendly customization to that > effect? As a "fire escape"? We can turn etags-xref-find-definitions-tag-order into a defcustom, with descriptions of what every possible element means. Problems: 1) I have hard time imagining how we're going to have descriptions for both tag-exact-match-p and tag-implicit-name-match-p that are different and make sense to the user. 2) The user will have to find out about etags-xref-find-definitions-tag-order first anyway. Or we could add a custom variable to xref with a higher-level meaning... that would require support from backends, then.